[GitHub] drill pull request: DRILL-3743: Fail active listeners if server co...

2016-04-04 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/460#discussion_r58491998 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java --- @@ -351,20 +352,5 @@ public void success(QueryId queryId, B

[GitHub] drill pull request: DRILL-3743: Fail active listeners if server co...

2016-04-04 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/460#discussion_r58491800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java --- @@ -278,49 +297,31 @@ public void queryIdArrived(QueryId qu

[GitHub] drill pull request: DRILL-3743: Fail active listeners if server co...

2016-04-04 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/460#discussion_r58491456 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java --- @@ -189,20 +218,10 @@ private UserResultsListener newUserR

[jira] [Created] (DRILL-4578) "children" missing from results of full scan over JSON data

2016-04-04 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-4578: - Summary: "children" missing from results of full scan over JSON data Key: DRILL-4578 URL: https://issues.apache.org/jira/browse/DRILL-4578 Project: Apache Drill

Populating Operator Table

2016-04-04 Thread Sudheesh Katkam
Hey y’all, It seems an instance of DrillOperatorTable is created per query . With type inference changes, this adds to the query startup time (not part of query time, rather

[jira] [Created] (DRILL-4577) Improve performance for query on INFORMATION_SCHEMA when HIVE is plugged in

2016-04-04 Thread Sean Hsuan-Yi Chu (JIRA)
Sean Hsuan-Yi Chu created DRILL-4577: Summary: Improve performance for query on INFORMATION_SCHEMA when HIVE is plugged in Key: DRILL-4577 URL: https://issues.apache.org/jira/browse/DRILL-4577 Pro

[GitHub] drill pull request: DRILL-3743: Fail active queries if server conn...

2016-04-04 Thread sudheeshkatkam
GitHub user sudheeshkatkam opened a pull request: https://github.com/apache/drill/pull/460 DRILL-3743: Fail active queries if server connection is closed + Remove dead code + Improve error and logging messages @jacques-n @adeneche please review. You can merge this pull

Re: [DISCUSS] Nonblocking RPC

2016-04-04 Thread Sudheesh Katkam
Yes, resubmit to the serialized executor (RpcEventHandler). I wasn’t thinking of changing the channel pipeline, if this is what you mean by breaking the encapsulation model. Maybe handlers can get to this executor through a context object. Right now, this will not work with the SameExecutor (st

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-04 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/445#discussion_r58483415 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -177,6 +182,13 @@ public void run() { });

[GitHub] drill pull request: DRILL-3714: Query runs out of memory and remai...

2016-04-04 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/442#discussion_r58482936 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java --- @@ -159,19 +159,15 @@ public ChannelClosedHandler(C clientConnection, Channel

[jira] [Created] (DRILL-4576) Add StoragePlugin API to register materialization into planner

2016-04-04 Thread Laurent Goujon (JIRA)
Laurent Goujon created DRILL-4576: - Summary: Add StoragePlugin API to register materialization into planner Key: DRILL-4576 URL: https://issues.apache.org/jira/browse/DRILL-4576 Project: Apache Drill

Re: [GitHub] drill pull request: DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SU...

2016-04-04 Thread Jean-Claude Cote
Hi, This is my first pull request so I just wanted to make sure it was done correctly and that the JIRA Drill-4573 issue is in the correct state. Can someone confirm it's ok? How long should I expect before someone looks it over? Thank you Jean-Claude On Fri, Apr 1, 2016 at 11:44 PM, jcmcote w

[jira] [Created] (DRILL-4575) alias not working on field.

2016-04-04 Thread Hugo Bellomusto (JIRA)
Hugo Bellomusto created DRILL-4575: -- Summary: alias not working on field. Key: DRILL-4575 URL: https://issues.apache.org/jira/browse/DRILL-4575 Project: Apache Drill Issue Type: Bug Affe

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

2016-04-04 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/430#issuecomment-205420100 +1 revised version LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] drill pull request: DRILL-3714: Query runs out of memory and remai...

2016-04-04 Thread adeneche
Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/442#issuecomment-205413711 Well the workaround is already implemented and as I stated in the JIRA, my knowledge around Netty is basic so it will probably take me quite some time to figure out a cl

[GitHub] drill pull request: DRILL-3714: Query runs out of memory and remai...

2016-04-04 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/442#issuecomment-205413400 I'm working on an alternative approach where the coordination queue is associated with each connection. Upon review, it still needs thread protection because you have c

[GitHub] drill pull request: DRILL-3714: Query runs out of memory and remai...

2016-04-04 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/442#issuecomment-205412305 +0 Why do we need a work around? I think Jacques is suggesting to move the logic to RemoteConnection, which is much cleaner. --- If your project is set u

CTAS query stuck

2016-04-04 Thread François Méthot
Hi, Using Drill 1.5, 13 nodes (6 cores each, Max Dir. Mem: 32GB, Max Heap 8 GB). Sometime our CTAS queries gets "stuck". It runs for few hours or days and in the Fragment profiles graph, we see that the query is waiting on a single fragment ( for what appears to be a single horizontal line in

Simple query on 150 billion records

2016-04-04 Thread François Méthot
Hi, Querying 150 Billion records spread over ~21 000 parquets stored in hdfs on 13 nodes (6 cores each, Max Dir. Mem: 32GB, Max Heap 8 GB). Is their a known issue or drill limitation that would explain why the first query below can't return the expected single row and aggregation ? create tabl

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/445#discussion_r58358260 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -177,6 +182,18 @@ public void run() { });