Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70002787
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void doOnMa
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70002368
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java
---
@@ -151,7 +152,7 @@ protected void c
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70002215
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void doOnMa
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r6975
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -1273,5 +1295,11 @@ public boolean generatedKeyAlway
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69997781
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -36,6 +42,7 @@
*/
class DrillDatabaseMetaDataI
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69997455
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -219,11 +226,26 @@ public boolean storesMixedCaseQuotedId
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69997336
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -219,11 +226,26 @@ public boolean storesMixedCaseQuotedId
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69995961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getP
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69995586
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getP
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69994120
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java ---
@@ -591,4 +591,27 @@ public void
showProperMsgWhenTryingToDro
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993981
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -171,4 +175,45 @@ public void testDropOnImmutableSchema() throws
Exce
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/541
I am unable to review changes to `SqlDropView` and `ViewHandler` classes.
They show up as binary files. Please fix?
---
If your project is set up for it, you can reply to this email and have y
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993147
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropTable.java
---
@@ -57,13 +63,20 @@ public SqlOperator getOperato
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993161
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropTable.java
---
@@ -92,4 +105,6 @@ public SqlIdentifier getTableI
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993129
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -69,6 +71,15 @@ public PhysicalPlan getP
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993188
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -19,14 +19,18 @@
import org.apache.drill.common.exceptions.
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69993113
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
---
@@ -84,4 +84,10 @@ public void testGetJson
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69992451
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -139,6 +151,24 @@ public SqlNode parse(String sql) {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69991686
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
* Parses a drop vie
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69991381
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -245,15 +247,17 @@ SqlNode SqlCreateTable() :
* Parses a drop table state
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r69991328
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
* Parses a drop vie
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69990725
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -61,7 +61,8 @@ public static PhysicalPlan getPlan(QueryC
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69990123
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -274,6 +274,9 @@
String ENABLE_BULK_LOAD_TABLE_LIST_KEY =
"exe
I also agree on using Zookeeper. I have re-worked dynamic UDF support
document taking into account Zookeeper usage.
Link to the document -
https://docs.google.com/document/d/1MluM17EKajvNP_x8U4aymcOihhUm8BMm8t_hM0jEFWk/edit
Kind regards
Arina
On Tue, Jun 28, 2016 at 12:55 AM Paul Rogers wrote:
We really should update that FAQ. Drill could, but does not yet, take
advantage of SIMD instructions.
Drill is columnar, which means that the in memory representation of data is
columnar and everything in Drill operates on columns of data instead of row
by row operation. So, potentially we could us
25 matches
Mail list logo
