[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83983884 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -176,6 +180,23 @@ public void setAutoRead(boolean enableAutoRead)

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83983836 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserProtos.java --- @@ -255,6 +255,152 @@ public static int getFieldNumber(java.lang.String

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83982899 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -176,6 +180,23 @@ public void setAutoRead(boolean enableAutoRead)

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83982861 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java --- @@ -54,6 +55,10 @@ private void throwIfClosed() throws Alre

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83982790 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserProtos.java --- @@ -255,6 +255,152 @@ public static int getFieldNumber(java.lang.Strin

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83981530 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java --- @@ -54,6 +55,10 @@ private void throwIfClosed() throws Alrea

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83982303 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserProtos.java --- @@ -255,6 +255,152 @@ public static int getFieldNumber(java.lang.String

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r83980514 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -176,6 +180,23 @@ public void setAutoRead(boolean enableAutoRead)

[GitHub] drill issue #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread adeneche
Github user adeneche commented on the issue: https://github.com/apache/drill/pull/581 There seem to be an issue with milliseconds. Consider the following: ```TO_DATE('2013-01-01 12:13:14.001', '-MM-DD HH:MI:SS:MS')``` This works fine in Postgresql but fails in Drill with the

[GitHub] drill issue #623: Added -P to CD handle symbolic links in PWD

2016-10-18 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/623 +1 (non-binding) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] drill pull request #623: Added -P to CD handle symbolic links in PWD

2016-10-18 Thread Ben-Zvi
GitHub user Ben-Zvi opened a pull request: https://github.com/apache/drill/pull/623 Added -P to CD handle symbolic links in PWD The use of plain "cd" with a symbolic link to a directory maintains the logical name (i.e., includes the link's name), hence in a script, when a path is s

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/605 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request #593: DRILL-3178 csv reader should allow newlines inside ...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill issue #597: DRILL-4905: Push the LIMIT down to the parquet reader.

2016-10-18 Thread ppadma
Github user ppadma commented on the issue: https://github.com/apache/drill/pull/597 updated diffs with review comments taken care of. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] drill pull request #597: DRILL-4905: Push the LIMIT down to the parquet read...

2016-10-18 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/597#discussion_r83965044 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java --- @@ -117,4 +119,18 @@ public void testSelectEmptyNoCach

[GitHub] drill pull request #597: DRILL-4905: Push the LIMIT down to the parquet read...

2016-10-18 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/597#discussion_r83965017 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -139,6 +155,11 @@ public ParquetRecord

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-18 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/622 DRILL-4369: Exchange name and version infos during handshake There's no name and version exchanged between client and server over the User RPC channel. On client side, having access to

[GitHub] drill issue #621: DRILL-4950: Remove incorrect false condition; consume all ...

2016-10-18 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/621 +1. Thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] drill pull request #621: DRILL-4950: Remove incorrect false condition; consu...

2016-10-18 Thread sudheeshkatkam
GitHub user sudheeshkatkam opened a pull request: https://github.com/apache/drill/pull/621 DRILL-4950: Remove incorrect false condition; consume all empty batches @parthchandra please review You can merge this pull request into a Git repository by running: $ git pull https://gi

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83908798 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -739,30 +739,54 @@ public void runTestAnd

Re: Drill Hangout will start in couple of minutes.

2016-10-18 Thread Jinfeng Ni
Hi Arina, Sorry I was not clear enough in my last message. Today's hangout was done already; it's a short one. Jinfeng On Tue, Oct 18, 2016 at 10:25 AM, Arina Yelchiyeva wrote: > Unfortunately doesn't help, followed the link but only shows: Requesting to > join the video call... > > Kind regar

Re: Drill Hangout will start in couple of minutes.

2016-10-18 Thread Arina Yelchiyeva
Unfortunately doesn't help, followed the link but only shows: Requesting to join the video call... Kind regards Arina On Tue, Oct 18, 2016 at 8:22 PM, Jinfeng Ni wrote: > I copied the link from Drill webpage [1]. > > There was a connection issue in the middle of today's short hangout. > Not sur

[jira] [Created] (DRILL-4951) Running single HBase Unit Test results in error: java.lang.IllegalAccessError: tried to access method com.google.common.base.Stopwatch.()V

2016-10-18 Thread Chunhui Shi (JIRA)
Chunhui Shi created DRILL-4951: -- Summary: Running single HBase Unit Test results in error: java.lang.IllegalAccessError: tried to access method com.google.common.base.Stopwatch.()V Key: DRILL-4951 URL: https://issue

Drill Hangout Minutes - 10/18/16

2016-10-18 Thread Zelaine Fong
Attendees - Jinfeng, Karthik, Khurram, Sorabh, Kunal, Padma, Zelaine Questions on behavior of Drill when querying on empty files/directories - Khurram - Empty directory case currently returns table not found. Consensus was that this is correct. Because without any files, Drill doesn't kno

Re: Drill Hangout will start in couple of minutes.

2016-10-18 Thread Jinfeng Ni
I copied the link from Drill webpage [1]. There was a connection issue in the middle of today's short hangout. Not sure if you just tried to join around that time. [1] https://drill.apache.org/community-resources/ On Tue, Oct 18, 2016 at 10:06 AM, Arina Yelchiyeva wrote: > Jinfeng, > > is link

Re: Drill Hangout will start in couple of minutes.

2016-10-18 Thread Arina Yelchiyeva
Jinfeng, is link correct? Can't join video call. Kind regards Arina On Tue, Oct 18, 2016 at 7:55 PM, Jinfeng Ni wrote: > Link : https://hangouts.google.com/hangouts/_/maprtech.com/ > drillbi-weeklyhangout > > > Thanks, > Jinfeng >

Drill Hangout will start in couple of minutes.

2016-10-18 Thread Jinfeng Ni
Link : https://hangouts.google.com/hangouts/_/maprtech.com/drillbi-weeklyhangout Thanks, Jinfeng

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83853146 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -132,6 +132,8 @@ OptionValidator PARQUET_VECTOR_FILL_CHECK_THRES

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83852721 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -899,18 +883,21 @@ public void testLastPageOn

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

2016-10-18 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r83853471 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -45,4 +53,34 @@ public static int getIntFromLEByt

[GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/581#discussion_r83871818 --- Diff: logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java --- @@ -0,0 +1,213 @@ +/* +* Licensed to the Apache

[GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/581#discussion_r83871606 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java --- @@ -408,6 +411,12 @@ private LogicalExpression getDril

[GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/581#discussion_r83871870 --- Diff: logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java --- @@ -0,0 +1,213 @@ +/* +* Licensed to the Apache

[GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/581#discussion_r83871748 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java --- @@ -408,6 +411,12 @@ private LogicalExpression getDril

[GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/581#discussion_r83870798 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AnsiToJoda.java --- @@ -0,0 +1,58 @@ +/* +* Licensed to the Apache Sof

[GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/581#discussion_r83871584 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java --- @@ -408,6 +411,12 @@ private LogicalExpression getDril

[GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-18 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/581#discussion_r83871296 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AnsiToJoda.java --- @@ -0,0 +1,58 @@ +/* +* Licensed to the Apache Sof

[GitHub] drill issue #595: DRILL-4203: Parquet File. Date is stored wrongly

2016-10-18 Thread vdiravka
Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/595 @tushu1232 Until this fix is merged into the master you can clone my fork repository (https://github.com/vdiravka/drill), switch to the DRILL-4203 branch and build the project. --- If your project

[GitHub] drill issue #620: add the RDBMS to the schema types

2016-10-18 Thread lvxin1986
Github user lvxin1986 commented on the issue: https://github.com/apache/drill/pull/620 I think RDBMS should be the schema type which driver supports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not