Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/749
+1.
+10 for the JIRA (reads like a whodunit).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/757#discussion_r102711462
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -189,6 +192,10 @@ public ScanResult getClasspathScan
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102725896
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -376,14 +378,14 @@ public void setup(
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102726321
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -73,6 +72,7 @@
private static
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102726705
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -70,33 +70,31 @@ public long readField
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/656
@bitblender Parquet files with INT96 TIMESTAMP values usually are generated
with hive. Those TIMESTAMP values represent the local timezone of the host
where the data was written. To read that values
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/656#discussion_r102732719
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -969,12 +969,15 @@ public void testI
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/656#discussion_r102753732
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -969,12 +969,15 @@ public void testInt96Time
I would like to include:
+ DRILL-4280: https://github.com/apache/drill/pull/578 (going through the last
round of comments)
Thank you,
Sudheesh
> On Feb 22, 2017, at 11:16 PM, Jinfeng Ni wrote:
>
> Hi Drillers,
>
> It has been almost 3 months since we release Drill 1.9. We have
> resolved ple
Hi Jinfeng,
Thanks for volunteering!
The following are working their way though the system:
PRs outstanding:
* DRILL-5275: Sort spill is slow due to repeated allocations
* DRILL-5260: Extend "Cluster Fixture" test framework
* DRILL-5258: Access mock data definition from SQL
* DRILL-5273: Compli
Chunhui Shi created DRILL-5296:
--
Summary: Add option to allow "explain plan for" to hide the json
of the plan
Key: DRILL-5296
URL: https://issues.apache.org/jira/browse/DRILL-5296
Project: Apache Drill
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/757#discussion_r102791958
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -413,4 +413,8 @@
String DYNAMIC_UDF_SUPPORT_ENABLED
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102803026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102805327
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102804544
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102800138
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102805162
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102798683
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102796743
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102800792
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102803614
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102802473
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102798742
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102800590
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102801678
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102806616
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102799356
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102797567
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102807297
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -107,6 +107,9 @@
FOREMAN: ${model.getProfile().getForeman().getAddress()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102805888
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,25 +215,25 @@ public String getContent(
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102798577
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102799849
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102798159
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102809881
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -73,6 +72,7 @@
private st
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102809909
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -376,14 +378,14 @@ public void s
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102812251
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -70,33 +70,31 @@ public long read
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102815318
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102815328
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102585253
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception {
if (e
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102607033
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
}
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102610181
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser {
JsonObj
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102603020
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser {
JsonObj
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102589695
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -99,33 +111,83 @@
// behavior. Production default is DEFAULT
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102584427
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception {
if (e
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102613259
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
}
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102618884
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
}
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102612813
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser {
JsonObj
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102581476
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception {
if (e
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102369640
--- Diff: common/src/test/java/org/apache/drill/test/DrillTest.java ---
@@ -69,6 +71,25 @@
@Rule public TestName TEST_NAME = new TestName();
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102587851
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -99,33 +111,83 @@
// behavior. Production default is DEFAULT
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102600191
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java ---
@@ -0,0 +1,243 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820217
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820546
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820948
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102821345
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102822445
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102823965
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102824195
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102824748
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,25 +215,25 @@ public String getContent() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102830458
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
p
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102830628
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
p
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102826142
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -33,35 +33,52 @@
ParquetRecordR
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102824318
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -351,7 +353,7 @@ public void setup(Op
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102830312
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -33,35 +33,52 @@
ParquetRecordR
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/749#discussion_r102827651
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenBinaryReader.java
---
@@ -70,33 +87,21 @@ public long readField
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102835175
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
p
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102836154
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
p
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102839508
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102840619
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102839683
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102841580
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102846203
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102843879
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102843336
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102839491
--- Diff: common/src/test/java/org/apache/drill/test/DrillTest.java ---
@@ -69,6 +71,25 @@
@Rule public TestName TEST_NAME = new TestName();
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102843167
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -99,33 +111,83 @@
// behavior. Production default is DE
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102848531
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102845074
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser {
Js
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102847232
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102844110
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102844580
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser {
Js
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102844435
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java ---
@@ -0,0 +1,243 @@
+/*
+ * Licensed to the Apache Software Founda
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102841504
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -99,33 +111,83 @@
// behavior. Production default is DE
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102845391
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser {
Js
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102851729
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/757#discussion_r102862607
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -91,7 +91,12 @@ public QueryContext(final UserSession session, f
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/757#discussion_r102862700
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -62,6 +63,7 @@
private final CodeCompiler compiler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/757#discussion_r102862262
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -413,4 +413,8 @@
String DYNAMIC_UDF_SUPPORT_ENABLED =
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/758#discussion_r102862961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -413,4 +413,8 @@
String DYNAMIC_UDF_SUPPORT_ENABLED =
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/758#discussion_r102863394
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -1010,7 +1010,9 @@ public void addToEventQueue(final QuerySt
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/578
Pushed the latest changes. The only thing left is the C++ build
instructions for Cyrus SASL, which, as noted previously, I will commit as
another patch.
Thanks to all the reviewers!
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102867347
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -283,4 +288,22 @@ public void close() throws Exception {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102875280
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,230 @@
+/**
--- End
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102867030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -245,6 +247,18 @@ public SchemaPlus getRootSchema() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102871725
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/AvgWidthMergedStatistic.java
---
@@ -0,0 +1,135 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102872366
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/AbstractMergedStatistic.java
---
@@ -0,0 +1,52 @@
+/*
+ * L
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102866270
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryContextInformation.java
---
@@ -51,6 +51,7 @@ public static QueryContextInformati
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102872916
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/AbstractMergedStatistic.java
---
@@ -0,0 +1,52 @@
+/*
+ * L
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102867208
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -283,4 +288,22 @@ public void close() throws Exception {
1 - 100 of 124 matches
Mail list logo