Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/796#discussion_r115107663
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DrillFileSystem.java
---
@@ -89,22 +89,36 @@ public DrillFileSystem(Configuration
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/824#discussion_r115105784
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
---
@@ -398,6 +398,23 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/824#discussion_r115105670
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1029,14 +1099,14 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/824#discussion_r115104954
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -526,6 +534,48 @@ private void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/824#discussion_r115105413
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -526,6 +534,48 @@ private void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/824#discussion_r115105622
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -680,7 +731,7 @@ private boolean tableModified(List
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/827
DRILL-5481: Persist profiles in-memory only with a max capacity
Refactored NoWriteLocalStore to EphemeralPersistentStore with the ability
to maintain a max capacity
Updated Default values, and
Rahul Challapalli created DRILL-5482:
Summary: Improve the error message when drill process does not
have access to the spill directory
Key: DRILL-5482
URL: https://issues.apache.org/jira/browse/DRILL-5482
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r115103600
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/PhysicalOpUnitTestBase.java
---
@@ -82,6 +81,8 @@
* Look! Doesn't
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r115103872
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestMiniPlan.java
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r115103967
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestMiniPlan.java
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r115102606
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java ---
@@ -307,19 +308,43 @@ public void close() throws Exception {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r115103846
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestMiniPlan.java
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r115102970
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/MiniPlanUnitTestBase.java
---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r115102896
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/MiniPlanUnitTestBase.java
---
@@ -0,0 +1,439 @@
+/*
+ * Licensed to
Kunal Khatua created DRILL-5481:
---
Summary: Allow Drill to persist profiles in-memory only with a max
capacity
Key: DRILL-5481
URL: https://issues.apache.org/jira/browse/DRILL-5481
Project: Apache Drill
Jinfeng Ni created DRILL-5480:
-
Summary: Empty batch returning from HBase may cause
SchemChangeException or incorrect query result
Key: DRILL-5480
URL: https://issues.apache.org/jira/browse/DRILL-5480
Bridget Bevens created DRILL-5479:
-
Summary: Document ANSI format for date/time functions
Key: DRILL-5479
URL: https://issues.apache.org/jira/browse/DRILL-5479
Project: Apache Drill
Issue
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/819
Regarding Paul's suggestion of using sampling (either 1st batch, or `n`
batches), if the sampled length is returned to client as metadata for query
result set, it could cause quite big problems for
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/819
My understanding is Drill would hit a schema change between column with
type of varchar(5) and varchar(10). However, the length calculated in this PR
is from the query metadeta (function
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r115064190
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -510,6 +517,38 @@ public void
Rahul Challapalli created DRILL-5478:
Summary: Spill file size parameter is not honored by the managed
external sort
Key: DRILL-5478
URL: https://issues.apache.org/jira/browse/DRILL-5478
Project:
GitHub user ppadma opened a pull request:
https://github.com/apache/drill/pull/826
DRILL-5379: Set Hdfs Block Size based on Parquet Block Size
Provide an option to specify blocksize during file creation.
This will help create parquet files with single block on HDFS, helping
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r114895578
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BitConnectionConfig.java
---
@@ -46,16 +47,34 @@ protected
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r114897536
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserConnectionConfig.java
---
@@ -35,24 +38,42 @@
private final
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r115038181
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java
---
@@ -217,8 +224,9 @@ public
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r115037769
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java
---
@@ -110,7 +131,18 @@ public void
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r115039025
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java
---
@@ -20,27 +20,35 @@
import
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r115038537
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java ---
@@ -201,10 +223,12 @@ protected SaslException
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/821#discussion_r115026331
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
@@ -308,4 +308,58 @@ public void
Arina Ielchiieva created DRILL-5477:
---
Summary: String functions (lower, upper, initcap) should work for
UTF-8
Key: DRILL-5477
URL: https://issues.apache.org/jira/browse/DRILL-5477
Project: Apache
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/825
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/816
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/800
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/811
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/778
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/819
@jinfengni, @paul-rogers made changes after CR, Please review when possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114963380
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillStringLeftRightFuncHolder.java
---
@@ -0,0 +1,72 @@
+/*
+ *
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114958555
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillConcatFuncHolder.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113906809
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -27,10 +27,14 @@
import
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113930434
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -340,18 +344,18 @@ public static int getJdbcDisplaySize(MajorType
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114591502
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -636,43 +658,63 @@ public static String toString(final MajorType type)
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113912681
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillSubstringFuncHolder.java
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114590735
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillStringLeftRightFuncHolder.java
---
@@ -0,0 +1,72 @@
+/*
+ *
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113906744
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -399,7 +403,13 @@ public static boolean isFixedWidthType(final
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114958443
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
---
@@ -106,15 +106,21 @@
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113910020
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillDecimalSumScaleFuncHolder.java
---
@@ -36,17 +35,7 @@ public
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113937186
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -340,18 +344,18 @@ public static int getJdbcDisplaySize(MajorType
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114592925
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -294,10 +296,21 @@ public static
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113910179
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillStringLeftRightFuncHolder.java
---
@@ -0,0 +1,72 @@
+/*
+ *
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113915317
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -599,10 +598,28 @@ public LogicalExpression
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113908201
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -636,43 +658,63 @@ public static String toString(final MajorType type)
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113912267
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillStringLeftRightFuncHolder.java
---
@@ -0,0 +1,72 @@
+/*
+ *
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114957022
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -340,18 +344,18 @@ public static int getJdbcDisplaySize(MajorType
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113908238
--- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
@@ -636,43 +658,63 @@ public static String toString(final MajorType type)
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114966942
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -394,31 +414,37 @@ public RelDataType
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r114593932
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -510,6 +517,38 @@ public void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/819#discussion_r113915450
--- Diff: protocol/src/main/protobuf/Types.proto ---
@@ -70,8 +70,8 @@ enum MinorType {
message MajorType {
optional MinorType minor_type
Arina Ielchiieva created DRILL-5476:
---
Summary: Calculate return type precision value for substring
functions (substring. substr, left, right)
Key: DRILL-5476
URL:
Arina Ielchiieva created DRILL-5475:
---
Summary: Calculate union type precision and display size
Key: DRILL-5475
URL: https://issues.apache.org/jira/browse/DRILL-5475
Project: Apache Drill
60 matches
Mail list logo
