+1. Even though it was done for log4j in Apache Apex, I am pretty sure
that the same can be done for logback. The only thing to consider is
that all such functionality is specific to a logging provider in use. I
am quite familiar with how it was done in Apex and can help if necessary.
Thank yo
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135382803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/901
@arina-ielchiieva, conflicts are resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/924
DRILL-5740: Ensure spill directories are unique
A recent change added the node name and port to make the spill path
unique. Turns out we need to add this information to the single spill
di
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/922
-1
This seems like a good idea. But, I don't think this is the way we should
go for reasons identified in the JIRA.
For one, we count on the user to provide a parameter to describ
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/868
@ilooner, @Ben-Zvi, the PR is now in master. Have fun!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/868
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/923
Please add a brief description in the PR title.
This PR has commits from other PRs, and has merge conflicts. If this PR
depends on others, then please identify the commits to be reviewed,
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/923
Drill 5723
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/drill DRILL-5723
Alternatively you can review and apply these changes as the
Prasad Nagaraj Subramanya created DRILL-5742:
Summary: CONVERT_FROM_JSON on a non-existing column in a file
throws null pointer exception
Key: DRILL-5742
URL: https://issues.apache.org/jira/bro
Hey Kunal,
I tried rest-assured out for my rest api unit tests and It works. I'll include
it as part of my PR for DRILL-5723.
Thanks,
Tim
From: Timothy Farkas
Sent: Friday, August 25, 2017 2:46:53 PM
To: dev@drill.apache.org
Subject: Re: DrillRestServer Tests
I
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135373441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/922
@ppadma Can you please review this?
The changes have been tested with and without the parameter.
If the env variable is set as `40%` , `drillbit.out` reports
```
Aug 25, 2017 4:30:59 PM
They are showing up again, thanks Pritesh.
Thanks,
Gelbana
On Sat, Aug 26, 2017 at 1:26 AM, Pritesh Maker wrote:
> I was trying to clean up some of the older versions and I didn’t realize
> that marking the older versions as archived will also affect the “Affected
> Versions” field.
> Please tr
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/922
DRILL-5741: During startup Drill should not exceed the available memory
Providing an environment variable - DRILLBIT_MAX_PROC_MEM to ensure that a
Drillbit's max memory parameters, cumulatively, don'
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135371425
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135367166
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369535
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135371136
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135370205
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135366734
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135370016
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135368764
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135370581
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135368986
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369170
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135368337
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import org.apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135371013
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import org.apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369225
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import org.apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369394
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import org.apache
I was trying to clean up some of the older versions and I didn’t realize that
marking the older versions as archived will also affect the “Affected Versions”
field.
Please try it again – I have undone the change.
On 8/25/17, 4:15 PM, "Kunal Khatua" wrote:
That is very odd!
I'd
That is very odd!
I'd expect Fix Version to probably get locked down for already released
versions, but it is odd that affected versions isn’t showing up.
But I do see older JIRAs with older versions visible:
For e.g.
1.10 https://issues.apache.org/jira/projects/DRILL/versions/12338769
But in
For the "Affected Versions" and "Fix Version" JIRA fields, I can only find
the following versions:
- 1.11.0
- 1.12.0
- 2.0
- Future
Aren't versions 1.10.0 and earlier supported anymore ?
Thanks,
Gelbana
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/868
From a note sent by @dvjyothsna:
All the system/session option default values are externalized to the conf
file. Now the options are looked up in the hierarchical order of SESSION -
SYSTE
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
OK. Since I'm not a Parquet expert, have asked Salim to take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r135359090
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/CompareFunctionsProcessor.java
---
@@ -82,466 +45,37 @@ public s
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/914
Merged a set of enhancements & bug fixes. Compared to the first set of
commits:
* Provides tools to print the sometimes-complex tuple model, schema and
writer object used for complex data
I got something that does more or less what I want. It is easy to start a drill
bit with the web server in tests now with the existing Fixture infrastructure.
FixtureBuilder builder = ClusterFixture.builder().
configProperty(ExecConstants.HTTP_ENABLE, true)
ClusterFixture cluster = builder.bui
+1 for exploring adding this feature. We had a feature to dynamically change
log levels at runtime through the rest API in Apache Apex and it was very
helpful with debugging things.
From: Paul Rogers
Sent: Friday, August 25, 2017 11:01:29 AM
To: dev@drill.apache
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/805
@paul-rogers, PR is already merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/868
@dvjyothsna @paul-rogers Tim here. When do you guys think this PR will go
in? Seems like it didn't make it into this last batch of commits :(. I will be
opening another PR soon that is dependent on th
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/875
Where are we on this PR? A note three weeks ago said that another commit
would be coming; but haven't see it...
---
If your project is set up for it, you can reply to this email and have your
rep
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351043
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
@@ -46,14 +56,18 @@ public Project(@JsonProperty("exprs")
Li
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
@@ -35,9 +35,19 @@
static final org.slf4j.Logger logge
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
Thanks for addressing my questions. While waiting for DRILL-5660, I wonder
if we can ask Salim to take a look?
---
If your project is set up for it, you can reply to this email and have your
repl
Kunal Khatua created DRILL-5741:
---
Summary: Drillbit during startup should not exceed the available
memory on a node
Key: DRILL-5741
URL: https://issues.apache.org/jira/browse/DRILL-5741
Project: Apache
Chun Chang created DRILL-5740:
-
Summary: hash agg fail to read spill file
Key: DRILL-5740
URL: https://issues.apache.org/jira/browse/DRILL-5740
Project: Apache Drill
Issue Type: Bug
Com
All,
I thought I’d share with the community, but I just finished a NodeJS driver for
Drill. It’s available here: https://github.com/cgivre/drill-nodejs or via
npm install drill-client.
Keep in mind, I know nothing about NodeJS, but it largely follows the
functionality of PyDrill. I’ll updat
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/910#discussion_r135193811
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
---
@@ -230,6 +230,27 @@ public WebUserConnection provide() {
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/910#discussion_r135193019
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java
---
@@ -54,7 +56,10 @@
@Path("/query")
@Produces(Me
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/910#discussion_r135194263
--- Diff: exec/java-exec/src/main/resources/rest/query/query.ftl ---
@@ -21,8 +24,16 @@
×
Sample SQL query: SELECT * FROM cp.`employee.json` L
Hi Kunal,
Don’t know about rereading the config file, but I have had luck in the unit
test framework with adjusting log levels programmatically. (Tests turn on
interesting log levels for the duration of a single tests.) We might be able to
use that capability (provided by Logback) to make adjus
I figured this is a rarely modified piece of code but most frequently used
across all components. Hoping that someone who might have worked on logging can
share some insight from their experience in general, if not within Drill.
I was wondering if changes to Drill's logback.xml can be picked up
Krystal pointed out to an existing tool that allows testing for REST APIs.
https://github.com/rest-assured/rest-assured
Unfortunately, we're currently running short of hands in getting a good robust
prototype for this.
Is anyone interested in volunteering?
-Original Message-
From: Pau
Github user ilooner-mapr commented on the issue:
https://github.com/apache/drill/pull/913
@vrozov I've fixed the source.skip switch to be maven.source.skip as you
pointed out. For now I also made the **script** tag a noop since as you said
the mvn package command is redundant at this
Github user ilooner-mapr commented on a diff in the pull request:
https://github.com/apache/drill/pull/913#discussion_r135312783
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the Licens
To simplify code reviews in this area, should we add tests? Might be mighty
hard to “mentally execute” in lieu of tests…
- Paul
> On Aug 25, 2017, at 9:40 AM, Parth Chandra wrote:
>
> Don't think there are any unit tests, and again there is no rest api
> client. The UI is the only test tool, s
Don't think there are any unit tests, and again there is no rest api
client. The UI is the only test tool, sadly.
On Thu, Aug 24, 2017 at 12:55 PM, Timothy Farkas wrote:
> Hi All,
>
> I want to add some unit tests for a new rest endpoint I added to the
> DrillRestServer. I've been looking but I
GitHub user dvjyothsna opened a pull request:
https://github.com/apache/drill/pull/921
DRILL-4286 Graceful shutdown of drillbit
Following is the design document
https://docs.google.com/document/d/1AauIwVCjsBKBSbbU6sQODErrEp7n3IwniMtgK4m09MQ/edit#heading=h.224lbmcaxu2d.
I wi
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r135292416
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -231,6 +236,12 @@ public static boolean isScalarSu
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/913#discussion_r135291374
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/913
@parthchandra LGTM. There are questions that I have related to how
travis-ci build is configured, but they are for pre-existing settings and can
be addressed in a follow up PR if necessary.
---
If yo
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/915
Two functional unit tests are failing after the changes:
```
/root/drillAutomation/drill-test-framework/framework/resources/Functional/datetime/datetime189.q
Query:
select min
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/911
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/908
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r135254275
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -231,6 +236,12 @@ public static boolean isScalarSubq
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r135249441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -204,24 +205,28 @@ public static void
addLeastRestr
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/901
@paul-rogers please resolve the conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Hi all,
since there are many new contributors in Apache Drill project, I'd like to
outline the main points on how to work on Jira tickets, create PRs and
merge the changes.
*When you start working on Apache Drill Jira ticket*
1. Please add yourself as the assignee and put Jira status `In progres
[
https://issues.apache.org/jira/browse/DRILL-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-4690.
-
Resolution: Fixed
Reviewer: Parth Chandra
Fix Version/s: 1.8.0
> Header in
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r135196236
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -204,24 +205,28 @@ public static void
addLeastRes
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/889#discussion_r135199961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
---
@@ -231,6 +236,12 @@ public static boolean isScalarSu
74 matches
Mail list logo