[GitHub] drill pull request #982: Fixed queued time calculation

2017-10-09 Thread prasadns14
GitHub user prasadns14 opened a pull request: https://github.com/apache/drill/pull/982 Fixed queued time calculation @paul-rogers please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/prasadns14/drill DRILL-5716 Alternati

[GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation

2017-10-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/928 ---

[GitHub] drill pull request #965: DRILL-5811 reduced repeated log messages further.

2017-10-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/965#discussion_r14359 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java --- @@ -104,12 +104,16 @@ public BlockMapReader(FileStatus st

[GitHub] drill pull request #981: DRILL-5854: IllegalStateException when empty batch ...

2017-10-09 Thread ppadma
GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/981 DRILL-5854: IllegalStateException when empty batch with valid schema … …is received Problem is that merge receiver is reading from the wrong sender when first batch is empty from one of t

Re: Implicit columns and maps

2017-10-09 Thread Paul Rogers
As you point out, naming is a separate issue. I believe we inherited names from some other system. But, it is an issue that we use “good” names for implicit columns. If we add more names “createDate”, “modifcationDate”, “owner”, or whatever), we end up breaking someone’s queries that has columns

Re: Implicit columns and maps

2017-10-09 Thread Boaz Ben-Zvi
How about changing all those “implicit” columns to have some “unconventional” prefix, like an underscore (or two _ _ ); e.g. _suffix, _dir0, etc . With such a change we may need to handle the transition of existing users’ code ; e.g., maybe change the priority (mentioned below) so that an e

[jira] [Resolved] (DRILL-5840) A query that includes sort completes, and then loses Drill connection. Drill becomes unresponsive, and cannot restart because it cannot communicate with Zookeeper

2017-10-09 Thread Robert Hou (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-5840. --- Resolution: Not A Problem > A query that includes sort completes, and then loses Drill connection. Dri

Implicit columns and maps

2017-10-09 Thread Paul Rogers
Hi All, Drill provides a set of “implicit” columns to describe files: filename, suffix, fan and filepath. Drill also provides an open-ended set of partition columns: dir0, dir1, dir2, etc. Not all readers support the above: some do and some don’t. Drill semantics seem to treat these as semi-re

Re: [DISCUSS] Drill 1.12.0 release

2017-10-09 Thread Paul Rogers
Hi Arina, In addition to my own PRs, there are several in the “active” queue that we could get in if we can just push them over the line and clear the queue. The owners of the PRs should check if we are waiting on them to take action. 977 DRILL-5849: Add freemarker lib to dependencyManageme

[GitHub] drill issue #949: DRILL-5795: Parquet Filter push down at rowgroup level

2017-10-09 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/949 This change causes one of our functional tests to fail. We will have to track down the issue and either update the test, or post the problem here. ---

Re: [DISCUSS] Drill 1.12.0 release

2017-10-09 Thread Paul Rogers
Hi Arina, I’d like to include the following that are needed to finish up the “managed” sort and spill-to-disk for hash agg: #928: DRILL-5716: Queue-driven memory allocation #958, DRILL-5808: Reduce memory allocator strictness for "managed" operators #960, DRILL-5815: Option to set query memory

Re: [DISCUSS] Drill 1.12.0 release

2017-10-09 Thread Charles Givre
Hi Arina, I’d like to include Drill-5834, Adding network functions. https://github.com/apache/drill/pull/971 Hopefully I didn’t violate too many coding standards this time ;-) —C > On Oct 9, 2017, at 9:09 AM, Arina Yelchiyeva > wrote: > > I want to i

[GitHub] drill issue #973: DRILL-5775: Select * query on a maprdb binary table fails

2017-10-09 Thread vdiravka
Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/973 @paul-rogers That changes connected to MapR-DB JSON tables, but this PR connected to MapR-DB binary tables. And looks like the functionality of these PRs are not crossed. The branch is rebas

Re: [DISCUSS] Drill 1.12.0 release

2017-10-09 Thread Arina Yelchiyeva
I want to include DRILL-5337 (OpenTSDB plugin), I'll try to finish code review during this week. Kind regards Arina On Mon, Oct 9, 2017 at 4:08 PM, Arina Ielchiieva wrote: > Hi Drillers, > > It's been several months since the last release and it is time to do the > next one. I am volunteering t

[DISCUSS] Drill 1.12.0 release

2017-10-09 Thread Arina Ielchiieva
Hi Drillers, It's been several months since the last release and it is time to do the next one. I am volunteering to be the release manager. If there are any issues on which work is in progress, that you feel we *must* include in the release, please post in reply to this thread. Based on your inp

[GitHub] drill issue #892: DRILL-5645: negation of expression causes null pointer exc...

2017-10-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/892 +1, LGTM. ---

[GitHub] drill issue #980: DRILL-5857: Fix NumberFormatException in Hive unit tests

2017-10-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/980 +1, LGTM. ---

[GitHub] drill pull request #980: DRILL-5857: Fix NumberFormatException in Hive unit ...

2017-10-09 Thread vvysotskyi
GitHub user vvysotskyi opened a pull request: https://github.com/apache/drill/pull/980 DRILL-5857: Fix NumberFormatException in Hive unit tests There is no unit test since with or without this change tests are passes and query plan does not change. The exception that has b

[jira] [Created] (DRILL-5857) Fix NumberFormatException in Hive unit tests

2017-10-09 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-5857: -- Summary: Fix NumberFormatException in Hive unit tests Key: DRILL-5857 URL: https://issues.apache.org/jira/browse/DRILL-5857 Project: Apache Drill

[GitHub] drill pull request #976: DRILL-5797: Choose parquet reader from read columns

2017-10-09 Thread dprofeta
Github user dprofeta commented on a diff in the pull request: https://github.com/apache/drill/pull/976#discussion_r143403559 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -156,18 +160,39 @@ public ScanBatch getBatch(

[GitHub] drill pull request #976: DRILL-5797: Choose parquet reader from read columns

2017-10-09 Thread dprofeta
Github user dprofeta commented on a diff in the pull request: https://github.com/apache/drill/pull/976#discussion_r143403657 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -156,18 +160,39 @@ public ScanBatch getBatch(

[GitHub] drill pull request #976: DRILL-5797: Choose parquet reader from read columns

2017-10-09 Thread dprofeta
Github user dprofeta commented on a diff in the pull request: https://github.com/apache/drill/pull/976#discussion_r143403232 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -156,18 +160,39 @@ public ScanBatch getBatch(