[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

2018-03-29 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1168 I would recommend trying to setup a connection using Spotfire or Squirrel and running a couple of metadata queries and a couple of queries on complex data. (These have traditionally been areas t

[GitHub] drill pull request #1197: DRILL-6279: UI indicates operators that spilled in...

2018-03-29 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1197 DRILL-6279: UI indicates operators that spilled in-memory data to disk 1. Detect the presence of an operator that has spilled to disk, in the Operators Overview section of a query's profile page.

[GitHub] drill issue #1166: DRILL-6016 - Fix for Error reading INT96 created by Apach...

2018-03-29 Thread rajrahul
Github user rajrahul commented on the issue: https://github.com/apache/drill/pull/1166 @vdiravka Done. Please review. ---

[GitHub] drill pull request #1170: DRILL-6223: Fixed several Drillbit failures due to...

2018-03-29 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1170#discussion_r178222960 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java --- @@ -60,13 +60,7 @@ public LimitRecordBatch(Li

[GitHub] drill pull request #1170: DRILL-6223: Fixed several Drillbit failures due to...

2018-03-29 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1170#discussion_r178225930 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java --- @@ -136,14 +138,28 @@ public void transferOut(VectorContain

[GitHub] drill pull request #1170: DRILL-6223: Fixed several Drillbit failures due to...

2018-03-29 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1170#discussion_r178225725 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java --- @@ -136,14 +138,28 @@ public void transferOut(VectorContain

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

2018-03-29 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1170 Sorry to say, I still disagree with this statement: "This pull request adds logic to detect and eliminate dangling columns". There was a prior discussion that `SELECT *` means "return all

[GitHub] drill issue #1181: DRILL-6284: Add operator metrics for batch sizing for fla...

2018-03-29 Thread ppadma
Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1181 @paul-rogers I added metrics for merge join also. I refactored AbstractRecordBatchMemoryManager to handle batches from multiple streams. Please review when you get a chance. ---

[jira] [Created] (DRILL-6302) NPE in Drillbit.java in close method

2018-03-29 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6302: - Summary: NPE in Drillbit.java in close method Key: DRILL-6302 URL: https://issues.apache.org/jira/browse/DRILL-6302 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

2018-03-29 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1196 DRILL-6286: Fixed incorrect reference to shutdown in drillbit.log @vrozov , @ilooner Please review You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 @parthchandra and @vrozov can you please let me know whether you are ok with the changes. Thanks! ---

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1170 @parthchandra and @paul-rogers, I have added a comment within the Jira [DRILL-6223](https://issues.apache.org/jira/browse/DRILL-6223); please let me know what you think. Thanks! ---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1168 I successfully ran the test-suite and some advanced tests which loaded the jdbc artifacts. Is this enough to validate the fix (and future exclusions to keep the jar size in-check)? if not, what oth

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 I have updated this pull request with the following changes: - Excluded the implicit column optimizations from this pull request (will be included as part of another Drill Jira) - Tuned a th

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

2018-03-29 Thread dvjyothsna
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1195 DRILL-6273: Removed dependency licensed under Category X @vrozov Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/dril

[jira] [Created] (DRILL-6301) Parquet Performance Analysis

2018-03-29 Thread salim achouche (JIRA)
salim achouche created DRILL-6301: - Summary: Parquet Performance Analysis Key: DRILL-6301 URL: https://issues.apache.org/jira/browse/DRILL-6301 Project: Apache Drill Issue Type: Task

[GitHub] drill issue #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsException ...

2018-03-29 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1144 To be honest, I don't know. There are too many paths available to write to direct memory, some which were developed over time and so not all vector code may be using them. Ideally, every bit

[GitHub] drill issue #1194: DRILL-6300: Refresh protobuf C++ source files

2018-03-29 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1194 +1 ---

[GitHub] drill issue #1194: DRILL-6300: Refresh protobuf C++ source files

2018-03-29 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1194 @parthchandra could you please review? ---

[GitHub] drill pull request #1194: DRILL-6300: Refresh protobuf C++ source files

2018-03-29 Thread vvysotskyi
GitHub user vvysotskyi opened a pull request: https://github.com/apache/drill/pull/1194 DRILL-6300: Refresh protobuf C++ source files You can merge this pull request into a Git repository by running: $ git pull https://github.com/vvysotskyi/drill DRILL-6300 Alternatively you

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

2018-03-29 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178072549 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -27,6 +27,7 @@ import java.math.BigDec

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

2018-03-29 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178070635 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -780,17 +783,42 @@ public void testImpalaP

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

2018-03-29 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178071020 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -35,6 +36,7 @@ import java.util.Map;

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is finish...

2018-03-29 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1105 +1 ---

[GitHub] drill pull request #1193: can drill support minio s3 storage

2018-03-29 Thread rongfengliang
GitHub user rongfengliang opened a pull request: https://github.com/apache/drill/pull/1193 can drill support minio s3 storage can drill support minio s3 storage i can't find any config property for s3 endpoint in documents You can merge this pull request into a Git repository by

[GitHub] drill issue #1166: DRILL-6016 - Fix for Error reading INT96 created by Apach...

2018-03-29 Thread rajrahul
Github user rajrahul commented on the issue: https://github.com/apache/drill/pull/1166 @vdiravka I have made similar changes for testSparkParquetBinaryAsTimeStamp_DictChange, testHiveParquetTimestampAsInt96_basic and testImpalaParquetBinaryAsTimeStamp_DictChange. All tests are passin

[jira] [Created] (DRILL-6300) Refresh protobuf C++ source files

2018-03-29 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-6300: -- Summary: Refresh protobuf C++ source files Key: DRILL-6300 URL: https://issues.apache.org/jira/browse/DRILL-6300 Project: Apache Drill Issue Type

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

2018-03-29 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178009588 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -797,6 +797,24 @@ public void testImpalaPa

[GitHub] drill issue #1192: DRILL-6299: Fixed a filter pushed down issue when a colum...

2018-03-29 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1192 +1 ---