Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1234
@parthchandra Please review
---
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/1234
DRILL-5927: Fixed memory leak in TestBsonRecordReader, and sped up thâ¦
â¦e test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/drill
Github user bbevens commented on the issue:
https://github.com/apache/drill/pull/1233
Looks good! Thank you!
---
Created INFRA request: https://issues.apache.org/jira/browse/INFRA-16411
On Wed, Apr 18, 2018 at 10:48 AM, Parth Chandra wrote:
> Great.
> Just as an additional clarification, once gitbox is enabled, we will not
> need to have a remote set up to point to Apache hosted repository (you can
> still
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1233
Updated with links to previous releases
Provides a link for visitors to see current and previous versions of Drill
You can merge this pull request into a Git repository by running:
$ git pull h
Github user Ben-Zvi commented on the issue:
https://github.com/apache/drill/pull/1227
Need to be "DRILL" in capital letters ...
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183181073
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -560,6 +554,40 @@ public void close() {
su
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1227
@Ben-Zvi my bad. I updated the title. but, it has not updated the JIRA.
trying to figure this out.
---
Github user Ben-Zvi commented on the issue:
https://github.com/apache/drill/pull/1227
Need to update the subject line of this PR: the '-' is missing between
DRILL and 6236 (should be DRILL**-**6236) ; because of this missing '-' the PR
is not listed in the Jira
---
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183105769
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/Unnest.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apac
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183105915
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183105882
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183106563
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183171726
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -560,6 +554,40 @@ public void close() {
su
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183169484
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -560,6 +554,40 @@ public void close() {
su
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1227
@sohami thanks for the review. updated with review comments addressed.
please take a look.
---
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183145171
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -147,7 +150,19 @@
NUM_BUCKETS,
NU
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183145138
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -157,14 +172,20 @@ public int metricId() {
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183107099
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183110851
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183106122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183107693
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182873443
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183128175
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182873668
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183114381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182640359
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/unnest/TestingLateralJoinBatch.java
---
@@ -0,0 +1,34 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628778
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apach
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apach
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183116678
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182639747
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockLateralJoinPOP.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache S
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183120789
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apach
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628991
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apach
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r183117233
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
---
@@ -0,0 +1,451 @@
+/*
+ * Licensed to th
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1223#discussion_r182628559
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apach
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1229
Fixed it. I missed these because I detected the original issues when
attempting to create javadocs for `java-exec` , `jdbc` and `jdbc-all` packages
only. A search-and-replace in the entire Drill repo
My 2 cents:
License headers are mandatory only for the Apache release, so it is
never too late to add the license header if it is missing before a
release goes out.
I'd suggest to start leveraging Travis and Jenkins more for routine
tasks such as license header check and unit testing. Both C
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1229
I think we should. Let me walk through the entire project to be doubly
sure. I'll correct them accordingly and resubmit a squashed commit..
Thanks for catching this, @vdiravka !
---
First, you're posting on the wrong mailing list. This should be posted in the
user mailing list, because this is meant for discussion of development features
about Drill. As a result, I'll cc to the dev list (so that you don't miss the
reply), but you should carry on the conversation in the User
I also recommend to use the latest Drill, but in case you need an old
release, it is always available from the Apache release archive
http://archive.apache.org/dist/drill/drill-1.11.0/
Thank you,
Vlad
On 4/19/18 11:46, Chun Chang wrote:
Recommend you use 1.13.0. If for some reason you have t
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183112258
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -147,7 +150,19 @@
NUM_BUCKETS,
NU
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1220#discussion_r183108744
--- Diff: docs/dev/Testing.md ---
@@ -0,0 +1,72 @@
+# Testing
+
+Drill makes extensive use of [JUnit](http://junit.org/junit4/) and other
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1227
@Ben-Zvi Thanks a lot for the review. updated PR with review comments taken
care of. Please take a look.
Regarding spill files, here are my thoughts.
For build side, I am using aggregate
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/1227#discussion_r183108078
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -300,13 +322,14 @@ public void setupHashTable() thr
Timothy Farkas created DRILL-6346:
-
Summary: Create an Official Drill Docker Container
Key: DRILL-6346
URL: https://issues.apache.org/jira/browse/DRILL-6346
Project: Apache Drill
Issue Type:
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1216#discussion_r183097212
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/logical/TestTransitiveClosure.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1230#discussion_r183097515
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java
---
@@ -116,8 +115,7 @@ public void testTrigoMathFunc() th
Hi Team,
I have data with the encoded values "MTExNDUwMjM3OA==" , i wanted to decode
it.
Have tried convert_from and cast to varchar, nothing is working out.
Can you please help on the same.
It is very urgent your response is appreciated.
Regards,
Lavanya.
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183091956
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -634,10 +634,14 @@ public void testFilterPushDownOverUnionAll() throws
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183087404
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -238,26 +238,27 @@ protected DrillRel c
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183091126
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
@@ -178,6 +178,12 @@ public RuleSet getRules(OptimizerRulesCo
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1232
@arina-ielchiieva, @parthchandra could you please take a look at this?
---
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/1232
DRILL-6094: Decimal data type enhancements
For details please see [design
document](https://docs.google.com/document/d/1kfWUZ_OsEmLOJu_tKZO0-ZUJwc52drrm15fyif7BmzQ/edit?usp=sharing)
You can merg
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1225
@arina-ielchiieva I don't see why using [maven
embedder](http://maven.apache.org/ref/3.5.2/maven-embedder) is a less
preferable option. Using maven it is possible to create source jars using
standard
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1213
LGTM
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1231
@parthchandra since you reviewed original PR about filter push down for
complex parquet fields, could you please also review the follow up fix?
---
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/1231
DRILL-6342: Fix schema path unIndexed method to return correct value
Details in [DRILL-6342](https://issues.apache.org/jira/browse/DRILL-6342).
You can merge this pull request into a Git re
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1225
@vrozov addressed code review comments.
Regarding embedded maven, I have considered this option but using native
Java to generate jars is more convenient. First of all, for the tests we n
GitHub user vladimirtkach opened a pull request:
https://github.com/apache/drill/pull/1230
DRILL-6345: DRILL Query fails on Function LOG10
- added log10 function implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladi
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1226
@amansinha100 / @vvysotskyi could you please review?
---
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/1229
@kkhatua These quotation marks are in `drill-java-exec package`.
There are some more italics quotation marks in the project. They are in
`package-info.java`, `TestScripts.java`, `USAGE.m
Volodymyr Tkach created DRILL-6345:
--
Summary: DRILL Query fails on Function LOG10
Key: DRILL-6345
URL: https://issues.apache.org/jira/browse/DRILL-6345
Project: Apache Drill
Issue Type: Bug
62 matches
Mail list logo
