[GitHub] kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

kkhatua commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401522121 @sachouche The change looks simple, but I might be missing the bigger picture. For e.g., `ColumnPrecisionInfo.precision` is

Re: Actual vectorization execution

Yes, Panama is a OpenJDK project ,Intel is the prime contributor. Some team of our company has tried this feature . I have a plan to try this feature to Drill. As @aman points out, it really will take some work to validate its stable and the newer version JDK. Gandiva brings a great idea to utiliz

[GitHub] HanumathRao commented on issue #1347: DRILL-6545: Projection Push down into Lateral Join operator.

HanumathRao commented on issue #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#issuecomment-401513962 @amansinha100 Thank you for the review. This is an auto

[GitHub] sachouche commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement

sachouche commented on issue #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355#issuecomment-401513955 @bitblender, can you please review this PR? Thanks!

[GitHub] sachouche opened a new pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement

sachouche opened a new pull request #1355: DRILL-6560: Enhanced the batch statistics logging enablement URL: https://github.com/apache/drill/pull/1355 This PR is reserved for internal Drill testing. It provides more logging control when testing the batch sizing functionality. At this time,

[GitHub] sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

sachouche commented on issue #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354#issuecomment-401513254 @kkhatua, can you please review this fix? Thanks! T

[GitHub] sachouche opened a new pull request #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader

sachouche opened a new pull request #1354: DRILL-6570: Fixed IndexOutofBoundException in Parquet Reader URL: https://github.com/apache/drill/pull/1354 Reserving same size intermediary buffers to handle the case of false-positive; that is, a column is first thought to be fixed length (after

[jira] [Created] (DRILL-6570) IndexOutOfBoundsException when using Flat Parquet Reader

salim achouche created DRILL-6570: - Summary: IndexOutOfBoundsException when using Flat Parquet Reader Key: DRILL-6570 URL: https://issues.apache.org/jira/browse/DRILL-6570 Project: Apache Drill

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199308452 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199308790 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199307744 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@ "storag

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199310178 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,69

[GitHub] vrozov commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

vrozov commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401510580 @ilooner I'll rebase after review. Travis CI failure is not related to the change, it failed due to the build exceeding Travi

[GitHub] ilooner commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

ilooner commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401509765 @priteshm will take a look monday. @vrozov please fix conflict and travis failures. -

[GitHub] Agirish edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish edited a comment on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401508476 @arina-ielchiieva , on second thoughts, i think having a separate profile is better. Created a new profile called 'docker'. L

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401508476 @arina-ielchiieva , on second thoughts, i think having a seperate profile is better. Created a new profile called 'docker'. Step

[jira] [Created] (DRILL-6569) Jenkins Regression: TPCDS query 19 fails with INTERNAL_ERROR ERROR: Can not read value at 2 in block 0 in file maprfs:///drill/testdata/tpcds_sf100/parquet/store_sales/1_

Robert Hou created DRILL-6569: - Summary: Jenkins Regression: TPCDS query 19 fails with INTERNAL_ERROR ERROR: Can not read value at 2 in block 0 in file maprfs:///drill/testdata/tpcds_sf100/parquet/store_sales/1_13_1.parquet Key: DRIL

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199306981 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,69 +

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199218902 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40 @@

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199305835 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -17,22 +17

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199305514 ## File path: contrib/storage-kafka/src/main/resources/bootstrap-storage-plugins.json ## @@ -2,8 +2,8 @@ "storage"

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199307586 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0 +

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199306162 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40 @@

[jira] [Created] (DRILL-6568) Jenkins Regression: TPCDS query 68 fails with IllegalStateException: Unexpected EMIT outcome received in buildSchema phase

Robert Hou created DRILL-6568: - Summary: Jenkins Regression: TPCDS query 68 fails with IllegalStateException: Unexpected EMIT outcome received in buildSchema phase Key: DRILL-6568 URL: https://issues.apache.org/jira/b

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276235 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0 +1,110

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198884749 ## File path: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java ## @@ -36,11 +36,11 @@ private

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073387 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -194,25

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198892158 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -251,6 +251,9 @@ drill.exec: { proto

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198932079 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,71

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198883586 ## File path: common/src/main/java/org/apache/drill/common/exceptions/DrillIOException.java ## @@ -19,24 +19,23 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073178 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -63,17

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073307 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,71

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199075637 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,0 +1,40

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199079357 ## File path: distribution/src/deb/control/conffiles ## @@ -16,3 +16,4 @@ /etc/drill/conf/drill-override.conf /etc

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199076849 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0 +1,110

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199073271 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,71

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276413 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0 +1,110

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199093883 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -25,6 +2

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199266170 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15 +84,

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276671 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -393,7 +393,11 @@ drill.exec: { //port hu

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199276599 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,0 +1,110

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199104274 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the Apache

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198882971 ## File path: common/src/main/java/org/apache/drill/common/config/CommonConstants.java ## @@ -31,4 +31,7 @@ /**

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198931779 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ## @@ -248,6 +248,12 @@ private

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198928608 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginMap.java ## @@ -111,7 +112,7 @@

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198886347 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java ###

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199270039 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the Apache

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199077537 ## File path: logical/src/main/java/org/apache/drill/common/config/LogicalPlanPersistence.java ## @@ -37,12 +37,12

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199105919 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@ -25,6 +2

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198926537 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15 +84,

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198928698 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -121,71

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230386 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] kkhatua commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

kkhatua commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401503825 I'd be more comfortable with single plugins to avoid any possible corruption (e.g. format, etc) as debugging could be a ni

[jira] [Resolved] (DRILL-6566) Jenkins Regression: TPCDS query 66 fails with RESOURCE ERROR: One or more nodes ran out of memory while executing the query. AGGR OOM at First Phase.

[ https://issues.apache.org/jira/browse/DRILL-6566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-6566. --- Resolution: Resolved Will remove from Jenkins for now. > Jenkins Regression: TPCDS query 66 fails wi

[GitHub] priteshm commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

priteshm commented on issue #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#issuecomment-401503273 @ilooner can you also take a look at it? This is an automa

[GitHub] ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401498074 @Ben-Zvi Thank you Boaz for the thorough review and giving me a +1 finally. ---

[jira] [Created] (DRILL-6567) Jenkins Regression: TPCDS query 93 fails with INTERNAL_ERROR ERROR: java.lang.reflect.UndeclaredThrowableException.

Robert Hou created DRILL-6567: - Summary: Jenkins Regression: TPCDS query 93 fails with INTERNAL_ERROR ERROR: java.lang.reflect.UndeclaredThrowableException. Key: DRILL-6567 URL: https://issues.apache.org/jira/browse/D

[jira] [Created] (DRILL-6566) Jenkins Regression: TPCDS query 66 fails with RESOURCE ERROR: One or more nodes ran out of memory while executing the query. AGGR OOM at First Phase.

Robert Hou created DRILL-6566: - Summary: Jenkins Regression: TPCDS query 66 fails with RESOURCE ERROR: One or more nodes ran out of memory while executing the query. AGGR OOM at First Phase. Key: DRILL-6566 URL: htt

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199289952 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ##

[GitHub] priteshm commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

priteshm commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401478271 I do see that a similar approach is followed for other operators for batch sizing. I do agree with @ilooner that it would

[GitHub] priteshm commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin

priteshm commented on issue #1272: DRILL-5977: Filter Pushdown in Drill-Kafka plugin URL: https://github.com/apache/drill/pull/1272#issuecomment-401474974 @akumarb2010 is this ready to be committed? This is an automated mess

[jira] [Created] (DRILL-6565) cume_dist does not return enough rows

Robert Hou created DRILL-6565: - Summary: cume_dist does not return enough rows Key: DRILL-6565 URL: https://issues.apache.org/jira/browse/DRILL-6565 Project: Apache Drill Issue Type: Bug

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199274012 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ##

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199274859 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ##

[jira] [Created] (DRILL-6564) Storage Plugins Versioning

Vitalii Diravka created DRILL-6564: -- Summary: Storage Plugins Versioning Key: DRILL-6564 URL: https://issues.apache.org/jira/browse/DRILL-6564 Project: Apache Drill Issue Type: Improvement

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-401466019 I'll work on adding the instructions into both the docs dir on this repo and the write-up on Parth's repo once the PR is in. -

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199272513 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199272414 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

Re: Actual vectorization execution

Hi Weijie, As it turns out, vectorized processing in Drill is more aspirational than operational at this point in time. The code used in Drill is not actually vector-based even though the data itself is columnar. Drill generally does row-wise operations because row-wise operations fit the SQL

[GitHub] ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199264949 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199263635 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401453225 @vrozov My understanding was the following. QA has setup automatic tests of both the performance of batch sizing as well as

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-40105 If logging needs to be enabled just for QA purposes, I still don't see why it needs to be enabled per query or be dynamic an

[jira] [Created] (DRILL-6563) TPCDS query 10 has regressed

Khurram Faraaz created DRILL-6563: - Summary: TPCDS query 10 has regressed Key: DRILL-6563 URL: https://issues.apache.org/jira/browse/DRILL-6563 Project: Apache Drill Issue Type: Bug

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199251973 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software F

[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401441469 Filed DRILL-6562 to track this. Regarding one vs multiple files, my reasoning was to keep it more human readable a

[jira] [Created] (DRILL-6562) Provide option to Export All storage plugin configurations at once

Abhishek Girish created DRILL-6562: -- Summary: Provide option to Export All storage plugin configurations at once Key: DRILL-6562 URL: https://issues.apache.org/jira/browse/DRILL-6562 Project: Apache

[GitHub] KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on issue #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#issuecomment-401439843 WIP: going to exclude unneeded dependencies from dependencies added to dependencyManagement. --

[GitHub] arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

arina-ielchiieva commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401437213 Sounds fair regarding the enhancement Jira. I think keeping export button even in update mode is also good. Pleas

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199242382 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

Re: Travis CI Timed Out

The timeouts are a sporadic issue. You can click on the failed build to bring up Travis. For now, since you are a committer you will have a restart build button to the right of the console (non-committers don't get this button for some reason), this will try the build again and it will probably pas

[GitHub] vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199237071 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/lateraljoin/TestE2EUnnestAndLateral.j

[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations

Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401424556 @arina-ielchiieva, I thought about that - but it's a bit more complicated in how i'd like it to be: An "Export All" button

[GitHub] ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

ilooner commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401424230 @vrozov I discussed the logging with @sachouche. The issue is that some information needed to be logged for QA purposes on

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230469 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software F

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230386 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199230067 ## File path: distribution/pom.xml ## @@ -485,6 +485,36 @@ + +

Re: Actual vectorization execution

Hi Weijie, the Panama project is an OpenJDK initialitve, right [1] ? not Intel specific. It would be quite a bit of work to test and certify with Intel's JVM which may be still in the experimental stage. Also, you may have seen the Gandiva project for Apache Arrow which aims to improve vectorizati

[jira] [Created] (DRILL-6561) Lateral excluding the columns from output container provided by projection push into rules

Sorabh Hamirwasia created DRILL-6561: Summary: Lateral excluding the columns from output container provided by projection push into rules Key: DRILL-6561 URL: https://issues.apache.org/jira/browse/DRILL-6561

[GitHub] Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199228648 ## File path: distribution/Dockerfile ## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software F

[jira] [Created] (DRILL-6560) Allow options for controlling the batch size per operator

salim achouche created DRILL-6560: - Summary: Allow options for controlling the batch size per operator Key: DRILL-6560 URL: https://issues.apache.org/jira/browse/DRILL-6560 Project: Apache Drill

Re: DRILL-6519 Tavis CI timing out

We are just finalizing the list of tests we are going to be marked as slow. Once done, this would be an easy fix :) Kind regards, Arina On Fri, Jun 29, 2018 at 7:41 PM Charles Givre wrote: > Hi Vitalii > I saw the discussion but is there anything that I can do to prevent this > from happening?

Re: [DISCUSSION] Travis build failures

Or we can be more radical here and exclude all tests from contib module? On Fri, Jun 29, 2018 at 7:28 PM Vitalii Diravka wrote: > Agree, TestTpchExplain and TestTpchPlanning are fast enough. > TestTpchLimit0 has PlannerTest category, but it is slower than the above > tests. > Actually only TestT

Re: DRILL-6519 Tavis CI timing out

Hi Vitalii I saw the discussion but is there anything that I can do to prevent this from happening? Sent from my iPhone > On Jun 29, 2018, at 12:34, Vitalii Diravka wrote: > > Hi Charles, > > Recently there was a discussion in dev mailing list regarding this. Please > take a look. > Also I

[GitHub] vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199217282 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUt

Re: DRILL-6519 Tavis CI timing out

Hi Charles, Recently there was a discussion in dev mailing list regarding this. Please take a look. Also I have created Jira ticket [1]. [1] https://issues.apache.org/jira/browse/DRILL-6559 Kind regards Vitalii On Fri, Jun 29, 2018 at 5:43 PM Charles Givre wrote: > Hi Arina, > Could you or s

[GitHub] vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

vrozov commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199215493 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPredicatesHe

Re: [DISCUSSION] Travis build failures

Agree, TestTpchExplain and TestTpchPlanning are fast enough. TestTpchLimit0 has PlannerTest category, but it is slower than the above tests. Actually only TestTpchSingleMode and TestTpchLimit0 are candidates for excluding. I am not sure that it is enough for Travis (45 seconds on my machine). What

[GitHub] arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349#discussion_r199212137 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPr

[jira] [Created] (DRILL-6559) Travis timing out

Vitalii Diravka created DRILL-6559: -- Summary: Travis timing out Key: DRILL-6559 URL: https://issues.apache.org/jira/browse/DRILL-6559 Project: Apache Drill Issue Type: Improvement

  1   2   >