[GitHub] Ben-Zvi commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

Ben-Zvi commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351#discussion_r199986966 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryA

[GitHub] Ben-Zvi commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

Ben-Zvi commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351#discussion_r199985944 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryA

[GitHub] amansinha100 commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

amansinha100 commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402324758 Yes, each unnest will operate on single column, so the plan will have 2 LateralJoin and as long as ther

[GitHub] vrozov commented on a change in pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

vrozov commented on a change in pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#discussion_r199978278 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreade

[GitHub] vrozov commented on a change in pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

vrozov commented on a change in pull request #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#discussion_r199978503 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreade

[GitHub] HanumathRao commented on issue #1353: DRILL-6553: Fix TopN for unnest operator

HanumathRao commented on issue #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#issuecomment-402303904 @vvysotskyi Thanks for making the changes. Changes look good to me. +1. This

[GitHub] sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#issuecomment-402303054 @vrozov, updated PR with your feedback. This is

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402295742 @vrozov and @Ben-Zvi Updated the PR according to latest feedbacks. -

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-402292968 I also forgot to mention a third possible bug, which is that FileSystemConfigurations defined

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-402292010 ## Problem @paul-rogers @vdiravka I have an update. Chun was unable to reproduce the is

[GitHub] vvysotskyi edited a comment on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi edited a comment on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402289998 AFAIK, currently allowed only unnest with single column. When several unnests are used, they will

[GitHub] vvysotskyi removed a comment on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi removed a comment on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402290003 AFAIK, currently allowed only unnest with single column. When several unnests are used, they will

[GitHub] vvysotskyi opened a new pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi opened a new pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346 - Added new rule `ProjectComplexRexNodeCorrelateTransposeRule` which takes a complex expression from the `Project` below

[GitHub] vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402290003 AFAIK, currently allowed only unnest with single column. When several unnests are used, they will have th

[GitHub] vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402289998 AFAIK, currently allowed only unnest with single column. When several unnests are used, they will have th

[GitHub] vvysotskyi closed pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi closed pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] parthchandra closed pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly

parthchandra closed pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly URL: https://github.com/apache/drill/pull/1362 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402287485 @vrozov , thanks Vlad, working on it! This is an automated mess

[GitHub] vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402286366 @sachouche I guess, you mean raise, not handle. For the rest a) if you throw DrillRuntimeException, please see c) b) yes (move

[GitHub] amansinha100 commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

amansinha100 commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402282802 @vvysotskyi one question about the `$complexRexNode` ..suppose there are 2 or more such nested columns,

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402282723 @vrozov , sorry for the back & forth but I cannot read your mind because you give very few details with your suggestions.

[GitHub] vrozov commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

vrozov commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#issuecomment-402281790 `Preconditions.checkArgument` usage should be limited to check for arguments of a method, as it will throw `IllegalA

[GitHub] parthchandra commented on issue #1362: DRILL-6576: Unnest reports incoming record counts incorrectly

parthchandra commented on issue #1362: DRILL-6576: Unnest reports incoming record counts incorrectly URL: https://github.com/apache/drill/pull/1362#issuecomment-402281879 Thanks Boaz. I'll make the changes you suggested and will merge this in. --

[GitHub] vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402280613 Yes, I would prefer to check for an interrupt in setSafe() (outside of an iterator). -

[GitHub] vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402280125 I did not suggest to introduce a new class. My suggestion was to move the method for example to DrillRuntimeException. --

[GitHub] vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199933855 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLateralJoinRelBase.java ##

[GitHub] vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

vvysotskyi commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199933855 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLateralJoinRelBase.java ##

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402266591 Suggestion made by @vrozov.. though I agree, the new method doesn't do much. ---

[GitHub] sachouche edited a comment on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche edited a comment on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402262585 So you suggest that I update the setSafe() method to throw the checked exception InterruptedException. Can we find a midd

[GitHub] Ben-Zvi commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

Ben-Zvi commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402264413 Is the special file/class RuntimeUtils needed ? (I.e., instead of calling Thread.interrupted() directly). I may be a bit biased

[GitHub] ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-402263811 @arina-ielchiieva We still allow System.out and System.err

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402262585 So you suggest that I update the setSafe() method to throw the checked exception InterruptedException. Can we find a middle grou

[GitHub] sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#issuecomment-402260287 Thank you @Ben-Zvi for the review! This is an au

[GitHub] vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402258967 @sachouche No, there is no point to throw `InterrupedException` and catch it in the same method. I would prefer to check for a thre

[GitHub] HanumathRao commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator

HanumathRao commented on a change in pull request #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#discussion_r199915644 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLateralJoinRelBase.java #

[GitHub] ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351#discussion_r199913761 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryA

[GitHub] ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351#discussion_r199910775 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/util/TestQue

[GitHub] ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351#discussion_r199909294 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstant

[GitHub] ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351#discussion_r199914352 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryA

[GitHub] Ben-Zvi commented on a change in pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly

Ben-Zvi commented on a change in pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly URL: https://github.com/apache/drill/pull/1362#discussion_r199908575 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecord

[GitHub] Ben-Zvi commented on a change in pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly

Ben-Zvi commented on a change in pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly URL: https://github.com/apache/drill/pull/1362#discussion_r199905031 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecord

[GitHub] sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini…

sachouche commented on issue #1361: DRILL-6579: Added sanity checks to the Parquet reader to avoid infini… URL: https://github.com/apache/drill/pull/1361#issuecomment-402250181 @Ben-Zvi A Drill user (version 1.12) reported a Parquet issue which indicated two different problems a) Th

using Parquet file

Hi there, I need small suggestion in apache drill. I've created Table using CTAS command in drill. I've used this table to store large data from complex queries to improve the performance. However, how to refresh this table which're created in Drill to get the real time data to any

[GitHub] parthchandra opened a new pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly

parthchandra opened a new pull request #1362: DRILL-6576: Unnest reports incoming record counts incorrectly URL: https://github.com/apache/drill/pull/1362 Minor fix to correct the record count reported by unnest @sohami, @Ben-Zvi, please review --

[GitHub] vdiravka closed pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka closed pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reques

[GitHub] sachouche edited a comment on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche edited a comment on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402226927 @vrozov, please confirm if this is what you are suggesting: boolean hasNext() { try { checkInterrupted();

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402226927 @vrozov, please confirm if this is what you are suggesting: boolean hasNext() { try { checkInterrupted(); } cat

[GitHub] ppadma commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

ppadma commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402223870 @Agirish This is very useful Abhishek. Thanks for doing this. This

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402218839 @cgivre , sure. Rough ETA on the drill.apache.org/docs documentation is mid July.

[GitHub] vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402218679 @sachouche If you prefer to throw `DrillRuntimeException`, make `checkInterrupted` a static method of `DrillRuntimeException`, but

[GitHub] cgivre commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

cgivre commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402216070 Thanks @Agirish for doing this! Paul Rogers and I are almost done with an Oreilly book about Drill and

[GitHub] Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402215143 Thanks all, for the review! I'll work with @bbevens to document usage of Docker. I'll follow-up on the Docker official images

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r199868514 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-402209476 @jbimbert Please rebase your branch properly for the review. Th

[GitHub] sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader

sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in Parquet reader URL: https://github.com/apache/drill/pull/1360#issuecomment-402208750 @vrozov and @Ben-Zvi can you please review this PR? Thanks!

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r19983 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844395 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844868 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844308 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844168 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199844229 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @@ +packa

[GitHub] vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402185457 @amansinha100, could you please do the final review?

[GitHub] vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-402185262 Unit tests failures after rebase were caused by another bug. It appears when a query has a single express

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199828971 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] priteshm commented on issue #1353: DRILL-6553: Fix TopN for unnest operator

priteshm commented on issue #1353: DRILL-6553: Fix TopN for unnest operator URL: https://github.com/apache/drill/pull/1353#issuecomment-402165472 @HanumathRao can you review this? This is an automated message from the Apache G

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199800215 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199800616 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199801152 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199801644 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199798981 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199800857 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199801281 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ActionOnFile.java ## @@ -0,0 +1,68 @

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199745722 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -58,17 +58,8 @@ drill.exec: { ba

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199790967 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199789010 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199785168 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199750865 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199790185 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ## @@ -0,0

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199549959 ## File path: exec/jdbc-all/pom.xml ## @@ -636,6 +636,7 @@

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199550206 ## File path: pom.xml ## @@ -60,6 +61,7 @@ 4.11 1.3

[GitHub] KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement

KazydubB commented on a change in pull request #1337: Upgrade ZooKeeper patch version to 3.4.12 and add Apache Curator to dependencyManagement URL: https://github.com/apache/drill/pull/1337#discussion_r199748358 ## File path: pom.xml ## @@ -1552,6 +1553,11 @@

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-402114560 @ilooner I meant do we have right now check style

[GitHub] arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container

arina-ielchiieva commented on issue #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#issuecomment-402113696 +1 but @Agirish please follow up on the following items: 1. document `drill-localhost` usage; 2. document docker build

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199734742 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -58,17 +58,8 @@ drill.exec: {

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199741156 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199740648 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199735782 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199739300 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r199737092 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandlerService.java ##