[GitHub] [drill] paul-rogers edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
paul-rogers edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-515719706 This PR has no unit tests. While I am sure that this particular developer got everything 100% correct, I do wonder if future

[GitHub] [drill] paul-rogers edited a comment on issue #1830: DRILL-7333: Set container record count where missing

2019-07-27 Thread GitBox
paul-rogers edited a comment on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515725625 Several tests fail due a race condition in Drillbit shutdown: ``` [ERROR]

[GitHub] [drill] paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing

2019-07-27 Thread GitBox
paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515725625 Several tests fail due a race condition in Drillbit shutdown: ``` [ERROR]

[GitHub] [drill] paul-rogers opened a new pull request #1830: DRILL-7333: Set container record count where missing

2019-07-27 Thread GitBox
paul-rogers opened a new pull request #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830 Many operators fail to set the container record count. See DRILL-7333 for details. This commit fixes a large number of operators. Replaces

[GitHub] [drill] paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-515719706 This PR has no unit tests. While I am sure that this particular developer got everything 100% correct, I do wonder if future developers

[GitHub] [drill] paul-rogers edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
paul-rogers edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-515716369 Looks like lots of work went into adapting the old-school complex readers and writers for this new type, but the newer column

[jira] [Created] (DRILL-7333) Batch of

2019-07-27 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-7333: -- Summary: Batch of Key: DRILL-7333 URL: https://issues.apache.org/jira/browse/DRILL-7333 Project: Apache Drill Issue Type: Bug Reporter: Paul Rogers

[GitHub] [drill] paul-rogers edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
paul-rogers edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-515716535 here seems to be little documentation of the design or implementation: I find myself having to reverse engineer a design from the

[GitHub] [drill] paul-rogers commented on issue #1827: DRILL-7327: Log Regex Plugin Won't Recognize Schema

2019-07-27 Thread GitBox
paul-rogers commented on issue #1827: DRILL-7327: Log Regex Plugin Won't Recognize Schema URL: https://github.com/apache/drill/pull/1827#issuecomment-515716607 @cgivre, fixed the incorrect import. This is an automated

[GitHub] [drill] paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-515716535 here seems to be little documentation of the design or implementation: I find myself having to reverse engineer a design from the code.

[GitHub] [drill] paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-515716369 Looks like lots of work went into adapting the old-school complex readers and writers for this new type, but the newer column readers

[GitHub] [drill] paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-515716199 @KazydubB, when last this was discussed on the Drill dev mail list, there was a suggestion for the type name from Ted (can't recall the

[GitHub] [drill] KazydubB opened a new pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-27 Thread GitBox
KazydubB opened a new pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829 - Added new type `TRUEMAP` - Created value vectors for the type for single and repeated cases; - Implemented corresponding `FieldReader`s and