Thanks Paul. Filed DRILL-7351 for this.
It's worth noting that hosting a web app (such as the Drill web UI) does
not prevent CSRF attacks as a malicious web site can still attempt to call
into private/non-public websites (eg. from Javascript in the browser), it
may not get access to the reply but
Don Perial created DRILL-7351:
-
Summary: WebUI is Vulnerable to CSRF
Key: DRILL-7351
URL: https://issues.apache.org/jira/browse/DRILL-7351
Project: Apache Drill
Issue Type: Bug
Componen
Hi Don,
The one saving grace is that no one should ever host the Drill web UI on a
public-facing web site. The UI provides lots of admin operations that one would
not really want to expose openly.
A much better solution would be to wrap Drill in a custom-made web app that
controls what someon
It seems that there is no way to protect the WebUI from CSRF and the fact
that the value for the access-control-allow-origin header is '*' appears to
confound this issue as well. I have searched the documentation and also did
quite a bit of Googling but have not seen any references to this. Is this
paul-rogers edited a comment on issue #1843: DRILL-7350: Move RowSet related
classes from test folder
URL: https://github.com/apache/drill/pull/1843#issuecomment-521708575
@vvysotskyi, thanks for making this change. It will allow certain other
tasks to be much easier.
The first obse
paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes
from test folder
URL: https://github.com/apache/drill/pull/1843#issuecomment-521715916
Two general comments. First, not sure why we needed to convert compact
single-line methods (a long-time Drill standard) into
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314396758
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractSingleRowS
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314396624
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractSingleRowS
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314395723
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSet.jav
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314398737
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetWriterImpl.j
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314397062
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.java
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314398293
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringBuilde
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314400808
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/package-info.java
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314395350
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSet.jav
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314400385
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/package-info.java
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314399600
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/package-info.java
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314401892
##
File path:
exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java
paul-rogers commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314397262
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.java
paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes
from test folder
URL: https://github.com/apache/drill/pull/1843#issuecomment-521708575
@vvysotskyi, thanks for making this change. It will allow certain other
tasks to be much easier.
The first observation
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314387494
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringBuilder
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314388393
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringBuilder
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314387694
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringBuilder
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314388642
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringBuilder
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314388748
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringBuilder
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314382345
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringB
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314382220
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringB
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314378880
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringB
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314378996
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringB
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314382035
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetStringB
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314362662
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/IndirectRowSet.java
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314367564
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetReader.java
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314360423
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.java
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314365904
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetPrinter.java
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314362960
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSet.java
##
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314367486
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetReader.java
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314359926
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractSingleRowSe
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314369366
##
File path:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetBuilder.java
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314361974
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.java
vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314359422
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSet.java
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314356974
##
File path:
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
##
@
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314352894
##
File path: contrib/udfs/README.md
##
@@ -0,0 +1,56 @@
+# Drill User Defined Functions
+
+This `REA
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314356145
##
File path:
contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java
##
@@ -0
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314356394
##
File path:
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
##
@
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314354091
##
File path: contrib/udfs/README.md
##
@@ -0,0 +1,56 @@
+# Drill User Defined Functions
+
+This `REA
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314353595
##
File path: contrib/udfs/README.md
##
@@ -0,0 +1,56 @@
+# Drill User Defined Functions
+
+This `REA
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314354355
##
File path: contrib/udfs/README.md
##
@@ -0,0 +1,56 @@
+# Drill User Defined Functions
+
+This `REA
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314358047
##
File path:
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
##
@
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314355115
##
File path:
contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java
##
@@ -0
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314353528
##
File path: contrib/udfs/README.md
##
@@ -0,0 +1,56 @@
+# Drill User Defined Functions
+
+This `REA
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314356974
##
File path:
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
##
@
arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add
User-Agent UDFs to Drill
URL: https://github.com/apache/drill/pull/1840#discussion_r314354293
##
File path: contrib/udfs/README.md
##
@@ -0,0 +1,56 @@
+# Drill User Defined Functions
+
+This `REA
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314321216
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSe
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314320356
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetReader.
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314319626
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetReader.
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314324081
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSet.java
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314324678
##
File path:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetBuilder.java
##
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314323618
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/IndirectRowSe
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314319854
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetPrinter
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314321490
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractSingl
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314322007
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314323421
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314321216
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSe
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314319854
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetPrinter
vvysotskyi opened a new pull request #1843: DRILL-7350: Move RowSet related
classes from test folder
URL: https://github.com/apache/drill/pull/1843
- Moved row-set related classes from test folder into main and changed
package from `org.apache.drill.test.rowSet` to
`org.apache.drill.exec.
Volodymyr Vysotskyi created DRILL-7350:
--
Summary: Move RowSet related classes from test folder
Key: DRILL-7350
URL: https://issues.apache.org/jira/browse/DRILL-7350
Project: Apache Drill
arina-ielchiieva commented on issue #1836: DRILL-7156: Support empty Parquet
files creation
URL: https://github.com/apache/drill/pull/1836#issuecomment-521618404
Ran all tests on the test cluster, all passed. LGTM, +1
@oleg-zinovev thanks for making the changes.
Oleg Zinoviev created DRILL-7349:
Summary: ClusterTest dfs.tmp storage inconsistence with cluster
size > 1
Key: DRILL-7349
URL: https://issues.apache.org/jira/browse/DRILL-7349
Project: Apache Drill
oleg-zinovev commented on issue #1836: DRILL-7156: Support empty Parquet files
creation
URL: https://github.com/apache/drill/pull/1836#issuecomment-521581932
@arina-ielchiieva , thanks for review. Done
This is an automated me
arina-ielchiieva opened a new pull request #1842: DRILL-7339: Iceberg commit
upgrade and Metastore tests categorization
URL: https://github.com/apache/drill/pull/1842
1. Upgraded Iceberg commit to fix issue with deletes in transaction
2. Categorize Metastore tests
Jira - [DRILL-73
69 matches
Mail list logo