[GitHub] [drill] cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336798709 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatPlugin.java ##

[GitHub] [drill] paul-rogers commented on issue #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

paul-rogers commented on issue #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878#issuecomment-544293632 Another in a series of operator fixes for issues uncovered by thorough auditing of each batch of vectors.

[GitHub] [drill] cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336797742 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java ##

[GitHub] [drill] paul-rogers opened a new pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

paul-rogers opened a new pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878 Enabling the vector validator on the "new" scan operator, in cases in which overflow occurs, identified that the DrillBuf writer

[GitHub] [drill] cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336797615 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatPlugin.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

cgivre commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336797574 ## File path: contrib/format-esri/src/main/java/com/esri/core/geometry/ShapefileByteBufferCursor.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336796777 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791381 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatPlugin.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791945 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791821 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791191 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatConfig.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336796656 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336796751 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791910 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791976 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791441 ## File path:

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791770 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791541 ## File path: contrib/format-esri/README.md ## @@ -0,0 +1,190 @@ +# Format Plugin for ESRI Shape

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791219 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpFormatConfig.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791601 ## File path: contrib/format-esri/README.md ## @@ -0,0 +1,190 @@ +# Format Plugin for ESRI Shape

[GitHub] [drill] paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791151 ## File path: contrib/format-esri/src/main/java/com/esri/core/geometry/ShapefileByteBufferCursor.java

[jira] [Created] (DRILL-7414) EVF incorrectly sets buffer writer index after rollover

Paul Rogers created DRILL-7414: -- Summary: EVF incorrectly sets buffer writer index after rollover Key: DRILL-7414 URL: https://issues.apache.org/jira/browse/DRILL-7414 Project: Apache Drill

[GitHub] [drill] paul-rogers commented on issue #1877: DRILL-7413: Test and fix scan operator vectors

paul-rogers commented on issue #1877: DRILL-7413: Test and fix scan operator vectors URL: https://github.com/apache/drill/pull/1877#issuecomment-544282048 Note: This PR builds on DRILL-7403, which is not yet merged. So, the commits from DRILL-7403 appear here as well. For review, just

[GitHub] [drill] paul-rogers opened a new pull request #1877: DRILL-7413: Test and fix scan operator vectors

paul-rogers opened a new pull request #1877: DRILL-7413: Test and fix scan operator vectors URL: https://github.com/apache/drill/pull/1877 Enables vector validation tests for the ScanBatch and all EasyFormat plugins. Fixes a bug in scan batch that failed to set the record count in the

[GitHub] [drill] paul-rogers edited a comment on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration

paul-rogers edited a comment on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#issuecomment-544277734 General question: the idea of giving the user more control is a good one. I'm seeing this need in

[GitHub] [drill] paul-rogers commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration

paul-rogers commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#discussion_r336790667 ## File path: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration

paul-rogers commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#discussion_r336790447 ## File path:

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336790500 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336790484 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] paul-rogers commented on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration

paul-rogers commented on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#issuecomment-544277734 General question: the idea of giving the user more control is a good one. I'm seeing this need in multiple of

[GitHub] [drill] paul-rogers commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data

paul-rogers commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data URL: https://github.com/apache/drill/pull/1874#issuecomment-544276863 How are these files used within Drill? If they are used for unit tests, then we have to consider the module hierarchy. If the files are

[GitHub] [drill] paul-rogers commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data

paul-rogers commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data URL: https://github.com/apache/drill/pull/1874#issuecomment-544276780 In general, it is a good idea to have all the files either in the project, or via a Maven dependency. We have another set of data, the

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336789362 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336789100 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788795 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788681 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336789015 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788411 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336789351 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788585 ## File path: protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ## @@ -980,6 +988,7

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336789313 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788862 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,54 @@ +# Excel Format Plugin +This plugin

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788658 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788776 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatPlugin.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788973 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,54 @@ +# Excel Format Plugin +This plugin

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336789044 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788953 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,54 @@ +# Excel Format Plugin +This plugin

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788543 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336788363 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

paul-rogers commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r334292293 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java

[GitHub] [drill] paul-rogers commented on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

paul-rogers commented on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#issuecomment-544271579 Fixed some issues for repeated types and the bit vector.

[jira] [Created] (DRILL-7413) Scan operator does not set the container record count

Paul Rogers created DRILL-7413: -- Summary: Scan operator does not set the container record count Key: DRILL-7413 URL: https://issues.apache.org/jira/browse/DRILL-7413 Project: Apache Drill Issue

Re: Drill fails for postgress if you use a Foreign Tables

Hi Erik, Would you mind please creating a JIRA at issues.apache.org with this? THanks, -- C > On Oct 17, 2019, at 9:32 AM, Erik Anderson wrote: > > On Thu, Oct 17, 2019, at 7:02 AM, Arina Yelchiyeva wrote: >> Hi Erik, >> >> Could you please provide full

[GitHub] [drill] paul-rogers opened a new pull request #1876: DRILL-7412: Minor unit test improvements

paul-rogers opened a new pull request #1876: DRILL-7412: Minor unit test improvements URL: https://github.com/apache/drill/pull/1876 Many tests intentionally trigger errors. A debug-only log setting sent those errors to stdout. The resulting stack dumps simply cluttered the test

[jira] [Created] (DRILL-7412) Minor unit test improvements

Paul Rogers created DRILL-7412: -- Summary: Minor unit test improvements Key: DRILL-7412 URL: https://issues.apache.org/jira/browse/DRILL-7412 Project: Apache Drill Issue Type: Improvement