cgivre commented on issue #1941: DRILL-7495: Excel Reader Not Parsing Dates
Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#issuecomment-568933123
@arina-ielchiieva
I addressed all review comments and squashed commits. Thanks for the review
and Happy
cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader
Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361338358
##
File path: contrib/format-excel/src/test/resources/logback-test.xml
##
@@ -0,0
cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader
Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361338355
##
File path:
cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader
Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361338312
##
File path:
vvysotskyi opened a new pull request #1943: Changes to use release API docs
URL: https://github.com/apache/drill/pull/1943
This PR contains two commits. The first one adds a link to JavaDocs into
https://drill.apache.org/docs/ page and updates old links to 1.2.0 JDBC API.
The second
The vote passes. Thanks to everyone who has tested the release candidate
and given their comments and votes. Final tally:
3x +1 (binding): Arina, Charles, Vova
2x +1 (non-binding): Denys, Holger
No 0s or -1s.
I'll start process for pushing the release artifacts and send an
announcement once
Voting ends now. Thanks everybody who voted!
I'll post the results soon.
Kind regards,
Volodymyr Vysotskyi
On Wed, Dec 25, 2019 at 4:47 PM wrote:
> + Installed from binary tar archive
> + RC files have been replaced with stabile versions
> + JDBC connect with custom authenticator
> + Basic
vvysotskyi commented on a change in pull request #1942: Update README.md with
information on how to configure env for building site and update .gitignore to
ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r361326256
arina-ielchiieva commented on a change in pull request #1942: Update README.md
with information on how to configure env for building site and update
.gitignore to ignore files left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942#discussion_r361325725
vvysotskyi opened a new pull request #1942: Update README.md with information
on how to configure env for building site and update .gitignore to ignore files
left after checkout from developing branches
URL: https://github.com/apache/drill/pull/1942
arina-ielchiieva commented on issue #1870: DRILL-7359: Add support for DICT
type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#issuecomment-568912112
@KazydubB I see you have pushed new commit, is PR ready for review? Please
tag Paul if yes.
Also please check if
arina-ielchiieva commented on a change in pull request #1941: DRILL-7495: Excel
Reader Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361324530
##
File path:
arina-ielchiieva commented on a change in pull request #1941: DRILL-7495: Excel
Reader Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361324545
##
File path: contrib/format-excel/src/test/resources/logback-test.xml
##
arina-ielchiieva commented on a change in pull request #1941: DRILL-7495: Excel
Reader Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361324464
##
File path:
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323751
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323795
##
File path:
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323267
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/CapitalizingJdbcSchema.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323595
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323447
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323645
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361324240
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/conversion/DrillTableKey.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323585
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323411
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/DrillJdbcConvention.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323519
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361324076
##
File path:
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323570
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406:
Update Calcite to 1.21.0
URL: https://github.com/apache/drill/pull/1940#discussion_r361323935
##
File path:
arina-ielchiieva commented on issue #1937: DRILL-7230: Add README.md with
instructions for release and release scripts
URL: https://github.com/apache/drill/pull/1937#issuecomment-568910375
Please include info about Docker.
+ Installed from binary tar archive
+ RC files have been replaced with stabile versions
+ JDBC connect with custom authenticator
+ Basic queries (CSV, text manipulation, join, etc.)
+ Logged in to web UI, reviewed profiles & logs, submitted trivial queries
LGTM
+1 (non-binding)
Thx & BR
Holger
29 matches
Mail list logo
