[GitHub] [drill] paul-rogers opened a new pull request #1944: DRILL-7503: Refactor the project operator

2019-12-30 Thread GitBox
paul-rogers opened a new pull request #1944: DRILL-7503: Refactor the project operator URL: https://github.com/apache/drill/pull/1944 Breaks the big "setup" function into its own class, and separates out physical vector setup from logical projection planning. No functional change; jus

[jira] [Created] (DRILL-7503) Refactor project operator

2019-12-30 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-7503: -- Summary: Refactor project operator Key: DRILL-7503 URL: https://issues.apache.org/jira/browse/DRILL-7503 Project: Apache Drill Issue Type: Improvement

[GitHub] [drill] paul-rogers commented on issue #1929: DRILL-6832: Remove the old "unmanaged" external sort

2019-12-30 Thread GitBox
paul-rogers commented on issue #1929: DRILL-6832: Remove the old "unmanaged" external sort URL: https://github.com/apache/drill/pull/1929#issuecomment-569844669 Rebased on the latest master and reran all unit tests. This is a

[GitHub] [drill] cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column URL: https://github.com/apache/drill/pull/1941#discussion_r362130255 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatc

[GitHub] [drill] cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column URL: https://github.com/apache/drill/pull/1941#discussion_r362129794 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatc

[GitHub] [drill] paul-rogers commented on issue #1929: DRILL-6832: Remove the old "unmanaged" external sort

2019-12-30 Thread GitBox
paul-rogers commented on issue #1929: DRILL-6832: Remove the old "unmanaged" external sort URL: https://github.com/apache/drill/pull/1929#issuecomment-569836457 @ihuzenko, I should have spotted that one. Also, I should have done my own test run, but I thought, hey, it is one simple change,

Re: [ANNOUNCE] Apache Drill 1.17.0 Released

2019-12-30 Thread Aman Sinha
Congratulations on a great release ! Seems quite feature rich. Also thanks to Volodymyr for shepherding the release even during the holiday season. On Fri, Dec 27, 2019 at 2:34 AM Arina Yelchiyeva wrote: > Congrats everyone, great job! > > Kind regards, > Arina > > > On 26 Dec 2019, at 20:32, Ig

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0

2019-12-30 Thread GitBox
arina-ielchiieva commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0 URL: https://github.com/apache/drill/pull/1940#discussion_r362072204 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0

2019-12-30 Thread GitBox
vvysotskyi commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0 URL: https://github.com/apache/drill/pull/1940#discussion_r362065570 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConvertletTable.java ## @@ -

[GitHub] [drill] vvysotskyi commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0

2019-12-30 Thread GitBox
vvysotskyi commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0 URL: https://github.com/apache/drill/pull/1940#discussion_r362065570 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConvertletTable.java ## @@ -

Re: [ANNOUNCE] New Committer: Denys Ordynskiy

2019-12-30 Thread Paul Rogers
Congratulations Denys! - Paul On Monday, December 30, 2019, 4:25:49 AM PST, Arina Ielchiieva wrote: The Project Management Committee (PMC) for Apache Drill has invited Denys Ordynskiy to become a committer, and we are pleased to announce that he has accepted. Denys has been contrib

[GitHub] [drill] ihuzenko commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0

2019-12-30 Thread GitBox
ihuzenko commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0 URL: https://github.com/apache/drill/pull/1940#discussion_r362056288 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConvertletTable.java ## @@ -13

[GitHub] [drill] ihuzenko commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0

2019-12-30 Thread GitBox
ihuzenko commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0 URL: https://github.com/apache/drill/pull/1940#discussion_r362043643 ## File path: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/complex_types/TestHiveStructs.java #

[GitHub] [drill] ihuzenko commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0

2019-12-30 Thread GitBox
ihuzenko commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0 URL: https://github.com/apache/drill/pull/1940#discussion_r362041807 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java ##

Re: [ANNOUNCE] New Committer: Denys Ordynskiy

2019-12-30 Thread Denys Ordynskiy
Thank you all for the greetings! I'm glad to become a committer of Apache Drill. On Mon, Dec 30, 2019 at 4:32 PM Charles Givre wrote: > Congrats Denys! Glad to have you onboard! Well deserved! > --C > > > On Dec 30, 2019, at 7:49 AM, Vova Vysotskyi wrote: > > > > Congrats Denys, well deserved

[GitHub] [drill] KazydubB commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column

2019-12-30 Thread GitBox
KazydubB commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column URL: https://github.com/apache/drill/pull/1941#discussion_r362025701 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBa

[GitHub] [drill] KazydubB commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column

2019-12-30 Thread GitBox
KazydubB commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column URL: https://github.com/apache/drill/pull/1941#discussion_r362024925 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBa

[GitHub] [drill] asfgit closed pull request #1930: DRILL-7487: Removes the unused OUT_OF_MEMORY iterator status

2019-12-30 Thread GitBox
asfgit closed pull request #1930: DRILL-7487: Removes the unused OUT_OF_MEMORY iterator status URL: https://github.com/apache/drill/pull/1930 This is an automated message from the Apache Git Service. To respond to the messag

Re: [ANNOUNCE] New Committer: Denys Ordynskiy

2019-12-30 Thread Charles Givre
Congrats Denys! Glad to have you onboard! Well deserved! --C > On Dec 30, 2019, at 7:49 AM, Vova Vysotskyi wrote: > > Congrats Denys, well deserved! > > Kind regards, > Volodymyr Vysotskyi > > > On Mon, Dec 30, 2019 at 2:25 PM Arina Ielchiieva wrote: > >> The Project Management Committee

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348192692 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ## @@ -

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348189913 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ## @@ -

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r349978842 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0 +1,

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348152514 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0 +1,

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348190304 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ## @@ -

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r349987114 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ## @@ -

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348156696 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0 +1,

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r349987203 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5FloatDataWriter.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r349982648 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0 +1,

[GitHub] [drill] cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5

2019-12-30 Thread GitBox
cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348182284 ## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ## @@ -0,0 +1,

Re: [ANNOUNCE] New Committer: Denys Ordynskiy

2019-12-30 Thread Vova Vysotskyi
Congrats Denys, well deserved! Kind regards, Volodymyr Vysotskyi On Mon, Dec 30, 2019 at 2:25 PM Arina Ielchiieva wrote: > The Project Management Committee (PMC) for Apache Drill has invited Denys > Ordynskiy to become a committer, and we are pleased to announce that he has > accepted. > > Den

[ANNOUNCE] New Committer: Denys Ordynskiy

2019-12-30 Thread Arina Ielchiieva
The Project Management Committee (PMC) for Apache Drill has invited Denys Ordynskiy to become a committer, and we are pleased to announce that he has accepted. Denys has been contributing to Drill for more than a year. He did many contributions as a QA, he found, tested and verified important bugs

[GitHub] [drill] KazydubB commented on issue #1870: DRILL-7359: Add support for DICT type in RowSet Framework

2019-12-30 Thread GitBox
KazydubB commented on issue #1870: DRILL-7359: Add support for DICT type in RowSet Framework URL: https://github.com/apache/drill/pull/1870#issuecomment-569647510 @paul-rogers, I've updated the PR: added tests for `key` and `value` overflow for single and `DICT` array, introduced separate

[GitHub] [drill] ihuzenko commented on issue #1929: DRILL-6832: Remove the old "unmanaged" external sort

2019-12-30 Thread GitBox
ihuzenko commented on issue #1929: DRILL-6832: Remove the old "unmanaged" external sort URL: https://github.com/apache/drill/pull/1929#issuecomment-569633946 @paul-rogers , omg, sometimes I'm so blind:( That last comment from my side was a big mistake and caused StackOverFlow error in our

[jira] [Created] (DRILL-7502) Incorrect/invalid codegen for typeof() with UNION

2019-12-30 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-7502: -- Summary: Incorrect/invalid codegen for typeof() with UNION Key: DRILL-7502 URL: https://issues.apache.org/jira/browse/DRILL-7502 Project: Apache Drill Issue Type