[GitHub] [drill] paul-rogers commented on issue #2010: DRILL-7620: Fix plugin mutability issues

2020-03-10 Thread GitBox
paul-rogers commented on issue #2010: DRILL-7620: Fix plugin mutability issues URL: https://github.com/apache/drill/pull/2010#issuecomment-597381456 Rebased on latest master to resolve conflict. This is an automated message fr

[GitHub] [drill] paul-rogers commented on issue #2010: DRILL-7620: Fix plugin mutability issues

2020-03-10 Thread GitBox
paul-rogers commented on issue #2010: DRILL-7620: Fix plugin mutability issues URL: https://github.com/apache/drill/pull/2010#issuecomment-597381178 @agozhiy, here is how I read the old behavior: * The UI sends the plugin as JSON via the `createOrUpdatePlugin()` mehod. * `StorageRe

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390678433 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390677994 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePluginConfig.ja

[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390677421 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java ##

[GitHub] [drill] vvysotskyi merged pull request #2021: DRILL-7635: Mongo tests fail for profiles with the non-file default file system

2020-03-10 Thread GitBox
vvysotskyi merged pull request #2021: DRILL-7635: Mongo tests fail for profiles with the non-file default file system URL: https://github.com/apache/drill/pull/2021 This is an automated message from the Apache Git Service. T

[GitHub] [drill] dobesv commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-10 Thread GitBox
dobesv commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r390652771 ## File path: exec/java-exec/src/main/resources/rest/query/query.ftl ## @@ -82,6 +82,16 @@

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-10 Thread GitBox
arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r390649598 ## File path: exec/java-exec/src/main/resources/rest/query/query.ftl ## @@ -82,6 +

[GitHub] [drill] arina-ielchiieva commented on issue #2021: DRILL-7635: Mongo tests fail for profiles with the non-file default file system

2020-03-10 Thread GitBox
arina-ielchiieva commented on issue #2021: DRILL-7635: Mongo tests fail for profiles with the non-file default file system URL: https://github.com/apache/drill/pull/2021#issuecomment-597352332 +1, LGTM. This is an automated m

[GitHub] [drill] vvysotskyi opened a new pull request #2021: DRILL-7635: Mongo tests fail for profiles with the non-file default file system

2020-03-10 Thread GitBox
vvysotskyi opened a new pull request #2021: DRILL-7635: Mongo tests fail for profiles with the non-file default file system URL: https://github.com/apache/drill/pull/2021 # [DRILL-7635](https://issues.apache.org/jira/browse/DRILL-7635): Mongo tests fail for profiles with the non-file defau

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390583045 ## File path: contrib/storage-http/src/main/resources/drill-module.conf ## @@ -0,0 +1,27 @@ +#

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390547367 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390582732 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390585371 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390573286 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390582369 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390556073 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390572977 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390557489 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpRecordReader.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390570782 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpSubScan.java ###

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390559029 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanBatchCreator.

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390579548 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390580075 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390583400 ## File path: contrib/storage-http/src/test/java/org/apache/drill/exec/store/http/TestHttpPlugin.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390548155 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390561752 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePlugin.jav

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390580267 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390565084 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePluginConf

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390568363 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpSchemaFactory.jav

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390569328 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePlugin.jav

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390575455 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390550604 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390559726 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanSpec.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390552671 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390531796 ## File path: contrib/storage-http/README.md ## @@ -0,0 +1,218 @@ + +# Generic REST API Storag

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390533239 ## File path: contrib/storage-http/README.md ## @@ -0,0 +1,218 @@ + +# Generic REST API Storag

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390574529 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390535951 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390564687 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePluginConf

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390532236 ## File path: contrib/storage-http/README.md ## @@ -0,0 +1,218 @@ + +# Generic REST API Storag

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390546981 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpGroupScan.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390531073 ## File path: contrib/storage-http/README.md ## @@ -0,0 +1,218 @@ + +# Generic REST API Storag

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390544725 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390537966 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390565386 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePluginConf

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390564074 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePluginConf

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390541287 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390537567 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390557812 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanBatchCreator.

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390533397 ## File path: contrib/storage-http/README.md ## @@ -0,0 +1,218 @@ + +# Generic REST API Storag

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390545178 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpAPIConfig.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390582930 ## File path: contrib/storage-http/src/main/resources/bootstrap-storage-plugins.json ## @@ -0

[GitHub] [drill] paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r390531631 ## File path: contrib/storage-http/README.md ## @@ -0,0 +1,218 @@ + +# Generic REST API Storag

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-10 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-597268755 @arina-ielchiieva Thanks. Sorry I didn't have the resources to fix the Safari issue - maybe someo

[jira] [Created] (DRILL-7635) Mongo tests fail for profiles with non-file default file system

2020-03-10 Thread Vova Vysotskyi (Jira)
Vova Vysotskyi created DRILL-7635: - Summary: Mongo tests fail for profiles with non-file default file system Key: DRILL-7635 URL: https://issues.apache.org/jira/browse/DRILL-7635 Project: Apache Drill

[GitHub] [drill] asfgit closed pull request #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-10 Thread GitBox
asfgit closed pull request #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994 This is an automated message from the Apache Git Servi

[GitHub] [drill] asfgit closed pull request #2011: DRILL-7623: Link error is displayed at the log content page on Web UI

2020-03-10 Thread GitBox
asfgit closed pull request #2011: DRILL-7623: Link error is displayed at the log content page on Web UI URL: https://github.com/apache/drill/pull/2011 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [drill] asfgit closed pull request #2012: DRILL-7625: Add options for SslContextFactory

2020-03-10 Thread GitBox
asfgit closed pull request #2012: DRILL-7625: Add options for SslContextFactory URL: https://github.com/apache/drill/pull/2012 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [drill] asfgit closed pull request #2014: DRILL-7627: Update MySql version for JdbcStoragePlugin tests and cache ~/.embedmysql

2020-03-10 Thread GitBox
asfgit closed pull request #2014: DRILL-7627: Update MySql version for JdbcStoragePlugin tests and cache ~/.embedmysql URL: https://github.com/apache/drill/pull/2014 This is an automated message from the Apache Git Service.

[GitHub] [drill] asfgit closed pull request #2017: DRILL-7632: Improve user exception formatting

2020-03-10 Thread GitBox
asfgit closed pull request #2017: DRILL-7632: Improve user exception formatting URL: https://github.com/apache/drill/pull/2017 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [drill] asfgit closed pull request #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547

2020-03-10 Thread GitBox
asfgit closed pull request #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547 URL: https://github.com/apache/drill/pull/2015 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [drill] asfgit closed pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by

2020-03-10 Thread GitBox
asfgit closed pull request #2009: DRILL-7622: Compilation error when using HLL / TDigest with group by URL: https://github.com/apache/drill/pull/2009 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [drill] asfgit closed pull request #2019: DRILL-7630: Add additional types into SchemaParser for Parquet

2020-03-10 Thread GitBox
asfgit closed pull request #2019: DRILL-7630: Add additional types into SchemaParser for Parquet URL: https://github.com/apache/drill/pull/2019 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [drill] asfgit closed pull request #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-10 Thread GitBox
asfgit closed pull request #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [drill] asfgit closed pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value

2020-03-10 Thread GitBox
asfgit closed pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value URL: https://github.com/apache/drill/pull/2006 This is an automated message from the Apache Git Service. To respond

[GitHub] [drill] paul-rogers commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #2006: DRILL-7615: UNION ALL query returns the wrong result for the decimal value URL: https://github.com/apache/drill/pull/2006#discussion_r386776641 ## File path: common/src/main/java/org/apache/drill/common/types/Types.java #

[GitHub] [drill] paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF URL: https://github.com/apache/drill/pull/1962#discussion_r379859349 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF URL: https://github.com/apache/drill/pull/1962#discussion_r390520873 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVBatchReader.java ###

[GitHub] [drill] paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF URL: https://github.com/apache/drill/pull/1962#discussion_r379859411 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java ##

[GitHub] [drill] paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF URL: https://github.com/apache/drill/pull/1962#discussion_r390522026 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVRecordIterator.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF URL: https://github.com/apache/drill/pull/1962#discussion_r379859570 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVRecordIterator.java

[GitHub] [drill] paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1962: DRILL-7554: Convert LTSV Format Plugin to EVF URL: https://github.com/apache/drill/pull/1962#discussion_r374459658 ## File path: contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVRecordIterator.java

[GitHub] [drill] paul-rogers commented on issue #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-10 Thread GitBox
paul-rogers commented on issue #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-597239145 Looks good, +1. Seems to me that two things need to happen after this PR. First, is to find a way to run a stress/perform

[GitHub] [drill] paul-rogers commented on issue #1993: DRILL-7601: Shift column conversion to reader from scan framework

2020-03-10 Thread GitBox
paul-rogers commented on issue #1993: DRILL-7601: Shift column conversion to reader from scan framework URL: https://github.com/apache/drill/pull/1993#issuecomment-597236752 Rebased on latest master. This is an automated mess

[GitHub] [drill] paul-rogers commented on a change in pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework URL: https://github.com/apache/drill/pull/1993#discussion_r390500706 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroBatchReade

[GitHub] [drill] paul-rogers commented on a change in pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework

2020-03-10 Thread GitBox
paul-rogers commented on a change in pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework URL: https://github.com/apache/drill/pull/1993#discussion_r390511107 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/easy/text/compliant

[GitHub] [drill] paul-rogers opened a new pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-10 Thread GitBox
paul-rogers opened a new pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020 # [DRILL-7634](https://issues.apache.org/jira/browseDRILL-7634): Rollup of code cleanup changes ## Description Collection of code cleanup cha

[jira] [Created] (DRILL-7634) Rollup of code cleanup changes

2020-03-10 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-7634: -- Summary: Rollup of code cleanup changes Key: DRILL-7634 URL: https://issues.apache.org/jira/browse/DRILL-7634 Project: Apache Drill Issue Type: Improvement A

[GitHub] [drill] vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser

2020-03-10 Thread GitBox
vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser URL: https://github.com/apache/drill/pull/2016#discussion_r390435908 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ValueDef.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser

2020-03-10 Thread GitBox
vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser URL: https://github.com/apache/drill/pull/2016#discussion_r390433673 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ObjectListener.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser

2020-03-10 Thread GitBox
vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser URL: https://github.com/apache/drill/pull/2016#discussion_r390425236 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ValueDefFactory.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser

2020-03-10 Thread GitBox
vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser URL: https://github.com/apache/drill/pull/2016#discussion_r390434300 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ValueDef.java #

[GitHub] [drill] vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser

2020-03-10 Thread GitBox
vvysotskyi commented on a change in pull request #2016: DRILL-7631: Updates to the Json Structure Parser URL: https://github.com/apache/drill/pull/2016#discussion_r390423322 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ObjectListener.java

[GitHub] [drill] arina-ielchiieva opened a new pull request #2019: DRILL-7630: Add additional types into SchemaParser for Parquet

2020-03-10 Thread GitBox
arina-ielchiieva opened a new pull request #2019: DRILL-7630: Add additional types into SchemaParser for Parquet URL: https://github.com/apache/drill/pull/2019 # [DRILL-7630](https://issues.apache.org/jira/browse/DRILL-7630): Add additional types into SchemaParser for Parquet ## Des

[GitHub] [drill] arina-ielchiieva commented on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547

2020-03-10 Thread GitBox
arina-ielchiieva commented on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547 URL: https://github.com/apache/drill/pull/2015#issuecomment-597139833 +1, LGTM This is an automated message from the A

[GitHub] [drill] arina-ielchiieva removed a comment on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547

2020-03-10 Thread GitBox
arina-ielchiieva removed a comment on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547 URL: https://github.com/apache/drill/pull/2015#issuecomment-596991728 @vvysotskyi I think maybe we'll get rid of this test suite logic? We can make all Mongo tests extend `M

[GitHub] [drill] agozhiy commented on issue #2012: DRILL-7625: Add options for SslContextFactory

2020-03-10 Thread GitBox
agozhiy commented on issue #2012: DRILL-7625: Add options for SslContextFactory URL: https://github.com/apache/drill/pull/2012#issuecomment-597130330 Thank you, +1. This is an automated message from the Apache Git Service. To

[GitHub] [drill] agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory

2020-03-10 Thread GitBox
agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory URL: https://github.com/apache/drill/pull/2012#discussion_r390351471 ## File path: common/src/main/java/org/apache/drill/common/config/NestedConfig.java ## @@ -111,6 +112,19

[GitHub] [drill] agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory

2020-03-10 Thread GitBox
agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory URL: https://github.com/apache/drill/pull/2012#discussion_r390350047 ## File path: common/src/main/java/org/apache/drill/common/config/NestedConfig.java ## @@ -111,6 +112,19

[GitHub] [drill] agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory

2020-03-10 Thread GitBox
agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory URL: https://github.com/apache/drill/pull/2012#discussion_r390350047 ## File path: common/src/main/java/org/apache/drill/common/config/NestedConfig.java ## @@ -111,6 +112,19

[GitHub] [drill] agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory

2020-03-10 Thread GitBox
agozhiy commented on a change in pull request #2012: DRILL-7625: Add options for SslContextFactory URL: https://github.com/apache/drill/pull/2012#discussion_r390347618 ## File path: common/src/main/java/org/apache/drill/common/config/NestedConfig.java ## @@ -111,6 +111,14

[GitHub] [drill] cgivre commented on issue #2012: DRILL-7625: Add options for SslContextFactory

2020-03-10 Thread GitBox
cgivre commented on issue #2012: DRILL-7625: Add options for SslContextFactory URL: https://github.com/apache/drill/pull/2012#issuecomment-597061241 Could we make a note to include this in the web documentation for Drill once this is committed? -

[GitHub] [drill] vvysotskyi merged pull request #1986: Additional changes for Drill Metastore docs

2020-03-10 Thread GitBox
vvysotskyi merged pull request #1986: Additional changes for Drill Metastore docs URL: https://github.com/apache/drill/pull/1986 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [drill] vvysotskyi merged pull request #2013: Clean up a bit, add example for s3 storage of query profiles

2020-03-10 Thread GitBox
vvysotskyi merged pull request #2013: Clean up a bit, add example for s3 storage of query profiles URL: https://github.com/apache/drill/pull/2013 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2018: DRILL-7633: Fixes for union and repeated list accessors

2020-03-10 Thread GitBox
arina-ielchiieva commented on a change in pull request #2018: DRILL-7633: Fixes for union and repeated list accessors URL: https://github.com/apache/drill/pull/2018#discussion_r390202680 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/VariantColumnMeta

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2018: DRILL-7633: Fixes for union and repeated list accessors

2020-03-10 Thread GitBox
arina-ielchiieva commented on a change in pull request #2018: DRILL-7633: Fixes for union and repeated list accessors URL: https://github.com/apache/drill/pull/2018#discussion_r390199915 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/VariantColumnMeta

[GitHub] [drill] arina-ielchiieva commented on issue #2017: DRILL-7632: Improve user exception formatting

2020-03-10 Thread GitBox
arina-ielchiieva commented on issue #2017: DRILL-7632: Improve user exception formatting URL: https://github.com/apache/drill/pull/2017#issuecomment-596994971 +1, LGTM. This is an automated message from the Apache Git Service

[GitHub] [drill] arina-ielchiieva commented on issue #2010: DRILL-7620: Fix plugin mutability issues

2020-03-10 Thread GitBox
arina-ielchiieva commented on issue #2010: DRILL-7620: Fix plugin mutability issues URL: https://github.com/apache/drill/pull/2010#issuecomment-596994090 @paul-rogers I guess we should to address issues mentioned by Anton before moving forward... --

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-10 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-596993199 I think we should still merge this PR since in Drill we don't have list of browsers we s

[GitHub] [drill] arina-ielchiieva commented on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547

2020-03-10 Thread GitBox
arina-ielchiieva commented on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547 URL: https://github.com/apache/drill/pull/2015#issuecomment-596991728 @vvysotskyi I think maybe we'll get rid of this test suite logic? We can make all Mongo tests extend `MongoTest

  1   2   >