[GitHub] [drill] vvysotskyi commented on a change in pull request #2072: DRILL-7724: Refactor metadata controller batch

2020-05-01 Thread GitBox
vvysotskyi commented on a change in pull request #2072: URL: https://github.com/apache/drill/pull/2072#discussion_r418479001 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/metadata/MetadataControllerBatch.java ## @@ -127,113 +126,93 @@ protected

[GitHub] [drill] vvysotskyi commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message

2020-05-01 Thread GitBox
vvysotskyi commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r418484316 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing()

[GitHub] [drill] akkapur commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-05-01 Thread GitBox
akkapur commented on pull request #1888: URL: https://github.com/apache/drill/pull/1888#issuecomment-622417910 @cgivre hi Charles, I am having trouble getting the right version of protobuf to generate the files. Is this something you can help with? Currently, the build seems to be failing

[GitHub] [drill] cgivre commented on pull request #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-05-01 Thread GitBox
cgivre commented on pull request #1888: URL: https://github.com/apache/drill/pull/1888#issuecomment-622419667 @akkapur Hi there. I'd agree that the protobufs are a pain. I was having the same issue with a PR that I just submitted as well. (https://github.com/apache/drill/pull/2067).

[GitHub] [drill] laurentgo commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message

2020-05-01 Thread GitBox
laurentgo commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r418582565 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing()

[GitHub] [drill] laurentgo commented on pull request #2070: DRILL-7726: Update boost requirement to 1.54

2020-05-01 Thread GitBox
laurentgo commented on pull request #2070: URL: https://github.com/apache/drill/pull/2070#issuecomment-622441178 Yes, that was my intent before merging my change, I just don't know how many people have been looking at the C++ code recently.

[REGRESSION]: Regression in RDBMS Storage Plugin

2020-05-01 Thread Charles Givre
Hello all, It appears we have a regression in the RDBMS plugin in Drill 1.18. Please take a look at https://issues.apache.org/jira/browse/DRILL-7698 . While this specific use case may not be the best, I'm concerned that this could affect other

[GitHub] [drill] vvysotskyi commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message

2020-05-01 Thread GitBox
vvysotskyi commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r418724733 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing()

[GitHub] [drill] laurentgo commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message

2020-05-01 Thread GitBox
laurentgo commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r418728429 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing()

[GitHub] [drill] laurentgo commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message

2020-05-01 Thread GitBox
laurentgo commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r418728429 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing()

[GitHub] [drill] vvysotskyi commented on a change in pull request #2071: DRILL-7727 Fix protobuf warning message

2020-05-01 Thread GitBox
vvysotskyi commented on a change in pull request #2071: URL: https://github.com/apache/drill/pull/2071#discussion_r418734189 ## File path: contrib/native/client/CMakeLists.txt ## @@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW) cmake_policy(SET CMP0048 NEW) enable_testing()

[GitHub] [drill] paul-rogers commented on a change in pull request #2072: DRILL-7724: Refactor metadata controller batch

2020-05-01 Thread GitBox
paul-rogers commented on a change in pull request #2072: URL: https://github.com/apache/drill/pull/2072#discussion_r418754627 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/metadata/MetadataControllerBatch.java ## @@ -127,113 +126,93 @@ protecte

[jira] [Created] (DRILL-7728) Drill SPI framework

2020-05-01 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-7728: -- Summary: Drill SPI framework Key: DRILL-7728 URL: https://issues.apache.org/jira/browse/DRILL-7728 Project: Apache Drill Issue Type: Improvement Affects Vers

[GitHub] [drill] paul-rogers opened a new pull request #2074: DRILL-7728: SPI framework

2020-05-01 Thread GitBox
paul-rogers opened a new pull request #2074: URL: https://github.com/apache/drill/pull/2074 # [DRILL-7728](https://issues.apache.org/jira/browse/DRILL-7728): SPI framework ## Description We have discussed moving Drill to a "Service Provider Interface" (SPI) model similar to w