Re: [VOTE] Release Apache Drill 1.19.0 - RC0

Laurent, Thanks for doing this. RC0 is no longer eligible for the next step operation. It is a consensus that we cannot release a version with known issues (the pull request mark as `bug`). In fact, Drill's release process is not friendly, and we will put these discussion after the release. No

[GitHub] [drill] laurentgo commented on pull request #2249: Update NOTICE copyright year

laurentgo commented on pull request #2249: URL: https://github.com/apache/drill/pull/2249#issuecomment-854374057 This was mentioned in the release process document but I missed the bullet point -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [drill] laurentgo opened a new pull request #2249: Update NOTICE copyright year

laurentgo opened a new pull request #2249: URL: https://github.com/apache/drill/pull/2249 Update NOTICE copyright year to 2021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

You actually went ahead and merged those patches without waiting while I was hoping we could get some consensus first :( Can I just ask you to please respect the effort I'm putting in following what I think is the release process? If people think I'm not following the proper steps or that I'm not

[jira] [Resolved] (DRILL-7940) Kafka key with avro schema can not displayed correctly

[ https://issues.apache.org/jira/browse/DRILL-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cdmikechen resolved DRILL-7940. --- Reviewer: Vova Vysotskyi Resolution: Fixed fix https://github.com/apache/drill/pull/2242 > Kaf

[GitHub] [drill] luocooong commented on pull request #2247: DRILL-7945: Stop patching newly added Guava methods

luocooong commented on pull request #2247: URL: https://github.com/apache/drill/pull/2247#issuecomment-854286788 @vvysotskyi Thanks for the report. Can we also approve this PR for the emergency fix? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [drill] luocooong merged pull request #2248: Release tools fix

luocooong merged pull request #2248: URL: https://github.com/apache/drill/pull/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [drill] luocooong merged pull request #2243: DRILL-7937: INTERNAL_ERROR when querying Parquet File with decimals

luocooong merged pull request #2243: URL: https://github.com/apache/drill/pull/2243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [drill] luocooong merged pull request #2242: DRILL-7940: Fix Kafka key with avro schema can not displayed correctly

luocooong merged pull request #2242: URL: https://github.com/apache/drill/pull/2242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

The DRILL-7945 blocked the release. So, I'm ready to merge the DRILL-7937 and DRILL-7940 for bugfix. > 在 2021年6月4日，01:15，Laurent Goujon 写道： > > Hey guys, > > Can we please stop changing the goal post again and again? The fact that > some of those pull requests are ready to merge should not

[GitHub] [drill] laurentgo opened a new pull request #2248: Release tools fix

laurentgo opened a new pull request #2248: URL: https://github.com/apache/drill/pull/2248 # Release tools fix ## Description Small fixes for the release tool: - fix path used to invoke the checksum verification script - Allow gpg command to be configurable and default to

[GitHub] [drill] laurentgo opened a new pull request #2247: DRILL-7945: Stop patching newly added Guava methods

laurentgo opened a new pull request #2247: URL: https://github.com/apache/drill/pull/2247 # [DRILL-7945](https://issues.apache.org/jira/browse/DRILL-7945): Stop patching newly added Guava methods ## Description In order to support Apache Iceberg, GuavaPatcher adds several meth

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

Yes, this looks like a regression. I can try and help fix it. On Thu, Jun 3, 2021 at 12:15 PM wrote: > Hi all, > > Thanks, Laurent for creating this release candidate! > > I have started verifying the release, but for now my vote is -1 (binding) > because of the following issue: DRILL-7945 < > h

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

Hi all, Thanks, Laurent for creating this release candidate! I have started verifying the release, but for now my vote is -1 (binding) because of the following issue: DRILL-7945 It is definitely a regression and it might break some important D

[jira] [Created] (DRILL-7945) Unable to patch Guava classes

Vova Vysotskyi created DRILL-7945: - Summary: Unable to patch Guava classes Key: DRILL-7945 URL: https://issues.apache.org/jira/browse/DRILL-7945 Project: Apache Drill Issue Type: Bug Affe

[GitHub] [drill] laurentgo commented on a change in pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

laurentgo commented on a change in pull request #2244: URL: https://github.com/apache/drill/pull/2244#discussion_r644991563 ## File path: common/pom.xml ## @@ -37,11 +37,21 @@ drill-protocol ${project.version} + Review comment: I'm not sure why t

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

Hey guys, Can we please stop changing the goal post again and again? The fact that some of those pull requests are ready to merge should not be the sole consideration when to do a next release candidate. I've been asking several times on this mailing list about what we want to include or not, and

[jira] [Created] (DRILL-7944) Update Drill Guava version

Vitalii Diravka created DRILL-7944: -- Summary: Update Drill Guava version Key: DRILL-7944 URL: https://issues.apache.org/jira/browse/DRILL-7944 Project: Apache Drill Issue Type: Sub-task

[GitHub] [drill] vvysotskyi commented on a change in pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

vvysotskyi commented on a change in pull request #2244: URL: https://github.com/apache/drill/pull/2244#discussion_r644958707 ## File path: common/pom.xml ## @@ -37,11 +37,21 @@ drill-protocol ${project.version} + + org.junit.jupiter + junit-jup

[GitHub] [drill] martin-g commented on a change in pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

martin-g commented on a change in pull request #2244: URL: https://github.com/apache/drill/pull/2244#discussion_r644947522 ## File path: common/pom.xml ## @@ -37,11 +37,21 @@ drill-protocol ${project.version} + + org.junit.jupiter + junit-jupit

[GitHub] [drill] vvysotskyi commented on a change in pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

vvysotskyi commented on a change in pull request #2244: URL: https://github.com/apache/drill/pull/2244#discussion_r644929089 ## File path: common/pom.xml ## @@ -37,11 +37,21 @@ drill-protocol ${project.version} + + org.junit.jupiter + junit-jup

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

There are like 5 minor PRs that are approved and awaiting merge. I'd vote that we include them. Specifically: DRILL-7943: Update Hamcrest DRILL-7942: Update Mockito DRILL-7941: Update junit to 5.7.2 DRILL-7937: Parquet decimal error DRILL-7940: Fix Kafka Key These are all approved and can be

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

DRILL-7940, too > 在 2021年6月3日，19:57，Charles Givre 写道： > > -1 (Binding) > > I'd agree with Nick. Drill-7937 should be included in this release. > -- C > >> On Jun 2, 2021, at 9:25 AM, Nick Stenroos-Dam wrote: >> >> Vote -1 >> >> Can we please include DRILL-7937

[GitHub] [drill] martin-g commented on pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

martin-g commented on pull request #2244: URL: https://github.com/apache/drill/pull/2244#issuecomment-853826260 @cgivre Please see https://github.com/apache/drill/pull/2244/commits/1eaf94e13f259c3acb34997cbffed0b013719683 -- This is an automated message from the Apache Git Service. To re

Re: [VOTE] Release Apache Drill 1.19.0 - RC0

-1 (Binding) I'd agree with Nick. Drill-7937 should be included in this release. -- C > On Jun 2, 2021, at 9:25 AM, Nick Stenroos-Dam wrote: > > Vote -1 > > Can we please include DRILL-7937

[GitHub] [drill] cgivre edited a comment on pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

cgivre edited a comment on pull request #2244: URL: https://github.com/apache/drill/pull/2244#issuecomment-853812030 > Do you want me to migrate few tests to JUnit 5.x APIs, as an example how to do it ? That would be very helpful! Thanks! Also, could you add a page to the develope

[GitHub] [drill] cgivre commented on pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

cgivre commented on pull request #2244: URL: https://github.com/apache/drill/pull/2244#issuecomment-853812030 > Do you want me to migrate few tests to JUnit 5.x APIs, as an example how to do it ? That would be very helpful! Thanks! -- This is an automated message from the Apache

[GitHub] [drill] martin-g commented on pull request #2244: DRILL-7941 Update JUnit from 4.13.2 to 5.7.2

martin-g commented on pull request #2244: URL: https://github.com/apache/drill/pull/2244#issuecomment-853643388 Do you want me to migrate few tests to JUnit 5.x APIs, as an example how to do it ? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [drill] martin-g commented on pull request #2246: DRILL-7943 Update Hamcrest to 2.2

martin-g commented on pull request #2246: URL: https://github.com/apache/drill/pull/2246#issuecomment-853636660 > Just curious but is there a reason why we don't just use `junit` and remove this dependency altogether? JUnit provides just `Assert.assertThat(String reason, T actual, M