[GitHub] [drill] paul-rogers opened a new pull request #2441: Adds LIMIT pushdown support in the scan framework

2022-01-28 Thread GitBox
paul-rogers opened a new pull request #2441: URL: https://github.com/apache/drill/pull/2441 # [DRILL-8115](https://issues.apache.org/jira/browse/DRILL-8115): PR Title ## Description Subset of the [DRILL-8085 PR](https://github.com/apache/drill/pull/2419) which includes only

[jira] [Created] (DRILL-8115) LIMIT pushdown into EVF

2022-01-28 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-8115: -- Summary: LIMIT pushdown into EVF Key: DRILL-8115 URL: https://issues.apache.org/jira/browse/DRILL-8115 Project: Apache Drill Issue Type: New Feature

[GitHub] [drill] luocooong commented on a change in pull request #2433: DRILL-8111: Remove lombok usage

2022-01-28 Thread GitBox
luocooong commented on a change in pull request #2433: URL: https://github.com/apache/drill/pull/2433#discussion_r794995709 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpPaginatorConfig.java ## @@ -69,6 +60,85 @@ @JsonProperty

[GitHub] [drill] paul-rogers commented on a change in pull request #2433: DRILL-8111: Remove lombok usage

2022-01-28 Thread GitBox
paul-rogers commented on a change in pull request #2433: URL: https://github.com/apache/drill/pull/2433#discussion_r794992560 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpPaginatorConfig.java ## @@ -69,6 +60,85 @@ @JsonProperty

[GitHub] [drill] luocooong merged pull request #2422: DRILL-8061: Add Impersonation Support for Phoenix

2022-01-28 Thread GitBox
luocooong merged pull request #2422: URL: https://github.com/apache/drill/pull/2422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] luocooong closed issue #2296: username as dynamic property in storage plugin

2022-01-28 Thread GitBox
luocooong closed issue #2296: URL: https://github.com/apache/drill/issues/2296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cdmikechen commented on pull request #2431: DRILL-8109: Hive storage plugin support reading parquet timestamp type with int64 logical type

2022-01-28 Thread GitBox
cdmikechen commented on pull request #2431: URL: https://github.com/apache/drill/pull/2431#issuecomment-1024731093 @cgivre Hi~ I have added a test case and update codes to newest. You can see whether the current test case is ok. -- This is an automated message from the Apache Git

Re: 1.20.0-SNAPSHOT: Sort exceeded memory limit of 104857600 bytes

2022-01-28 Thread Charles Givre
Good question. I don't know enough about Mongo config to answer that, but let me look into that. Best, -- C > On Jan 28, 2022, at 10:20 AM, Daniel Clark wrote: > > Hi Charles, > > I was under the impression that the allowDiskUse parameter is passed by the > client making the call to the

Re: 1.20.0-SNAPSHOT: Sort exceeded memory limit of 104857600 bytes

2022-01-28 Thread Daniel Clark
Hi Charles, I was under the impression that the allowDiskUse parameter is passed by the client making the call to the mongodb server. Is it possible to add this parameter to the mongo storage plugin, similar to how you added the "batchSize" parameter for the 1.20 release? On Fri, Jan 28, 2022 at

Re: 1.20.0-SNAPSHOT: Sort exceeded memory limit of 104857600 bytes

2022-01-28 Thread Charles Givre
Daniel, Thanks for flagging this. One thing I noticed in your logs is this: Sort exceeded memory limit of 104857600 bytes, but did not opt in to external sorting. Aborting operation. Pass allowDiskUse:true to opt in. What's happening here is that in the newer version of Drill, Drill is

[GitHub] [drill] vdiravka commented on a change in pull request #2422: DRILL-8061: Add Impersonation Support for Phoenix

2022-01-28 Thread GitBox
vdiravka commented on a change in pull request #2422: URL: https://github.com/apache/drill/pull/2422#discussion_r794507192 ## File path: contrib/storage-phoenix/src/test/java/org/apache/drill/exec/store/phoenix/secured/QueryServerEnvironment.java ## @@ -0,0 +1,360 @@ +/* + *

[GitHub] [drill] jnturton commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-28 Thread GitBox
jnturton commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r794488084 ## File path: distribution/pom.xml ## @@ -199,28 +199,30 @@ io.netty netty-tcnative - 2.0.1.Final + 2.0.47.Final

[GitHub] [drill] cgivre commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-28 Thread GitBox
cgivre commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r794482944 ## File path: distribution/pom.xml ## @@ -199,28 +199,30 @@ io.netty netty-tcnative - 2.0.1.Final + 2.0.47.Final

[GitHub] [drill] jnturton commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-28 Thread GitBox
jnturton commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r794335227 ## File path: pom.xml ## @@ -104,7 +104,7 @@ true apache/drill 4.8-1 -3.6.3 +3.8.4 Review comment: @vdiravka, it builds

[GitHub] [drill] jnturton commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-28 Thread GitBox
jnturton commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r794296716 ## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpScanBatchCreator.java ## @@ -161,8 +161,8 @@ public void

[GitHub] [drill] jnturton commented on pull request #2419: DRILL-8085: EVF V2 support in the "Easy" format plugin

2022-01-28 Thread GitBox
jnturton commented on pull request #2419: URL: https://github.com/apache/drill/pull/2419#issuecomment-1023990781 > @jnturton A key reason this one has "unrelated" stuff is that those fixes were needed to get a clean build. So, maybe I can make those fixes in one PR and move this one to a