[GitHub] [drill] jnturton commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
jnturton commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1241991578 I wonder whether ResolverTypePrecedence should cache computed casting costs, or whether that would be premature optimisation. -- This is an automated message from the Apache Git Service.

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1241992856 > I wonder whether ResolverTypePrecedence should cache computed casting costs, or whether that would be premature optimisation. Maybe make that a separate PR. In theory the whole gra

[GitHub] [drill] cgivre commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
cgivre commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1241993355 @jnturton Did you see my question about boolean values? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [drill] jnturton commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
jnturton commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1242020822 > This is really a MAJOR usability improvement. Will it also be able to cast `"true"` and `"false"` as boolean values? Likewise for: > > * True > > * TRUE > >

[GitHub] [drill] jnturton commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
jnturton commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1242025805 > > I wonder whether ResolverTypePrecedence should cache computed casting costs, or whether that would be premature optimisation. > > Maybe make that a separate PR. In theory the who

[GitHub] [drill] jnturton commented on pull request #2638: DRILL-8136: Overhaul implict type casting logic

2022-09-09 Thread GitBox
jnturton commented on PR #2638: URL: https://github.com/apache/drill/pull/2638#issuecomment-1242077430 ``` Apache Drill 2.0.0-SNAPSHOT "Drill must go on." apache drill> select true = 'TrUe'; EXPR$0 true 1 row selected (3.336 seconds) apache drill> select true = 'false';

[jira] [Created] (DRILL-8303) Add support for inserts into JDBC storage

2022-09-09 Thread Vova Vysotskyi (Jira)
Vova Vysotskyi created DRILL-8303: - Summary: Add support for inserts into JDBC storage Key: DRILL-8303 URL: https://issues.apache.org/jira/browse/DRILL-8303 Project: Apache Drill Issue Type:

[GitHub] [drill] vvysotskyi opened a new pull request, #2646: DRILL-8303: Add support for inserts into JDBC storage

2022-09-09 Thread GitBox
vvysotskyi opened a new pull request, #2646: URL: https://github.com/apache/drill/pull/2646 # [DRILL-8303](https://issues.apache.org/jira/browse/DRILL-8303): Add support for inserts into JDBC storage ## Description This PR contains changes required for adding support for inserts in