[GitHub] [drill] cgivre commented on a diff in pull request #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-16 Thread GitBox
cgivre commented on code in PR #2544: URL: https://github.com/apache/drill/pull/2544#discussion_r873608802 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java: ## @@ -212,61 +195,15 @@ public Response enablePlugin(@PathParam("name") String

[GitHub] [drill] jnturton merged pull request #2550: DRILL-8200: Update Hadoop libs to ≥ 3.2.3 for CVE-2022-26612 (set hadoop.version)

2022-05-16 Thread GitBox
jnturton merged PR #2550: URL: https://github.com/apache/drill/pull/2550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on a diff in pull request #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-16 Thread GitBox
jnturton commented on code in PR #2544: URL: https://github.com/apache/drill/pull/2544#discussion_r873581651 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java: ## @@ -212,61 +195,15 @@ public Response enablePlugin(@PathParam("name") String

[GitHub] [drill] cgivre commented on pull request #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-16 Thread GitBox
cgivre commented on PR #2544: URL: https://github.com/apache/drill/pull/2544#issuecomment-1127511521 @jnturton Thanks for the review comments. I changed the `getActiveUser()` function to `getQueryUser()`. Is there anything else you'd like addressed? -- This is an automated message

[GitHub] [drill] cgivre commented on a diff in pull request #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-16 Thread GitBox
cgivre commented on code in PR #2544: URL: https://github.com/apache/drill/pull/2544#discussion_r873578777 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/OAuthRequests.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [drill] cgivre commented on a diff in pull request #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-16 Thread GitBox
cgivre commented on code in PR #2544: URL: https://github.com/apache/drill/pull/2544#discussion_r873575838 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/PluginConfigWrapper.java: ## @@ -114,4 +125,75 @@ public boolean isOauth() { return

[GitHub] [drill] cgivre commented on a diff in pull request #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-16 Thread GitBox
cgivre commented on code in PR #2544: URL: https://github.com/apache/drill/pull/2544#discussion_r873575333 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java: ## @@ -212,61 +195,15 @@ public Response enablePlugin(@PathParam("name") String

[GitHub] [drill] jnturton commented on a diff in pull request #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-16 Thread GitBox
jnturton commented on code in PR #2544: URL: https://github.com/apache/drill/pull/2544#discussion_r873511567 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/OAuthRequests.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [drill] jnturton opened a new pull request, #2550: DRILL-8200: Update Hadoop libs to ≥ 3.2.3 for CVE-2022-26612

2022-05-16 Thread GitBox
jnturton opened a new pull request, #2550: URL: https://github.com/apache/drill/pull/2550 # [DRILL-8200](https://issues.apache.org/jira/browse/DRILL-8200): Update Hadoop libs to ≥ 3.2.3 for CVE-2022-26612 ## Description The previous PR for this update did everything except set

[GitHub] [drill] cgivre commented on pull request #2547: DRILL-8223: Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere

2022-05-15 Thread GitBox
cgivre commented on PR #2547: URL: https://github.com/apache/drill/pull/2547#issuecomment-1127089235 @jnturton Thank you very much for this PR. Could we merge [DRILL-8220](https://github.com/apache/drill/pull/2544) prior to merging this PR? It has some modifications to the HTTP plugin

[GitHub] [drill] luocooong merged pull request #2548: DRILL-8224: Fix TestHttpPlugin#testSlowResponse

2022-05-14 Thread GitBox
luocooong merged PR #2548: URL: https://github.com/apache/drill/pull/2548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] nielsbasjes opened a new pull request, #2549: DRILL-8225: Update LogParser and Yauaa to support User-Agent Client Hints

2022-05-13 Thread GitBox
nielsbasjes opened a new pull request, #2549: URL: https://github.com/apache/drill/pull/2549 # [DRILL-8225](https://issues.apache.org/jira/browse/DRILL-8225): Update LogParser and Yauaa to support User-Agent Client Hints ## Description In order to support logging, parsing and

[GitHub] [drill] vvysotskyi merged pull request #2538: DRILL-8214: Replace EnumerableTableScan usage with LogicalTableScan

2022-05-13 Thread GitBox
vvysotskyi merged PR #2538: URL: https://github.com/apache/drill/pull/2538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2538: DRILL-8214: Replace EnumerableTableScan usage with LogicalTableScan

2022-05-13 Thread GitBox
vvysotskyi commented on code in PR #2538: URL: https://github.com/apache/drill/pull/2538#discussion_r872651152 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectIntoScanRule.java: ## @@ -46,16 +46,28 @@ public class

[GitHub] [drill] cgivre commented on a diff in pull request #2547: DRILL-8223: Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere

2022-05-13 Thread GitBox
cgivre commented on code in PR #2547: URL: https://github.com/apache/drill/pull/2547#discussion_r872465743 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java: ## @@ -276,24 +280,24 @@ public Response updateAccessToken(@PathParam("name")

[GitHub] [drill] rakesh8081 commented on issue #2440: IllegalArgumentException: databaseName can not be null - Mongo DB

2022-05-13 Thread GitBox
rakesh8081 commented on issue #2440: URL: https://github.com/apache/drill/issues/2440#issuecomment-1125968326 I faced a exactly same issue. I am running 3 drillbits on a zk cluster and configured a mongostorage which is same for all the three drillbits. Mongodb is installed on node3

[GitHub] [drill] jnturton commented on a diff in pull request #2538: DRILL-8214: Replace EnumerableTableScan usage with LogicalTableScan

2022-05-13 Thread GitBox
jnturton commented on code in PR #2538: URL: https://github.com/apache/drill/pull/2538#discussion_r872306477 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectIntoScanRule.java: ## @@ -46,16 +46,28 @@ public class

[GitHub] [drill] vdiravka commented on a diff in pull request #2547: DRILL-8223: Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere

2022-05-13 Thread GitBox
vdiravka commented on code in PR #2547: URL: https://github.com/apache/drill/pull/2547#discussion_r872117809 ## contrib/storage-http/src/test/java/org/apache/drill/exec/store/http/TestHttpPlugin.java: ## @@ -1112,6 +1112,7 @@ public void testLimitPushdownWithFilter() throws

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2547: DRILL-8223: Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere

2022-05-13 Thread GitBox
vvysotskyi commented on code in PR #2547: URL: https://github.com/apache/drill/pull/2547#discussion_r872035895 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java: ## @@ -276,24 +280,24 @@ public Response updateAccessToken(@PathParam("name")

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2547: DRILL-8223: Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere

2022-05-13 Thread GitBox
vvysotskyi commented on code in PR #2547: URL: https://github.com/apache/drill/pull/2547#discussion_r872035428 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java: ## @@ -276,24 +280,24 @@ public Response updateAccessToken(@PathParam("name")

[GitHub] [drill] vdiravka commented on a diff in pull request #2500: DRILL-8172: Use the specified memory usage for Travis CI

2022-05-12 Thread GitBox
vdiravka commented on code in PR #2500: URL: https://github.com/apache/drill/pull/2500#discussion_r871739585 ## .travis.yml: ## @@ -45,6 +45,9 @@ cache: before_install: - export JAVA_HOME="/usr/lib/jvm/java-8-openjdk-arm64" - export PATH="$JAVA_HOME/bin:$PATH" + -

[GitHub] [drill] vdiravka opened a new pull request, #2548: DRILL-8224: Fix TestHttpPlugin#testSlowResponse

2022-05-12 Thread GitBox
vdiravka opened a new pull request, #2548: URL: https://github.com/apache/drill/pull/2548 # [DRILL-8224](https://issues.apache.org/jira/browse/DRILL-8224): Fix TestHttpPlugin#testSlowResponse ## Description Fix testSlowResponse and increase heap memory for Travis build

[GitHub] [drill] jnturton merged pull request #2535: DRILL-8211: Replace deprecated RelNode.getChildExps with Project.getProjects

2022-05-12 Thread GitBox
jnturton merged PR #2535: URL: https://github.com/apache/drill/pull/2535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on a diff in pull request #2535: DRILL-8211: Replace deprecated RelNode.getChildExps with Project.getProjects

2022-05-12 Thread GitBox
jnturton commented on code in PR #2535: URL: https://github.com/apache/drill/pull/2535#discussion_r871526487 ## exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushRowKeyJoinToScanRule.java: ## @@ -463,8 +463,9 @@ private static boolean

[GitHub] [drill] vvysotskyi merged pull request #2539: DRILL-8216: Use EVF-based JSON reader for Values operator

2022-05-12 Thread GitBox
vvysotskyi merged PR #2539: URL: https://github.com/apache/drill/pull/2539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton merged pull request #2545: DRILL-8221: Collect bug fixes from master for Drill 1.20.1

2022-05-11 Thread GitBox
jnturton merged PR #2545: URL: https://github.com/apache/drill/pull/2545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton merged pull request #2541: DRILL-8218: Add unit tests for StorageResource REST endpoints

2022-05-11 Thread GitBox
jnturton merged PR #2541: URL: https://github.com/apache/drill/pull/2541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2539: DRILL-8216: Use EVF-based JSON reader for Values operator

2022-05-11 Thread GitBox
vvysotskyi commented on code in PR #2539: URL: https://github.com/apache/drill/pull/2539#discussion_r870903809 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/SchemaUtils.java: ## @@ -234,4 +241,80 @@ static void copyProperties(TupleMetadata

[GitHub] [drill] cgivre commented on a diff in pull request #2539: DRILL-8216: Use EVF-based JSON reader for Values operator

2022-05-11 Thread GitBox
cgivre commented on code in PR #2539: URL: https://github.com/apache/drill/pull/2539#discussion_r870823130 ## exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/schema/SchemaUtils.java: ## @@ -234,4 +241,80 @@ static void copyProperties(TupleMetadata

[GitHub] [drill] jnturton opened a new pull request, #2547: DRILL-8223: Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere

2022-05-11 Thread GitBox
jnturton opened a new pull request, #2547: URL: https://github.com/apache/drill/pull/2547 # [DRILL-8223](https://issues.apache.org/jira/browse/DRILL-8223): Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere ## Description Remove the

[GitHub] [drill] jnturton merged pull request #2546: DRILL-8222: Fix wrong func impl of concat_delim, when null-value exist in middle args

2022-05-11 Thread GitBox
jnturton merged PR #2546: URL: https://github.com/apache/drill/pull/2546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on pull request #2541: DRILL-8218: Add unit tests for StorageResource REST endpoints

2022-05-11 Thread GitBox
jnturton commented on PR #2541: URL: https://github.com/apache/drill/pull/2541#issuecomment-1123691043 > I saw that the slow test is failing again. If it helps, we can put an `@Ignore` annotation on that and run it manually. Done (in another PR). -- This is an automated message

[GitHub] [drill] wojustme opened a new pull request, #2546: DRILL-8222: Fix wrong func impl of concat_delim, when null-value exist in middle args

2022-05-11 Thread GitBox
wojustme opened a new pull request, #2546: URL: https://github.com/apache/drill/pull/2546 # [DRILL-8222](https://issues.apache.org/jira/browse/DRILL-8222): Wrong function's implementation of concat_delim ## Description Current function implementation of `concat_delim` is

[GitHub] [drill] jnturton opened a new pull request, #2545: DRILL-8221: Collect bug fixes from master for Drill 1.20.1

2022-05-11 Thread GitBox
jnturton opened a new pull request, #2545: URL: https://github.com/apache/drill/pull/2545 # [DRILL-8221](https://issues.apache.org/jira/browse/DRILL-8221): Collect bug fixes from master for Drill 1.20.1 ## Description Since bugfix commits to master are not currently added to

[GitHub] [drill] cgivre opened a new pull request, #2544: DRILL-8220: Add User Translation Support for OAuth Enabled Plugins

2022-05-11 Thread GitBox
cgivre opened a new pull request, #2544: URL: https://github.com/apache/drill/pull/2544 # [DRILL-8220](https://issues.apache.org/jira/browse/DRILL-8220): Add User Translation Support for OAuth Enabled Plugins ## Description This PR adds support for individual users to provide

[GitHub] [drill] cgivre commented on pull request #2543: DRILL-5955: Revisit Union Vectors

2022-05-10 Thread GitBox
cgivre commented on PR #2543: URL: https://github.com/apache/drill/pull/2543#issuecomment-1123010372 @vdiravka This is looking good. Quick question, can we add a configuration variable to the JSON Format to enable/disable this at the plugin instance level? -- This is an automated

[GitHub] [drill] vdiravka opened a new pull request, #2543: DRILL-5955: Revisit Union Vectors

2022-05-10 Thread GitBox
vdiravka opened a new pull request, #2543: URL: https://github.com/apache/drill/pull/2543 # [DRILL-5955](https://issues.apache.org/jira/browse/DRILL-5955): Revisit Union Vectors ## Description Draft PR for support Union type for JSON2 - [x] Enabled Union/Variant vectors

[GitHub] [drill] cgivre merged pull request #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

2022-05-10 Thread GitBox
cgivre merged PR #2542: URL: https://github.com/apache/drill/pull/2542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on pull request #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

2022-05-10 Thread GitBox
cgivre commented on PR #2542: URL: https://github.com/apache/drill/pull/2542#issuecomment-1122609657 > Ok... Let's just merge then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] jnturton commented on pull request #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

2022-05-10 Thread GitBox
jnturton commented on PR #2542: URL: https://github.com/apache/drill/pull/2542#issuecomment-1122604719 > LGTM +1 > This is really a minor update, but is it worth adding a unit test? We can skip it if it is a major hassle. I think a unit test would need a new DB2 testcontainer or

[GitHub] [drill-test-framework] dependabot[bot] opened a new pull request, #2: Bump junit from 4.12 to 4.13.1 in /framework

2022-05-10 Thread GitBox
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/drill-test-framework/pull/2 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit's releases.

[GitHub] [drill-test-framework] dependabot[bot] opened a new pull request, #4: Bump httpclient from 4.5.5 to 4.5.13 in /framework

2022-05-10 Thread GitBox
dependabot[bot] opened a new pull request, #4: URL: https://github.com/apache/drill-test-framework/pull/4 Bumps httpclient from 4.5.5 to 4.5.13. [![Dependabot compatibility

[GitHub] [drill-test-framework] dependabot[bot] opened a new pull request, #3: Bump jackson-databind from 2.10.0 to 2.12.6.1 in /framework

2022-05-10 Thread GitBox
dependabot[bot] opened a new pull request, #3: URL: https://github.com/apache/drill-test-framework/pull/3 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.0 to 2.12.6.1. Commits See full diff in https://github.com/FasterXML/jackson/commits;>compare view

[GitHub] [drill-test-framework] jnturton merged pull request #1: Resurrection

2022-05-10 Thread GitBox
jnturton merged PR #1: URL: https://github.com/apache/drill-test-framework/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill-test-framework] agozhiy commented on a diff in pull request #1: Resurrection

2022-05-10 Thread GitBox
agozhiy commented on code in PR #1: URL: https://github.com/apache/drill-test-framework/pull/1#discussion_r869156157 ## framework/pom.xml: ## @@ -7,12 +7,27 @@ 1.0.0-SNAPSHOT 6.4 -1.2.17 +1.7.26 +1.2.9 2.10.0 -${env.DRILL_VERSION} -

[GitHub] [drill] jnturton opened a new pull request, #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

2022-05-10 Thread GitBox
jnturton opened a new pull request, #2542: URL: https://github.com/apache/drill/pull/2542 # [DRILL-8219](https://issues.apache.org/jira/browse/DRILL-8219): Handle null catalog names returned by DB2 in storage-jdbc ## Description DB2 is another DBMS in which clients must

[GitHub] [drill] jnturton opened a new pull request, #2541: DRILL-8218: Add unit tests for StorageResource REST endpoints

2022-05-10 Thread GitBox
jnturton opened a new pull request, #2541: URL: https://github.com/apache/drill/pull/2541 # [DRILL-8218](https://issues.apache.org/jira/browse/DRILL-8218): Add unit tests for StorageResource REST endpoints ## Description Use the RestClientFixture to test the function of API

[GitHub] [drill-test-framework] jnturton commented on a diff in pull request #1: Resurrection

2022-05-10 Thread GitBox
jnturton commented on code in PR #1: URL: https://github.com/apache/drill-test-framework/pull/1#discussion_r868861190 ## framework/pom.xml: ## @@ -7,12 +7,27 @@ 1.0.0-SNAPSHOT 6.4 -1.2.17 +1.7.26 +1.2.9 2.10.0 -${env.DRILL_VERSION} -

[GitHub] [drill] vvysotskyi merged pull request #2534: DRILL-8210: Add substring convertlet

2022-05-09 Thread GitBox
vvysotskyi merged PR #2534: URL: https://github.com/apache/drill/pull/2534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] vvysotskyi merged pull request #2537: DRILL-8213: Replace deprecated RelNode.getRows with RelNode.estimateRowCount

2022-05-09 Thread GitBox
vvysotskyi merged PR #2537: URL: https://github.com/apache/drill/pull/2537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill-test-framework] agozhiy commented on pull request #1: Resurrection

2022-05-09 Thread GitBox
agozhiy commented on PR #1: URL: https://github.com/apache/drill-test-framework/pull/1#issuecomment-1121369437 Regarding the UDF tests: the test folder doesn't contain any tests so there is no difference what category to use. I searched in git history and it was always empty, not even

[GitHub] [drill-test-framework] agozhiy commented on a diff in pull request #1: Resurrection

2022-05-09 Thread GitBox
agozhiy commented on code in PR #1: URL: https://github.com/apache/drill-test-framework/pull/1#discussion_r868211411 ## framework/pom.xml: ## @@ -7,12 +7,27 @@ 1.0.0-SNAPSHOT 6.4 -1.2.17 +1.7.26 +1.2.9 2.10.0 -${env.DRILL_VERSION} -

[GitHub] [drill] cgivre merged pull request #2536: DRILL-8212: Join queries fail with StackOverflowError

2022-05-09 Thread GitBox
cgivre merged PR #2536: URL: https://github.com/apache/drill/pull/2536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill-test-framework] jnturton commented on a diff in pull request #1: Resurrection

2022-05-09 Thread GitBox
jnturton commented on code in PR #1: URL: https://github.com/apache/drill-test-framework/pull/1#discussion_r867959310 ## framework/pom.xml: ## @@ -7,12 +7,27 @@ 1.0.0-SNAPSHOT 6.4 -1.2.17 +1.7.26 +1.2.9 2.10.0 -${env.DRILL_VERSION} -

[GitHub] [drill-test-framework] jnturton commented on pull request #1: Resurrection

2022-05-09 Thread GitBox
jnturton commented on PR #1: URL: https://github.com/apache/drill-test-framework/pull/1#issuecomment-1121029474 Thanks for this! - Are the new modes that can be seen in the JSON config files, e.g. `rm`, `cp`, `dfs_cp`, `post_rm`, the new "data preparation phases" that you mention

[GitHub] [drill] jnturton merged pull request #2540: DRILL-8215: Remove SecurityContext from PluginConfigWrapper

2022-05-09 Thread GitBox
jnturton merged PR #2540: URL: https://github.com/apache/drill/pull/2540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on a diff in pull request #2540: DRILL-8215: Remove SecurityContext from PluginConfigWrapper

2022-05-09 Thread GitBox
jnturton commented on code in PR #2540: URL: https://github.com/apache/drill/pull/2540#discussion_r867783408 ## exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/CredentialResources.java: ## @@ -125,11 +125,18 @@ public List getConfigsFor(@PathParam("group")

[GitHub] [drill] jnturton merged pull request #2532: DRILL-8208: Create builder for SqlSelect

2022-05-09 Thread GitBox
jnturton merged PR #2532: URL: https://github.com/apache/drill/pull/2532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre opened a new pull request, #2540: DRILL-8215: Remove SecurityContext from PluginConfigWrapper

2022-05-08 Thread GitBox
cgivre opened a new pull request, #2540: URL: https://github.com/apache/drill/pull/2540 # [DRILL-8215](https://issues.apache.org/jira/browse/DRILL-8215): Remove SecurityContext from PluginConfigWrapper ## Description DRILL-8155 introduced a small regression in the

[GitHub] [drill] lgtm-com[bot] commented on pull request #2539: DRILL-8216: Use EVF-based JSON reader for Values operator

2022-05-08 Thread GitBox
lgtm-com[bot] commented on PR #2539: URL: https://github.com/apache/drill/pull/2539#issuecomment-1120440515 This pull request **fixes 1 alert** when merging d2908869c5c841ac9397995d2e4a65d8ca2ca9cf into 8b498206b35708fa0ae8ef3be3cb41e9d3c13838 - [view on

[GitHub] [drill] vvysotskyi opened a new pull request, #2539: DRILL-8216: Use EVF-based JSON reader for Values operator

2022-05-08 Thread GitBox
vvysotskyi opened a new pull request, #2539: URL: https://github.com/apache/drill/pull/2539 # [DRILL-8216](https://issues.apache.org/jira/browse/DRILL-8216): Use EVF-based JSON reader for Values operator ## Description The newer Calcite version simplifies and removes casts for

[GitHub] [drill] lgtm-com[bot] commented on pull request #2538: DRILL-8214: Replace EnumerableTableScan usage with LogicalTableScan

2022-05-07 Thread GitBox
lgtm-com[bot] commented on PR #2538: URL: https://github.com/apache/drill/pull/2538#issuecomment-1120295482 This pull request **introduces 1 alert** when merging 276fd9823bc6ded1531fc9b3f0d21412e102acf0 into 8b498206b35708fa0ae8ef3be3cb41e9d3c13838 - [view on

[GitHub] [drill] vvysotskyi opened a new pull request, #2538: DRILL-8214: Replace EnumerableTableScan usage with LogicalTableScan

2022-05-07 Thread GitBox
vvysotskyi opened a new pull request, #2538: URL: https://github.com/apache/drill/pull/2538 # [DRILL-8214](https://issues.apache.org/jira/browse/DRILL-8214): Replace EnumerableTableScan usage with LogicalTableScan ## Description The newer Calcite version returns LogicalTableScan

[GitHub] [drill] vvysotskyi opened a new pull request, #2537: DRILL-8213: Replace deprecated RelNode.getRows with RelNode.estimateRowCount

2022-05-07 Thread GitBox
vvysotskyi opened a new pull request, #2537: URL: https://github.com/apache/drill/pull/2537 # [DRILL-8213](https://issues.apache.org/jira/browse/DRILL-8213): Replace deprecated RelNode.getRows with RelNode.estimateRowCount ## Description In the newer Calcite version

[GitHub] [drill] vvysotskyi opened a new pull request, #2536: DRILL-8212: Join queries fail with StackOverflowError

2022-05-07 Thread GitBox
vvysotskyi opened a new pull request, #2536: URL: https://github.com/apache/drill/pull/2536 # [DRILL-8212](https://issues.apache.org/jira/browse/DRILL-8212): Join queries fail with StackOverflowError ## Description With the newer Calcite version, some join queries fail with

[GitHub] [drill] vvysotskyi opened a new pull request, #2535: DRILL-8211: Replace deprecated RelNode.getChildExps with Project.getProjects

2022-05-07 Thread GitBox
vvysotskyi opened a new pull request, #2535: URL: https://github.com/apache/drill/pull/2535 # [DRILL-8211](https://issues.apache.org/jira/browse/DRILL-8211): Replace deprecated RelNode.getChildExps with Project.getProjects ## Description In the newer Calcite version

[GitHub] [drill] vvysotskyi opened a new pull request, #2534: DRILL-8210: Add substring convertlet

2022-05-07 Thread GitBox
vvysotskyi opened a new pull request, #2534: URL: https://github.com/apache/drill/pull/2534 # [DRILL-8210](https://issues.apache.org/jira/browse/DRILL-8210): Add substring convertlet ## Description See Jira ticket description for details ## Documentation NA ##

[GitHub] [drill] vvysotskyi opened a new pull request, #2533: DRILL-8209: Introduce rule for converting join with distinct input to semi-join

2022-05-07 Thread GitBox
vvysotskyi opened a new pull request, #2533: URL: https://github.com/apache/drill/pull/2533 # [DRILL-8209](https://issues.apache.org/jira/browse/DRILL-8209): Introduce rule for converting join with distinct input to semi-join ## Description Newer Calcite changed the order of

[GitHub] [drill] vvysotskyi opened a new pull request, #2532: DRILL-8208: Create builder for SqlSelect

2022-05-07 Thread GitBox
vvysotskyi opened a new pull request, #2532: URL: https://github.com/apache/drill/pull/2532 # [DRILL-8208](https://issues.apache.org/jira/browse/DRILL-8208): Create builder for SqlSelect ## Description The newer Calcite version adds more fields to the constructor of SqlSelect. In

[GitHub] [drill] jnturton merged pull request #2531: DRILL-8207: Fix Username Typo and password @JsonIgnore in JDBC SerDe

2022-05-06 Thread GitBox
jnturton merged PR #2531: URL: https://github.com/apache/drill/pull/2531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton opened a new pull request, #2531: DRILL-8207: Fix Username Typo and password @JsonIgnore in JDBC SerDe

2022-05-06 Thread GitBox
jnturton opened a new pull request, #2531: URL: https://github.com/apache/drill/pull/2531 # [DRILL-8207](https://issues.apache.org/jira/browse/DRILL-8207): Fix Username Typo and password @JsonIgnore in JDBC SerDe ## Description This second PR removes the @JsonIgnore annotation

[GitHub] [drill] luocooong commented on a diff in pull request #2500: DRILL-8172: Use the specified memory usage for Travis CI

2022-05-06 Thread GitBox
luocooong commented on code in PR #2500: URL: https://github.com/apache/drill/pull/2500#discussion_r866652340 ## .travis.yml: ## @@ -45,6 +45,9 @@ cache: before_install: - export JAVA_HOME="/usr/lib/jvm/java-8-openjdk-arm64" - export PATH="$JAVA_HOME/bin:$PATH" + -

[GitHub] [drill] vdiravka commented on pull request #2530: DRILL-8207: Fix typo in JDBC config

2022-05-06 Thread GitBox
vdiravka commented on PR #2530: URL: https://github.com/apache/drill/pull/2530#issuecomment-1119421766 Looks like we can be case insesitive here by adding: ``` ObjectMapper mapper = new ObjectMapper(); mapper.configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_PROPERTIES, true); ```

[GitHub] [drill] cgivre merged pull request #2530: DRILL-8207: Fix typo in JDBC config

2022-05-05 Thread GitBox
cgivre merged PR #2530: URL: https://github.com/apache/drill/pull/2530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre opened a new pull request, #2530: DRILL-8207: Fix typo in JDBC config

2022-05-05 Thread GitBox
cgivre opened a new pull request, #2530: URL: https://github.com/apache/drill/pull/2530 # [DRILL-8207](https://issues.apache.org/jira/browse/DRILL-8207): Fix Username Typo in JDBC SerDe ## Description Fixes a Serialization/Deserialization bug in the JDBC plugin ##

[GitHub] [drill-test-framework] agozhiy opened a new pull request, #1: Resurrection

2022-05-05 Thread GitBox
agozhiy opened a new pull request, #1: URL: https://github.com/apache/drill-test-framework/pull/1 - Added an option to run in a docker container - Added new data preparation phases - New concept of data preparation: changed from using bash scripts to main java application - Changed

[GitHub] [drill] vdiravka commented on a diff in pull request #2500: DRILL-8172: Use the specified memory usage for Travis CI

2022-05-05 Thread GitBox
vdiravka commented on code in PR #2500: URL: https://github.com/apache/drill/pull/2500#discussion_r865819857 ## .travis.yml: ## @@ -45,6 +45,9 @@ cache: before_install: - export JAVA_HOME="/usr/lib/jvm/java-8-openjdk-arm64" - export PATH="$JAVA_HOME/bin:$PATH" + -

[GitHub] [drill] jnturton merged pull request #2529: [MINOR UPDATE] Update AWS Java SDK to 1.12.211

2022-05-05 Thread GitBox
jnturton merged PR #2529: URL: https://github.com/apache/drill/pull/2529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre opened a new pull request, #2529: [MINOR UPDATE] Update AWS Java SDK to 1.12.211

2022-05-04 Thread GitBox
cgivre opened a new pull request, #2529: URL: https://github.com/apache/drill/pull/2529 # [MINOR UPDATE] Update AWS Java SDK to 1.12.211 ## Description Bump AWS Java SDK to latest version. ## Documentation N/A ## Testing Manually tested with S3 bucket. --

[GitHub] [drill] cgivre merged pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-03 Thread GitBox
cgivre merged PR #2526: URL: https://github.com/apache/drill/pull/2526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-03 Thread GitBox
cgivre commented on code in PR #2526: URL: https://github.com/apache/drill/pull/2526#discussion_r864097045 ## contrib/storage-http/JSON_Options.md: ## @@ -0,0 +1,125 @@ +# JSON Options and Configuration + +Drill has a collection of JSON configuration options to allow you to

[GitHub] [drill-site] jnturton merged pull request #30: Update 011-running-drill-on-docker.md

2022-05-03 Thread GitBox
jnturton merged PR #30: URL: https://github.com/apache/drill-site/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre merged pull request #2528: [MINOR UPDATE] Fix default auth mode in AuthMode.parseOrDefault

2022-05-03 Thread GitBox
cgivre merged PR #2528: URL: https://github.com/apache/drill/pull/2528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre commented on a diff in pull request #2528: [MINOR UPDATE] Fix default auth mode in AuthMode.parseOrDefault

2022-05-03 Thread GitBox
cgivre commented on code in PR #2528: URL: https://github.com/apache/drill/pull/2528#discussion_r863794931 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -105,8 +106,8 @@ public enum AuthMode { */ USER_TRANSLATION; -

[GitHub] [drill] jnturton commented on a diff in pull request #2528: [MINOR UPDATE] Fix default auth mode in AuthMode.parseOrDefault

2022-05-03 Thread GitBox
jnturton commented on code in PR #2528: URL: https://github.com/apache/drill/pull/2528#discussion_r863767452 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -105,8 +106,8 @@ public enum AuthMode { */ USER_TRANSLATION; -

[GitHub] [drill] cgivre commented on a diff in pull request #2528: [MINOR UPDATE] Fix default auth mode in AuthMode.parseOrDefault

2022-05-03 Thread GitBox
cgivre commented on code in PR #2528: URL: https://github.com/apache/drill/pull/2528#discussion_r863751804 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -105,8 +106,8 @@ public enum AuthMode { */ USER_TRANSLATION; -

[GitHub] [drill] jnturton opened a new pull request, #2528: [MINOR UPDATE] Fix default auth mode in AuthMode.parseOrDefault

2022-05-03 Thread GitBox
jnturton opened a new pull request, #2528: URL: https://github.com/apache/drill/pull/2528 ... and test the case of JDBC. ## Description A utility method for parsing the auth mode enum incorrectly defaults to `DRILL_PROCESS`, even when called by storage plugins that desire a

[GitHub] [drill-site] cgivre merged pull request #29: Update 125-http-storage-plugin.md

2022-05-03 Thread GitBox
cgivre merged PR #29: URL: https://github.com/apache/drill-site/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] luocooong merged pull request #2527: DRILL-8035: Update Janino to 3.1.7 version

2022-05-03 Thread GitBox
luocooong merged PR #2527: URL: https://github.com/apache/drill/pull/2527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
vvysotskyi commented on code in PR #2526: URL: https://github.com/apache/drill/pull/2526#discussion_r863495712 ## contrib/storage-http/JSON_Options.md: ## @@ -0,0 +1,125 @@ +# JSON Options and Configuration + +Drill has a collection of JSON configuration options to allow you

[GitHub] [drill] cgivre closed issue #2523: Due to CVE-2022-26612 (9.8 critical), upgrade Hadoop from 3.2.2 to 3.2.3

2022-05-02 Thread GitBox
cgivre closed issue #2523: Due to CVE-2022-26612 (9.8 critical), upgrade Hadoop from 3.2.2 to 3.2.3 URL: https://github.com/apache/drill/issues/2523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] cgivre commented on issue #2523: Due to CVE-2022-26612 (9.8 critical), upgrade Hadoop from 3.2.2 to 3.2.3

2022-05-02 Thread GitBox
cgivre commented on issue #2523: URL: https://github.com/apache/drill/issues/2523#issuecomment-1115556385 Fixed in DRILL-8200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] cgivre commented on a diff in pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
cgivre commented on code in PR #2526: URL: https://github.com/apache/drill/pull/2526#discussion_r863050797 ## contrib/storage-http/JSON_Options.md: ## @@ -0,0 +1,125 @@ +# JSON Options and Configuration + +Drill has a collection of JSON configuration options to allow you to

[GitHub] [drill] cgivre commented on a diff in pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
cgivre commented on code in PR #2526: URL: https://github.com/apache/drill/pull/2526#discussion_r863277815 ## contrib/storage-http/JSON_Options.md: ## @@ -0,0 +1,125 @@ +# JSON Options and Configuration + +Drill has a collection of JSON configuration options to allow you to

[GitHub] [drill] cgivre commented on a diff in pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
cgivre commented on code in PR #2526: URL: https://github.com/apache/drill/pull/2526#discussion_r863050797 ## contrib/storage-http/JSON_Options.md: ## @@ -0,0 +1,125 @@ +# JSON Options and Configuration + +Drill has a collection of JSON configuration options to allow you to

[GitHub] [drill] vvysotskyi commented on a diff in pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
vvysotskyi commented on code in PR #2526: URL: https://github.com/apache/drill/pull/2526#discussion_r863046227 ## contrib/storage-http/JSON_Options.md: ## @@ -0,0 +1,125 @@ +# JSON Options and Configuration + +Drill has a collection of JSON configuration options to allow you

[GitHub] [drill] cgivre commented on pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
cgivre commented on PR #2526: URL: https://github.com/apache/drill/pull/2526#issuecomment-1115142541 @vvysotskyi Thanks for your comments and assistance! I got this to work and the HTTP plugin now supports inline schema! -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] cgivre commented on pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
cgivre commented on PR #2526: URL: https://github.com/apache/drill/pull/2526#issuecomment-1115032166 > @vvysotskyi Thanks for the review. I added the logic to the `HttpBatchReader` to support inline schema, however in doing so, I seem to have a found a bug with the

[GitHub] [drill] jnturton commented on pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
jnturton commented on PR #2526: URL: https://github.com/apache/drill/pull/2526#issuecomment-1114915565 > For now, drill metastore supports only easy file formats and parquet, but in the future, it could handle the HTTP plugin. @vvysotskyi I think that the HTTP plugin makes use of the

[GitHub] [drill] vvysotskyi commented on pull request #2526: DRILL-8204: Allow Provided Schema for HTTP Plugin in JSON Mode

2022-05-02 Thread GitBox
vvysotskyi commented on PR #2526: URL: https://github.com/apache/drill/pull/2526#issuecomment-1114877640 Metastore with JSON should also work fine, here is the unit test that checks it: `TestMetastoreWithEasyFormatPlugin.testAnalyzeOnJsonTable`. For now, drill metastore supports only

<    7   8   9   10   11   12   13   14   15   16   >