[GitHub] drill issue #647: DRILL-4935 Allow Drill to advertise a specific hostname to...

2016-11-09 Thread harrisonmebane
Github user harrisonmebane commented on the issue: https://github.com/apache/drill/pull/647 Do I need to do anything more to push this forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] drill issue #647: DRILL-4935 Allow Drill to advertise a specific hostname to...

2016-11-09 Thread harrisonmebane
Github user harrisonmebane commented on the issue: https://github.com/apache/drill/pull/647 I have tested this fix manually, in the following way: * Deploy Drill in Docker containers on an existing cluster on AWS, with the line ```export DRILL_HOST_NAME=`curl http

[GitHub] drill issue #647: DRILL-4935 Allow Drill to advertise a specific hostname to...

2016-11-08 Thread harrisonmebane
Github user harrisonmebane commented on the issue: https://github.com/apache/drill/pull/647 I have made the changes suggested by @paul-rogers . Are there any unit tests we should add? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] drill pull request #647: DRILL-4935 Allow Drill to advertise a specific host...

2016-11-07 Thread harrisonmebane
Github user harrisonmebane commented on a diff in the pull request: https://github.com/apache/drill/pull/647#discussion_r86922289 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -49,6 +49,7 @@ String USER_RPC_TIMEOUT

[GitHub] drill pull request #647: DRILL-4935 Allow Drill to advertise a specific host...

2016-11-07 Thread harrisonmebane
Github user harrisonmebane commented on a diff in the pull request: https://github.com/apache/drill/pull/647#discussion_r86883806 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -49,6 +49,7 @@ String USER_RPC_TIMEOUT

[GitHub] drill pull request #647: DRILL-4935 Allow Drill to advertise a specific host...

2016-11-07 Thread harrisonmebane
Github user harrisonmebane commented on a diff in the pull request: https://github.com/apache/drill/pull/647#discussion_r86856157 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -142,7 +142,13 @@ private static BufferAllocator

[GitHub] drill issue #647: DRILL-4935 Allow Drill to advertise a specific hostname to...

2016-11-07 Thread harrisonmebane
Github user harrisonmebane commented on the issue: https://github.com/apache/drill/pull/647 I have implemented @xhochy 's suggestion. I will need some guidance on the best way to unit test this new configuration. --- If your project is set up for it, you can reply to this emai

[GitHub] drill issue #647: DRILL-4935 Allow Drill to advertise a specific hostname to...

2016-11-06 Thread harrisonmebane
Github user harrisonmebane commented on the issue: https://github.com/apache/drill/pull/647 I'm aware that the tests will not pass yet; putting what I have up here to make sure I'm on the right track. --- If your project is set up for it, you can reply to this email and

[GitHub] drill pull request #647: DRILL-4935 Allow Drill to advertise a specific host...

2016-11-06 Thread harrisonmebane
GitHub user harrisonmebane opened a pull request: https://github.com/apache/drill/pull/647 DRILL-4935 Allow Drill to advertise a specific hostname to Zookeeper You can merge this pull request into a Git repository by running: $ git pull https://github.com/harrisonmebane/drill