[GitHub] drill pull request #742: DRILL-5242: The UI breaks when rendering profiles h...

2017-02-10 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/742#discussion_r100612470 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java --- @@ -163,11 +165,18 @@ public String

[GitHub] drill pull request #739: DRILL-5230: Translation of millisecond duration int...

2017-02-07 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/739#discussion_r99975170 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java --- @@ -352,16 +369,26 @@ public String cancelQuery

[GitHub] drill pull request #742: DRILL-5242: The UI breaks when rendering profiles h...

2017-02-07 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/742#discussion_r99975093 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java --- @@ -163,11 +165,18 @@ public String getMetricsTable

[GitHub] drill issue #739: DRILL-5230: Translation of millisecond duration into hours...

2017-02-06 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/739 @paul-rogers , @sudheeshkatkam Committed changes based on your recommendations. I also noticed that some of the calls were passing fragment IDs as links, which were never applied. Based

[GitHub] drill pull request #738: DRILL-5190: Display planning time for a query in it...

2017-02-03 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/738#discussion_r99454561 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java --- @@ -77,12 +77,14 @@ */ public

[GitHub] drill pull request #742: DRILL-5242: The UI breaks when rendering profiles h...

2017-02-03 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/742 DRILL-5242: The UI breaks when rendering profiles having unknown metrics Skip any metrics whose metric ID is unknown, This prevents any ArrayIndexOutOfBoundsException from being thrown and breaking

[GitHub] drill pull request #738: DRILL-5190: Display planning time for a query in it...

2017-02-03 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/738#discussion_r99408793 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java --- @@ -77,12 +77,14 @@ */ public

[GitHub] drill pull request #739: DRILL-5230: Translation of millisecond duration int...

2017-02-03 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/739#discussion_r99393776 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java --- @@ -56,6 +47,30 @@ public TableBuilder(final String

[GitHub] drill pull request #739: DRILL-5230: Translation of millisecond duration int...

2017-02-03 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/739#discussion_r99393441 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java --- @@ -56,6 +47,30 @@ public TableBuilder(final String

[GitHub] drill pull request #739: DRILL-5230: Translation of millisecond duration int...

2017-02-02 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/739 DRILL-5230: Translation of millisecond duration into hours is incorrect Fixed invalid representation of readable elapsed time using `TimeUnit` class in JDK. e.g. 4545 sec is now correctly

[GitHub] drill pull request #732: DRILL-5230: Translation of millisecond duration int...

2017-02-02 Thread kkhatua
Github user kkhatua closed the pull request at: https://github.com/apache/drill/pull/732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill issue #732: DRILL-5230: Translation of millisecond duration into hours...

2017-02-02 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/732 Pending testcases --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #737: DRILL-5190: Display planning time for a query in it...

2017-02-02 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/737 DRILL-5190: Display planning time for a query in its profile page Modified UserSharedBit protobuf for marking planning end time. This will allow for accurately reporting the planning time of a query

[GitHub] drill pull request #732: DRILL-5230: Translation of millisecond duration int...

2017-01-29 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/732 DRILL-5230: Translation of millisecond duration into hours is incorrect Fixed invalid representation of readable elapsed time using `TimeUnit` class in JDK. e.g. 4545 sec is now correctly

[GitHub] drill issue #721: DRILL-5172: Display elapsed time for queries in the UI

2017-01-11 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/721 @arina-ielchiieva , @paul-rogers , @sudheeshkatkam Closed the previous PR due to mixup with squashing and rebasing. Please review this PR. --- If your project is set up for it, you can reply

[GitHub] drill pull request #721: DRILL-5172: Display elapsed time for queries in the...

2017-01-11 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/721 DRILL-5172: Display elapsed time for queries in the UI Displays the elapsed time for running queries and the total duration of completed/failed/cancelled queries in the list of query profiles

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-11 Thread kkhatua
Github user kkhatua closed the pull request at: https://github.com/apache/drill/pull/719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill issue #719: DRILL-5172: Display elapsed time for queries in the UI

2017-01-11 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/719 Closing the pull request. Attempted to rebase and squash, but got interleaved commits with master. Will send out a new pull request. --- If your project is set up for it, you can reply

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-11 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/719#discussion_r95692761 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -106,6 +106,7 @@ STATE: ${model.getProfile().getState().name

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-10 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/719#discussion_r95475935 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java --- @@ -105,6 +109,25 @@ public String getTime

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-10 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/719#discussion_r95470389 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java --- @@ -105,6 +109,25 @@ public String getTime

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-10 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/719#discussion_r95469066 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java --- @@ -13595,6 +13597,17 @@ public long getEnd() { return end_

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-10 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/719#discussion_r95432224 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java --- @@ -105,6 +109,25 @@ public String getTime

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-10 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/719#discussion_r95327930 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java --- @@ -13595,6 +13597,17 @@ public long getEnd() { return end_

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-08 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/719#discussion_r95107988 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java --- @@ -72,16 +72,30 @@ public static final

[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...

2017-01-03 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/719 DRILL-5172: Display elapsed time for queries in the UI Displays the elapsed time for running queries and the total duration of completed/failed/cancelled queries in the list of query profiles

[GitHub] drill pull request #655: DRILL-5047: When session option is string, query pr...

2016-11-17 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/655#discussion_r88602974 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -132,7 +132,7 @@ <#list model.getOptionList() as opt

[GitHub] drill issue #655: DRILL-5047: When session option is string, query profile i...

2016-11-17 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/655 @arina-ielchiieva Your fix will not conflict, but is in a branch rebased off 4b1902c . @sudheeshkatkam had reverted the commit for DRILL-4373 2 days later. He is using the following branch

[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...

2015-09-28 Thread kkhatua
Github user kkhatua closed the pull request at: https://github.com/apache/drill/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...

2015-09-28 Thread kkhatua
Github user kkhatua commented on the pull request: https://github.com/apache/drill/pull/71#issuecomment-143909578 Closing pull request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request: DRILL-2961: Throw SQLException when attempting...

2015-05-06 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/71 DRILL-2961: Throw SQLException when attempting to set query timeout Statement.setQueryTimeout(int seconds) is a No-Op, leading the user to believe that a timeout has been set. This provides

<    1   2   3   4   5