Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r99454561
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -77,12 +77,14 @@
*/
public static String getPrettyDuration(long startTimeMillis, long
endTimeMillis) {
long durationInMillis = (startTimeMillis > endTimeMillis ?
System.currentTimeMillis() : endTimeMillis) - startTimeMillis;
- long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);
+ long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);
--- End diff --
Initializing an object for rendering compact or verbose duration formats
might be an overkill.
I'll change the signature for the existing method _getPrettyDuration_ in
the _utility_ class - `ProfileResources.java` to carry an additional parameter
to indicating verbose or compact representation and apply that in DRILL-5230. I
can rebase this commit on top of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
