Github user tdunning commented on the issue:
https://github.com/apache/drill/pull/1133
Fixed the test regression. Deferring investigation into why the data field
doesn't look unique to Drill because we will probably need to revamp how raw
data is returned anyway.
---
GitHub user tdunning opened a pull request:
https://github.com/apache/drill/pull/1134
DRILL-6191 - Add acknowledgement sequence number and flags fields, details
for flags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tdunning
GitHub user tdunning opened a pull request:
https://github.com/apache/drill/pull/1133
DRILL-6190 - Fix handling of packets longer than legally allowed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tdunning/drill DRILL-6190
Github user tdunning closed the pull request at:
https://github.com/apache/drill/pull/1080
---
Github user tdunning commented on the issue:
https://github.com/apache/drill/pull/1080
To follow sequences, group by session id, order by time or sequence number.
This assumes ports are not reused to the same host very often. Will break
occasionally under odd conditions
Github user tdunning commented on the issue:
https://github.com/apache/drill/pull/1080
The Travis failure appears unrelated to this pull request.
---
GitHub user tdunning opened a pull request:
https://github.com/apache/drill/pull/1080
Add acknowledgement sequence number and flags fields.
This pull request relates to DRILL-5432 but is not ready to merge
You can merge this pull request into a Git repository by running:
$ git
Github user tdunning commented on the issue:
https://github.com/apache/drill/pull/831
On Fri, Jun 30, 2017 at 5:34 PM, Paul Rogers
wrote:
> That only works if Drill has an autoloading capability that allows storage
> formats to be loaded and authenticated
Github user tdunning commented on the issue:
https://github.com/apache/drill/pull/831
On Fri, Jun 30, 2017 at 9:55 AM, Paul Rogers
wrote:
> Later, once Drill provides the correct framework, I'd suggest that this
> code move into a separate Github repo to be
Github user tdunning commented on the issue:
https://github.com/apache/drill/pull/831
What is the effective difference between the contrib director and where the
plugin already is?
What sort of testing do you think is necessary?
On Tue, May 30, 2017 at 7
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118399899
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118399867
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
---
@@ -0,0 +1,371 @@
+/*
+ * Licensed to the Apache
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118399621
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
---
@@ -0,0 +1,371 @@
+/*
+ * Licensed to the Apache
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118399563
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapDecoder.java
---
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118397733
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapDecoder.java
---
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118397652
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118397540
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Murmur128.java
---
@@ -0,0 +1,161 @@
+/*
--- End diff --
I
Github user tdunning commented on the pull request:
https://github.com/apache/drill/pull/314#issuecomment-185636190
How could this have been merged? There is a huge double standard going on
here.
This code has NO comments. No tests. No documentation. No design. It
isn&#
Github user tdunning commented on a diff in the pull request:
https://github.com/apache/drill/pull/148#discussion_r42038370
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -82,10 +89,32 @@ public Controller getController
Github user tdunning commented on the pull request:
https://github.com/apache/drill/pull/191#issuecomment-146638022
This looks lovely. There isn't much here but a shim layer to the ESRI
library, but, hey, connecting the dots is a huge contribution.
Is there any reaso
20 matches
Mail list logo
