Re: [DISCUSS]: Changes to Formatting Rules

2019-08-20 Thread Vova Vysotskyi
Hi all, Thanks, Charles, for starting this thread. I have created Jira ticket DRILL-7352 to add more checkstyle rules. I think it is better to continue the discussion there, so it will be easier to follow a discussion and opinions for a person

Re: [DISCUSS]: Changes to Formatting Rules

2019-08-16 Thread Paul Rogers
Hi Charles, Agree. I am reviewing a PR in which formatting was changed. Both the original and revised formatting are fine, and each is often seen in open source projects. But we really should settle on one style so we don't have each of us reformatting code to our favorite styles. Drill does

[DISCUSS]: Changes to Formatting Rules

2019-08-16 Thread Charles Givre
Hello all, I recently submitted a PR and after running the code formatter in IntelliJ, there still were a lot of formatting issues. Personally, I don't really care what the conventions are that we uset, but is it possible to have the formatting template in IntelliJ match the Drill