[GitHub] [drill] arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry

2020-03-02 Thread GitBox
arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry URL: https://github.com/apache/drill/pull/1988#issuecomment-593468295 @paul-rogers four one more issue but unfortunately after I have merged the PR. Create corresponding Jira - https://issues.apache.org/jira/

[GitHub] [drill] arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry

2020-02-29 Thread GitBox
arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry URL: https://github.com/apache/drill/pull/1988#issuecomment-592948213 @paul-rogers please address minor spelling issue and squash the commits, than I'll run the tests and commit. Thanks for making the changes

[GitHub] [drill] arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry

2020-02-28 Thread GitBox
arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry URL: https://github.com/apache/drill/pull/1988#issuecomment-592512894 @paul-rogers changes look good to me. I was going to commit them but found one problem. Disabled plugins are not displayed on Web UI.

[GitHub] [drill] arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry

2020-02-27 Thread GitBox
arina-ielchiieva commented on issue #1988: DRILL-7590: Refactor plugin registry URL: https://github.com/apache/drill/pull/1988#issuecomment-591951040 @paul-rogers thanks for making changes and addressing code review comments. Now you have one minor comment to address and to resolve the co