[GitHub] [drill] jnturton commented on pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

2022-06-07 Thread GitBox
jnturton commented on PR #2568: URL: https://github.com/apache/drill/pull/2568#issuecomment-1148560258 > I've checked the rebase onto latest master fixed `TestDrillSpnegoAuthenticator` locally. So it can be ignored for the review of this PR Yes `TestDrillSpnegoAuthenticator` does work lo

[GitHub] [drill] jnturton commented on pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

2022-06-07 Thread GitBox
jnturton commented on PR #2568: URL: https://github.com/apache/drill/pull/2568#issuecomment-1148553607 I have a question relating to the earlier PR #2566 for this conversion. `JsonLoaderImpl` acquired a new `fromString` method, but it only needed to do that to accommodate the String returne

[GitHub] [drill] jnturton commented on pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

2022-06-07 Thread GitBox
jnturton commented on PR #2568: URL: https://github.com/apache/drill/pull/2568#issuecomment-1148513297 The JDK 8 test failure is the result of me not appreciating the flakiness of TestDrillSpnegoAuthenticator. I'll disable it again soon. -- This is an automated message from the Apache Git