Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/805
This my bad habit to regenerate metadata left from the times before fix
DRILL-5660. These functional test failures are the result of the mistake that I
have made when resolving merge conflicts
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
I'm probably confused. Our goal with the Parquet metadata versioning was
that new Drill versions can read old files. Here we have a case in which I was
running with old versions of the file,
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/805
@paul-rogers, test data should be regenerated (using the Drill version with
this fix) before running functional tests since these tests use metadata cache
files.
Regarding unit test failures:
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
Tried to commit this one. Failed in functional tests:
{noformat}
Data Verification Failures:
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/805
+1
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
OK. Since I'm not a Parquet expert, have asked Salim to take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/805
@paul-rogers, PR is already merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
Thanks for addressing my questions. While waiting for DRILL-5660, I wonder
if we can ask Salim to take a look?
---
If your project is set up for it, you can reply to this email and have your
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/805
Currently, I am waiting when DRILL-5660 is merged. I will add a comment
when it is ready for another review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
What is the status of this PR? More work to do? Ready for another review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/805
Resolved merge conflicts and rebased on latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/805
Thanks for the reminder, @paul-rogers . Somehow, I overlooked this PR. I
thought I have reviewed and merged a PR from @vvysotskyi . But looks like I
confused this one with another one I merged.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/805
@jinfengni, this PR has been sitting idle for a while. Anything else that
needs to be done on this one?
---
If your project is set up for it, you can reply to this email and have your
reply
13 matches
Mail list logo
