Github user magpierre closed the pull request at:
https://github.com/apache/drill/pull/451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user magpierre commented on the pull request:
https://github.com/apache/drill/pull/451#issuecomment-214733518
I recently got a tip from the drill dev team to use the UNION TYPE which is
working great (but needs some code change so possibly this pull request should
be closed and
Github user magpierre commented on the pull request:
https://github.com/apache/drill/pull/451#issuecomment-207091026
I will do the requested, thanks @jaltekruse. Just a quick note on the XML
files it can support: I have tested around 100 different XML formats ranging
from simple to ex
Github user magpierre commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58944903
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLFormatPlugin.java
---
@@ -0,0 +1,139 @@
+/**
+ * Licensed to the
Github user magpierre commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58944565
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLRecordReader.java
---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the
Github user magpierre commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58944333
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLRecordReader.java
---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the
Github user magpierre commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58943891
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLRecordReader.java
---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/451#issuecomment-206989347
Hey @magpierre Thanks for the work on this, we have had request for an XML
reader from a number of community members in the past.
This is the right way to post
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58904712
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLRecordReader.java
---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58904476
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLRecordReader.java
---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58904346
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLRecordReader.java
---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58903153
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLFormatPlugin.java
---
@@ -0,0 +1,139 @@
+/**
+ * Licensed to th
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/451#discussion_r58902477
--- Diff:
contrib/storage-xml/src/main/java/org/apache/drill/exec/store/easy/xml/XMLFormatPlugin.java
---
@@ -0,0 +1,139 @@
+/**
+ * Licensed to th
13 matches
Mail list logo
