[GitHub] drill pull request #1201: DRILL-4091: Support for additional gis operations ...

2018-04-10 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/1201#discussion_r180411032 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STCrosses.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Softwa

[GitHub] drill pull request #1201: DRILL-4091: Support for additional gis operations ...

2018-04-10 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/1201#discussion_r180411754 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STDifference.java --- @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Sof

[GitHub] drill pull request #1201: DRILL-4091: Support for additional gis operations ...

2018-04-10 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/1201#discussion_r180410015 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STBuffer.java --- @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Softwar

[GitHub] drill pull request #1201: DRILL-4091: Support for additional gis operations ...

2018-04-10 Thread cgivre
Github user cgivre commented on a diff in the pull request: https://github.com/apache/drill/pull/1201#discussion_r180412106 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STDisjoint.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Softw

[GitHub] drill pull request #1201: DRILL-4091: Support for additional gis operations ...

2018-04-03 Thread ChrisSandison
GitHub user ChrisSandison opened a pull request: https://github.com/apache/drill/pull/1201 DRILL-4091: Support for additional gis operations in gis contrib module This based off of PR https://github.com/apache/drill/pull/258. I have attempted to address the comments from the PR left