GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/997
DRILL-5582: C++ Client: [Threat Modeling] Drillbit may be spoofed by â¦
â¦an attacker and this may lead to data being written to the attacker's
target instead of Drillbit
You can merge this pul
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/997#discussion_r145317403
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -595,6 +611,12 @@ connectionStatus_t
DrillClientImpl::validateHandshake(DrillUse
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/997#discussion_r145317288
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -595,6 +611,12 @@ connectionStatus_t
DrillClientImpl::validateHandshake(DrillUse
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/997#discussion_r145319760
--- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp ---
@@ -145,6 +145,8 @@ int SaslAuthenticatorImpl::init(const
std::vector& mechanisms,
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/997#discussion_r145319769
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -518,6 +518,22 @@ bool DrillClientImpl::clientNeedsEncryption(const
DrillUserPropertie
