mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1384188980
##
contrib/format-daffodil/.gitignore:
##
Review Comment:
Remove this file from change set.
##
contrib/format-daffodil/src/main/java/org/apache/drill/e
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1377002280
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderCo
mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376997202
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/schema/DrillDaffodilSchemaVisitor.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apach
mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376993821
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReade
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376780198
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderCo
mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376750700
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReade
mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376747507
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Fou
mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376711538
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReade
mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376710569
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReade
cgivre commented on PR #2836:
URL: https://github.com/apache/drill/pull/2836#issuecomment-1783992062
@mbeckerle Looks like you're making good progress!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1375364472
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilDrillInfosetOutputter.java:
##
@@ -1,25 +1,21 @@
package org.apache.drill.exec.store
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1375364409
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderCo
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1375364309
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderCo
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1375364162
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderCo
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1375364126
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderCo
jnturton commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1367675681
##
contrib/pom.xml:
##
@@ -59,6 +59,7 @@
format-pcapng
format-iceberg
format-deltalake
+format-daffodil
Review Comment:
@mbeckerle #2825 is merged
jnturton commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1365726721
##
contrib/pom.xml:
##
@@ -59,6 +59,7 @@
format-pcapng
format-iceberg
format-deltalake
+format-daffodil
Review Comment:
@mbeckerle we're starting
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1364798604
##
contrib/pom.xml:
##
@@ -59,6 +59,7 @@
format-pcapng
format-iceberg
format-deltalake
+format-daffodil
Review Comment:
Please keep these in alphabe
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1364797899
##
contrib/format-daffodil/src/test/java/org/apache/drill/exec/store/daffodil/TestDaffodilReader.java:
##
@@ -0,0 +1,652 @@
+/*
+ * Licensed to the Apache Software Foundat
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1364798270
##
distribution/src/assemble/component.xml:
##
Review Comment:
Please keep these in alphabetical order.
--
This is an automated message from the Apache Git Servic
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1364797516
##
contrib/format-daffodil/src/test/java/org/apache/drill/exec/store/daffodil/TestDaffodilReader.java:
##
@@ -0,0 +1,652 @@
+/*
+ * Licensed to the Apache Software Foundat
cgivre commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1364795241
##
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Founda
mbeckerle opened a new pull request, #2836:
URL: https://github.com/apache/drill/pull/2836
# [DRILL-2835](https://issues.apache.org/jira/browse/DRILL-2835):
Preliminary Review on adding Daffodil to Drill
## Description
New format-daffodil module created. But I need assistance w
23 matches
Mail list logo
