Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Jason Altekruse
Just pushed the fix. We should be good to go. On Wed, Oct 7, 2015 at 4:31 PM, Jason Altekruse wrote: > It should be in the next 15 minutes. Andrew confirmed that he was able to > run some manual tests on the revised branch (the one I will be pushing) > that just contained his core fixes. > > I t

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Jason Altekruse
It should be in the next 15 minutes. Andrew confirmed that he was able to run some manual tests on the revised branch (the one I will be pushing) that just contained his core fixes. I think it would be fine to limit commits before the next release candidate goes out. On Wed, Oct 7, 2015 at 4:25 P

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Abdel Hakim Deneche
Jason, any estimate when the fix will be part of master, at least the part required for 1.2.0 ? also, should we hold off on committing anything that's not absolutely required for 1.2.0 at this point ? Thanks On Wed, Oct 7, 2015 at 4:19 PM, Jason Altekruse wrote: > So far we have not been able

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Jason Altekruse
So far we have not been able to determine what is making the test intermittently fail. I have pulled the core changes out of the branch and I am running a final build to verify them with the existing tests. As this is code that wasn't being tested previously I don't anticipate any issues, and shoul

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Jacques Nadeau
Splitting out the integration tests makes sense if they are causing conflicts. Lets just get them merged asap after the release. -- Jacques Nadeau CTO and Co-Founder, Dremio On Wed, Oct 7, 2015 at 2:28 PM, Jason Altekruse wrote: > Unfortunately the complete build is still having issues, althoug

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Jason Altekruse
Unfortunately the complete build is still having issues, although I can get the specific module where the tests were added to run just fine. I'm going to try to figure it out ASAP, but if I cannot get the full tests running it won't make sense to merge the patch as is. Would there be any objectio

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Jason Altekruse
Hey Everyone, I ran into an issue testing the JDBC patch from Andrew. After a little investigation I managed to find a fix for it, just a small change in the pom configuration for the new integration tests. I am doing one final run of the full unit tests and will push his changes soon (~30 mins)

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Aditya
I am planning to merge patch for DRILL-3888 to enable maven test artifacts for all modules. On Wed, Oct 7, 2015 at 1:06 PM, Abdel Hakim Deneche wrote: > Ok, let's cancel this release candidate and do another one once we get the > required fixes in master. > > So far the only issue left to fix fo

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Abdel Hakim Deneche
Ok, let's cancel this release candidate and do another one once we get the required fixes in master. So far the only issue left to fix for 1.2.0 is Andrew's Jdbc storage fix ? Thanks On Wed, Oct 7, 2015 at 10:49 AM, Steven Phillips wrote: > I don't think there is one yet. But I think there wil

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Steven Phillips
I don't think there is one yet. But I think there will be a jira along with a fix coming shortly from Andrew. On Wed, Oct 7, 2015 at 10:46 AM, Abdel Hakim Deneche wrote: > Steven, what is the JIRA number for the jdbc storage issue ? > > Thanks > > On Wed, Oct 7, 2015 at 10:41 AM, Steven Phillips

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Abdel Hakim Deneche
Steven, what is the JIRA number for the jdbc storage issue ? Thanks On Wed, Oct 7, 2015 at 10:41 AM, Steven Phillips wrote: > There is also the jdbc storage issue, which Andrew says he has a fix for. > It's just a packaging problem, but given that it's one of the main features > of this release

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Steven Phillips
There is also the jdbc storage issue, which Andrew says he has a fix for. It's just a packaging problem, but given that it's one of the main features of this release, I think it's important to get in. On Wed, Oct 7, 2015 at 10:39 AM, Abdel Hakim Deneche wrote: > sorry, I meant is DRILL-3901 a mu

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Steven Phillips
I think we should do a new candidate. We have two fixes that seem somewhat important. On Wed, Oct 7, 2015 at 10:37 AM, Abdel Hakim Deneche wrote: > the only way to include any new fixes into 1.2.0 is to sink the current > release candidate and start another one. > > is DRILL-3892 a must have for

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Abdel Hakim Deneche
sorry, I meant is DRILL-3901 a must have for 1.2.0 ? On Wed, Oct 7, 2015 at 10:37 AM, Abdel Hakim Deneche wrote: > the only way to include any new fixes into 1.2.0 is to sink the current > release candidate and start another one. > > is DRILL-3892 a must have for 1.2.0 ? > > Thanks > > On Wed, O

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Abdel Hakim Deneche
the only way to include any new fixes into 1.2.0 is to sink the current release candidate and start another one. is DRILL-3892 a must have for 1.2.0 ? Thanks On Wed, Oct 7, 2015 at 10:29 AM, Aman Sinha wrote: > DRILL-3901 patch is merged and I took the liberty to mark it for 1.2.0 but > will l

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Aman Sinha
DRILL-3901 patch is merged and I took the liberty to mark it for 1.2.0 but will leave it up to the release manager to decide how to incorporate it. I also strongly feel that DRILL-3892 (incorrectly reported status of metadata cache *not* being used when in fact it was used) should be included in 1

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Jacques Nadeau
We're seeing an issue around the JDBC plugin. We're still debugging but it might also warrant a fix for the release. Updates soon. -- Jacques Nadeau CTO and Co-Founder, Dremio On Tue, Oct 6, 2015 at 11:45 AM, Aman Sinha wrote: > I have filed DRILL-3901 for a performance issue that we are trying

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-07 Thread Aditya
Do you want to create a 1.2 branch off the proposed revision so that version in the master branch can be moved to 1.3-SNAPSHOT and features/fixes targeted for next release can be committed without any confusion? On Tue, Oct 6, 2015 at 11:45 AM, Aman Sinha wrote: > I have filed DRILL-3901 for a p

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-06 Thread Aman Sinha
I have filed DRILL-3901 for a performance issue that we are trying to address. We can discuss whether to continue with the existing release candidate or wait for a fix. On Tue, Oct 6, 2015 at 9:38 AM, Edmon Begoli wrote: > Humbly, +1. > > On Tue, Oct 6, 2015 at 12:32 PM, Abdel Hakim Deneche < >

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-06 Thread Edmon Begoli
Humbly, +1. On Tue, Oct 6, 2015 at 12:32 PM, Abdel Hakim Deneche wrote: > verified the artifacts checksums and that they are signed by my gpg key. > Built Drill from source in MacOS and CentOS and both builds were successful > and all unit tests passed. Run some window functions queries and ever

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-06 Thread Abdel Hakim Deneche
verified the artifacts checksums and that they are signed by my gpg key. Built Drill from source in MacOS and CentOS and both builds were successful and all unit tests passed. Run some window functions queries and everything seems fine. +1 (binding) On Mon, Oct 5, 2015 at 1:59 PM, Abdel Hakim Den

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-05 Thread Abdel Hakim Deneche
Aman, I used JIRA release notes generator. It includes all JIRAs marked "Fix for" 1.2.0. I guess we just need to move all JIRAs still open and marked as 1.2.0 to 1.3.0 or Future. On Mon, Oct 5, 2015 at 1:54 PM, Aman Sinha wrote: > I see the following in the release notes: this is not supported

RE: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-05 Thread Norris Lee
@drill.apache.org Subject: Re: [VOTE] Release Apache Drill 1.2.0 (rc0) One precision, the commit that should show up in the release is the following: b418397790e7e00505846d48bc6458d710c00095 upgrading maven-release plugin to fix release issues master has already moved past that commit thanks On Mon, Oct 5

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-05 Thread Aman Sinha
I see the following in the release notes: this is not supported yet. Are you using the correct 'status' condition in your query ? - [DRILL-3534 ] - Insert into table support On Mon, Oct 5, 2015 at 1:16 PM, Abdel Hakim Deneche wrote: > O

Re: [VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-05 Thread Abdel Hakim Deneche
One precision, the commit that should show up in the release is the following: b418397790e7e00505846d48bc6458d710c00095 upgrading maven-release plugin to fix release issues master has already moved past that commit thanks On Mon, Oct 5, 2015 at 11:00 AM, Abdel Hakim Deneche wrote: > Hey all,

[VOTE] Release Apache Drill 1.2.0 (rc0)

2015-10-05 Thread Abdel Hakim Deneche
Hey all, I'm happy to propose a new release of Apache Drill, version 1.2.0. This is the first release candidate (rc0). Thanks to everyone who contributed to this release, we have more than 200 closed and resolved JIRAs [1]. The tarball artifacts are hosted at [2] and the maven artifacts (new for