Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-18 Thread Chun Chang
@Ramana Thanks for the input. I noticed that too. Parquet-mr has some examples. Regards On Wed, Nov 18, 2015 at 11:21 AM, Ramana I N wrote: > @Chun > When I was working on generating parquet files for testing drill and > parquet I did use parquet-compat, but that project has since been > abando

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-18 Thread Ramana I N
@Chun When I was working on generating parquet files for testing drill and parquet I did use parquet-compat, but that project has since been abandoned. So it may not contain the latest changes in parquet. Parquet-mr looks more promising. Regards Ramana On Thu, Nov 12, 2015 at 11:29 AM, Chun Chan

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Aman Sinha
Sounds good. I assume the discussion on those 2 questions can be done on the JIRA. On Thu, Nov 12, 2015 at 10:57 AM, Jacques Nadeau wrote: > Hey Guys, > > It sounds like the Parquet upgrade in 1.3 have fixed an incorrect result > problem with externally generated files. This has unfortunately r

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Chun Chang
I am working on putting together a comprehensive test plan specifically covering parquet reader. One part of the plan is to create a tool that can generate parquet files of all flavors. This will considerably increase our coverage, and hopefully prevent this type of issues. I am looking at paqeut-m

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Jacques Nadeau
Hey Guys, It sounds like the Parquet upgrade in 1.3 have fixed an incorrect result problem with externally generated files. This has unfortunately resulted in a performance regression in the context of partition pruning. I'm neutral on whether this is a release stopper but it sounds like we have s

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread rahul challapalli
@Steven, @Neeraja For now we know partition pruning to fail. While I did not probe further, its not hard to imagine the possibility of wrong results being returned in cases where we have nulls in the varchar partition column. - Rahul On Thu, Nov 12, 2015 at 10:48 AM, rahul challapalli < challapa

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread rahul challapalli
While breaking backward compatibility could be justified in cases like this, doing this without providing a tested upgrade process is unacceptable. - Rahul On Thu, Nov 12, 2015 at 10:43 AM, Steven Phillips wrote: > Does DRILL-4070 cause incorrect results? Or just prevent partition pruning? > >

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Neeraja Rentachintala
Same question as Steven. What is the impact. It seemed from the bug the impact is both wrong results and partition pruning not working. Drill is a generally available project now and there are users who created millions of parquet files using previous version of Drill. Hence I think is a release bl

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Steven Phillips
Does DRILL-4070 cause incorrect results? Or just prevent partition pruning? On Thu, Nov 12, 2015 at 10:32 AM, Jason Altekruse wrote: > I just commented on the JIRA, we are behaving correctly for newly created > parquet files. I did confirm the failure to prune on auto-partitioned files > created

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Jason Altekruse
I just commented on the JIRA, we are behaving correctly for newly created parquet files. I did confirm the failure to prune on auto-partitioned files created by 1.2. I do not think this is a release blocker, because I do not think we can solve this in Drill code without risking wrong results over p

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Jinfeng Ni
Agree with Aman that DRILL-4070 is a show stopper. Parquet is the major data source Drill uses. If this release candidate breaks the backward compatibility of partitioning pruning for the parquet files created with prior release of Drill, it could cause serious problem for the current Drill user.

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread rahul challapalli
-1 (non-binding) The nature of the issue (DRILL-4070) demands adequate testing even with a workaround in place. On Thu, Nov 12, 2015 at 9:32 AM, Aman Sinha wrote: > Given this issue, I would be a -1 unfortunately. > > On Thu, Nov 12, 2015 at 8:42 AM, Aman Sinha wrote: > > > Can someone familia

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Aman Sinha
Given this issue, I would be a -1 unfortunately. On Thu, Nov 12, 2015 at 8:42 AM, Aman Sinha wrote: > Can someone familiar with the parquet changes take a look at DRILL-4070 ? > It seems to break backward compatibility. > > On Tue, Nov 10, 2015 at 9:51 PM, Jacques Nadeau > wrote: > >> Hey Ever

Re: [VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-12 Thread Aman Sinha
Can someone familiar with the parquet changes take a look at DRILL-4070 ? It seems to break backward compatibility. On Tue, Nov 10, 2015 at 9:51 PM, Jacques Nadeau wrote: > Hey Everybody, > > I'd like to propose a new release candidate of Apache Drill, version > 1.3.0. This is the third release

[VOTE] Release Apache Drill 1.3.0 (rc2)

2015-11-10 Thread Jacques Nadeau
Hey Everybody, I'd like to propose a new release candidate of Apache Drill, version 1.3.0. This is the third release candidate (rc2). This addresses some issues identified in the the second release candidate including some test issues & rpc concurrency issues. The tarball artifacts are hosted a