Re: Auto-closing old PRs

2019-02-28 Thread Dylan Wylie
Infra got this switched on this morning for the repository, anyone who gets email notifications would have unfortunately been spammed as the bot worked through all our old PRs. This will likely happen again in 7 days when it closes all the PRs that remain inactive. For anyone wanting to clean up t

Re: Auto-closing old PRs

2019-02-28 Thread Roman Leventov
IMO, 60 days is nothing in Druid terms. I suggest making it 6 months. On Thu, 28 Feb 2019 at 07:36, Dylan Wylie wrote: > Infra got this switched on this morning for the repository, anyone who gets > email notifications would have unfortunately been spammed as the bot worked > through all our old

Re: Auto-closing old PRs

2019-02-28 Thread Gian Merlino
I thought the bot uses a threshold of 60 days with absolutely no activity (not 60 days since opening or anything like that); that does seem like a long time to me for a PR to be totally silent. Especially considering the bot won't close the PR right away, but will make a comment first asking if any

Re: Uninterruptibles and Futures.getUnchecked()

2019-02-28 Thread Gian Merlino
Have you got sections in mind in Druid code that would be improved by using these? On Tue, Feb 26, 2019 at 3:04 PM Roman Leventov wrote: > I've recently discovered two utilities in Guava that are very useful in > combating InterruptedExceptions that contaminate business logic of code: > > - Uni

Re: Uninterruptibles and Futures.getUnchecked()

2019-02-28 Thread Roman Leventov
There are about 90 usages of Future.get() (both forms) in the codebase. I didn't check any of them (except just one - see below), but I suspect that in a lot of those places Futures.getUnchecked() could have been called to clarify or even improve the logic. That one occurrence that I've run into w

Downloading binaries of previous Druid versions

2019-02-28 Thread Eyal Yurman
Hi, Are binaries of previous versions from before 0.13.0-incubating still available for download? Or should one build the old version from source? Thanks, Eyal.