Re: CI requiring approval for external contributors

2023-03-28 Thread Frank Chen
+1 I don't see there's a need for committers to click the 'Approve' button to run CI for every PR. On Tue, Mar 28, 2023 at 2:27 PM Austin Bennett wrote: > Beam did the same. > > +1 on allowing contributors to keep things moving [where appropriate, > which this can be if CI is setup well],

Re: Question regarding new development

2023-03-28 Thread Gian Merlino
Looks like the conversation is now in https://github.com/apache/druid/issues/13948. On Sat, Mar 18, 2023 at 8:00 AM Sergiu Ungureanu wrote: > Hi Team, > > Yesterday I raised a question in #dev channel in slack > > https://apachedruidworkspace.slack.com/archives/C030CMF6B70/p1679085073683509 > >

Re: CI requiring approval for external contributors

2023-03-28 Thread Austin Bennett
Beam did the same. +1 on allowing contributors to keep things moving [where appropriate, which this can be if CI is setup well], allowing committers to focus on more/other activities On Mon, Mar 27, 2023, 11:24 PM Gian Merlino wrote: > Recently, ASF GitHub repos had their defaults for GitHub

CI requiring approval for external contributors

2023-03-28 Thread Gian Merlino
Recently, ASF GitHub repos had their defaults for GitHub Actions changed to "always require approval for external contributors". In Slack, Karan pointed out that Airflow has recently submitted a ticket to have that changed back: https://issues.apache.org/jira/browse/INFRA-24200. IMO, we should do