I think there is also an option of "Only requires approval first time".
This is what Apache Iceberg has been using before ASF GitHub repos had
their defaults for GitHub Actions changed and is what they are most likely
going back to.
On Wed, Mar 29, 2023 at 6:43 AM Karan Kumar
wrote:
> +1
>
+1
Pasting some of the examples that I shared on slack:
- PR : https://github.com/apache/druid/pull/13934 which is raised by
Soumyava Das who contributes regularly to druid should not block on a
committer to approve CI runs.
- PR : https://github.com/apache/druid/pull/13909 by Adarsh
+1
I don't see there's a need for committers to click the 'Approve' button to
run CI for every PR.
On Tue, Mar 28, 2023 at 2:27 PM Austin Bennett wrote:
> Beam did the same.
>
> +1 on allowing contributors to keep things moving [where appropriate,
> which this can be if CI is setup well],
Beam did the same.
+1 on allowing contributors to keep things moving [where appropriate,
which this can be if CI is setup well], allowing committers to focus on
more/other activities
On Mon, Mar 27, 2023, 11:24 PM Gian Merlino wrote:
> Recently, ASF GitHub repos had their defaults for GitHub
Recently, ASF GitHub repos had their defaults for GitHub Actions changed to
"always require approval for external contributors". In Slack, Karan
pointed out that Airflow has recently submitted a ticket to have that
changed back: https://issues.apache.org/jira/browse/INFRA-24200. IMO, we
should do
