Re: TeamCity CI - new IntelliJ version

2019-03-09 Thread Roman Leventov
I've rolled back to 2017.2.4. Failing builds (e. g. https://teamcity.jetbrains.com/viewLog.html?buildId=2045510=Inspection=OpenSourceProjects_Druid_InspectionsPullRequests) provide enough information to try to fix the problems and then to try to upgrade to 2018.3.1 again. Independent of that, the

Re: TeamCity CI - new IntelliJ version

2019-03-08 Thread Gian Merlino
Or at least do some spot checks to verify that the TC errors are not related to the patch in question. On Fri, Mar 8, 2019 at 5:50 PM Gian Merlino wrote: > That sounds fine to me (ignoring TC for now on other PRs while any new > issues since the upgrade is fixed separately). If no-one is able

Re: TeamCity CI - new IntelliJ version

2019-03-08 Thread Gian Merlino
That sounds fine to me (ignoring TC for now on other PRs while any new issues since the upgrade is fixed separately). If no-one is able to fix them quickly I'd suggest rolling back to 2017.2.4, so we don't have a super long period of time where we need to ignore TC. On Fri, Mar 8, 2019 at 5:29 PM

Re: TeamCity CI - new IntelliJ version

2019-03-08 Thread Gian Merlino
Please help fix anything that breaks. Hopefully this also _improves_ things -- I recall an inspection bug we hit that was fixed in some version later than 2017.2.4. On Fri, Mar 8, 2019 at 12:21 PM Roman Leventov wrote: > I've updated inspections build step in TeamCity CI to use IntelliJ

TeamCity CI - new IntelliJ version

2019-03-08 Thread Roman Leventov
I've updated inspections build step in TeamCity CI to use IntelliJ 2018.3.1 instead of 2017.2.4. The builds are expected to start to fail because IntelliJ has likely refined some existing inspections so that they make more findings.