Calling for updating contributors information on dubbo website

2018-10-30 Thread Jerrick Zhu
hi, community Now dubbo.io has added a page for showing all committers and contributors. Now everything is ok except contributors information. So I am calling for you to file a PR on dubbo-website[1], adding your information on developers_dev.md[2]. Remember English pages[3] :) Anything about fi

Re: Calling for updating contributors information on dubbo website

2018-10-30 Thread Jerrick Zhu
BTW, the developers page on dubbo.io is http://dubbo.apache.org/zh-cn/docs/developers/developers_dev.html On Tue, Oct 30, 2018 at 4:14 PM Jerrick Zhu wrote: > hi, community > > Now dubbo.io has added a page for showing all committers and contributors. > > Now everything is ok except contributors

Re: Calling for updating contributors information on dubbo website

2018-10-30 Thread Jerrick Zhu
Remember to attach your major commits for dubbo projects(dubbo, dubbo-ops, dubbo-website) when you file a new PR. On Tue, Oct 30, 2018 at 4:15 PM Jerrick Zhu wrote: > BTW, the developers page on dubbo.io is > http://dubbo.apache.org/zh-cn/docs/developers/developers_dev.html > > On Tue, Oct 30, 2

Re: pull request 2686

2018-10-30 Thread Ian Luo
Xiaobo, I notice that you've already updated pull request. Now the change looks good, and I've merged your pull request. Thanks, -Ian. On Tue, Oct 30, 2018 at 11:19 AM Ian Luo wrote: > Xiaobo, > > Would you mind to take a look at the comments I dropped on pull request > 2686 [1] you proposed?

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-30 Thread Ian Luo
Now it looks like a release:-D, THANK you Victor. -Ian. On Tue, Oct 30, 2018 at 2:22 PM victory wrote: > I have checked again， and modify the release note here: > https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md . > You can also check it as follow: > > Enhancements / Feat

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-30 Thread yuhang xiu
Nice work! Also thanks to victory for reminding me to add PR related ISSUE. Ian Luo 于2018年10月30日周二 下午5:17写道： > Now it looks like a release:-D, THANK you Victor. > > -Ian. > > On Tue, Oct 30, 2018 at 2:22 PM victory wrote: > > > I have checked again， and modify the release note here: > > https:/

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-30 Thread jun liu
Hi, Victory Well done! That’s a detailed summary of the release candidates for 2.6.5. I wonder if you'd like to be the manager of this release? The main responsibilities of a manager would be: 1. find out all changes already included in branch 2.6.x and the issues that need to be fixed in this

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-30 Thread 周吉林
congratulations to Jinkai Ma! YunKun Huang 于2018年10月30日周二 上午11:54写道： > Congratulations ！ > > On 2018/10/30 03:20:58, yuhang xiu wrote: > > Hi, jinkai > > Congratulations on your joining! > > > > Jun Liu 于2018年10月30日周二 上午11:15写道： > > > > > > > > > > > > On Oct 30, 2018, at 11:12 AM, Jun Liu w

Re: pull request 2686

2018-10-30 Thread Ian Luo
XiaoBo, Nice! Pls. consider contributing more to the community in the future. Recently, I have bean writing a series of blogs about Dubbo Pls. share the link with the community (send email to dev@dubbo.apache.org) once you finish :) You can also consider to post your article to Dubbo's website [

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-30 Thread victory
congratulation ！ My idol. 周吉林 于2018年10月31日周三 上午9:10写道： > congratulations to Jinkai Ma! > > > YunKun Huang 于2018年10月30日周二 上午11:54写道： > > > Congratulations ！ > > > > On 2018/10/30 03:20:58, yuhang xiu wrote: > > > Hi, jinkai > > > Congratulations on your joining! > > > > > > Jun Liu 于2018年10月30

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-30 Thread victory
I would like to be the manager of 2.6.5 release. I will do some prepare work for this release including collect the issue list and package snapshot jar. So I donot know if I have the permission to package the release jar . I expect to get the answer from the community. jun liu 于2018年10月30日周二 下

[WANTED]: contribute to blogs

2018-10-30 Thread Ian Luo
Hi folks, Today I post a plan [1] on building blogs on Dubbo website.I hope eventually we could create one book out of the posted blogs, so pls. follow the style of Manning In Action series when you write the blog. If you are interested, feel free to join us. Thanks, -Ian. 1. https://github.co

pull request 2607

2018-10-30 Thread Ian Luo
Hi Jeff, I reviewed your work on PR#2607 [1] today. It looks good, but has two minor imports issue, pls. see the details from the pull request. Thanks, -Ian. 1. https://github.com/apache/incubator-dubbo/pull/2607

Re: pull request 2607

2018-10-30 Thread RQ
Ian, thanks your reviewing. I just resolved by some fixings according to your advices. Regards, Jeff Ian Luo 于2018年10月31日周三 上午11:40写道： > Hi Jeff, > > I reviewed your work on PR#2607 [1] today. It looks good, but has two minor > imports issue, pls. see the details from the pull request. > > Than

Re: pull request 2607

2018-10-30 Thread Ian Luo
I will merge it once it passes CI. On Wed, Oct 31, 2018 at 2:15 PM RQ wrote: > Ian, thanks your reviewing. I just resolved by some fixings according to > your advices. > > Regards, > Jeff > > Ian Luo 于2018年10月31日周三 上午11:40写道： > > > Hi Jeff, > > > > I reviewed your work on PR#2607 [1] today. It