Hi,
I see someone send a pull request to 2.5.x branch[1].
My question is that is 2.5.x branch still being supported?
IMO, we should consider announce the end of life in the near future,
say 1 year, and only support critical bug fix or security fix, while
that we should provide a migration guide fo
+1
-- Original --
From: Huxing Zhang
Date: Thu,Mar 7,2019 4:50 PM
To: dev
Subject: Re: Is 2.5.x still being supported?
Hi,
I see someone send a pull request to 2.5.x branch[1].
My question is that is 2.5.x branch still being supported?
IMO, we should consid
Hi,
When I am looking at the pull request, I found a pull request[1] got
approved by 2 of our reviewers(committers), but still not getting
merged.
I am thinking why it is like this. Should we set up community rules
for thing like this?
For example, if a pull request has got at least N approval fr
Hi,
Every one.
I use dubbo spring-boot with
com.alibaba.boot
dubbo-spring-boot-starter
0.2.0
And in order to decouple with dubbo .
I do not use @Service (com.alibaba.dubbo.config.annotation.Service)
annotation on my serviceImpl class , but add @Component annotation to them.
Hi,
I don’t think it’s a problem about number of reviewers , As time goes by,
we will slowly ignore it,We pay more attention to the new issue.
Huxing Zhang 于2019年3月7日周四 下午5:04写道:
> Hi,
>
> When I am looking at the pull request, I found a pull request[1] got
> approved by 2 of our reviewers(com
I think it is reasonable to set up one reviewer.
Because reviewing a pr itself requires a reviewer, and the reviewer can also
self-mark, indicating that he wants to keep an eye on the pr.
Reviewers prefer to choose from the issue's discussants.
Best Regards!
Zhongming Hua
在 2019/3/7 下午5:12,“
+1
consider announce the end of life in the near future,
say 1 year, and only support critical bug fix or security fix, while
that we should provide a migration guide for user to upgrade from
2.5.x to 2.6.x or 2.7.x.
Best Regards!
Zhongming Hua
在 2019/3/7 下午5:00,“Taosheng, Wei” 写入:
+1
+1 on maintain only for branch 2.5.x and EOL announcement
华 钟明 于2019年3月7日周四 下午5:25写道:
> +1
> consider announce the end of life in the near future,
> say 1 year, and only support critical bug fix or security fix, while
> that we should provide a migration guide for user to upgrade from
> 2.5.x to
Hi,
On Thu, Mar 7, 2019 at 5:12 PM LiZhenNet wrote:
>
> Hi,
> I don’t think it’s a problem about number of reviewers , As time goes by,
> we will slowly ignore it,We pay more attention to the new issue.
Are you suggesting not to set up such a hard limit?
It just looks strange to me, that 2 of th
http://dubbo.apache.org/en-us/docs/developers/user-guide/faq_dev.html
原始邮件
发件人: Yuhao Bi
收件人: dev
发送时间: 2019年3月7日(周四) 17:26
主题: Re: Is 2.5.x still being supported?
+1 on maintain only for branch 2.5.x and EOL announcement
华 钟明 mailto:crazy...@gmail.com>> 于2019年3月7日周四 下午5:25写道:
> +1
> consider
Hi,Huxing
Your suggestion is right, I mean we should pay attention to the previously
submitted issue.
Close? Merge? or Add comment .
We should resolve the issue that was created for a long time as soon as
possible.
Huxing Zhang 于2019年3月7日周四 下午5:28写道:
> Hi,
>
> On Thu, Mar 7, 2019 at 5:12 PM L
Hi,
I also suggest the reviewer to follow the standard reviewing
process[1], rather than just leave a comment.
To me, the advantage are as follows:
- review status will be displayed in pull request, one can easily
identify pull request that is in "request change" so that you won't
look into it aga
For this particular PR, the reason I approved but not merged it is that I think
the code change itself is ok but I don’t understand the connection with the
issue the author claims to solve. I plan to merge it after fully understand,
unfortunately, I just forgot to check the feedback.
Jun
> On
Hi,
On Thu, Mar 7, 2019 at 5:32 PM 李 晓杰 wrote:
>
> http://dubbo.apache.org/en-us/docs/developers/user-guide/faq_dev.html
Haha, it looks like it is discussed before. Then let's decide the EOL date.
How about:
a) End of 2019, which 2019-12-31
b) half year since now, which is 2019-9-7
c) 3 month si
Hi,
On Thu, Mar 7, 2019 at 5:42 PM LiZhenNet wrote:
>
> Hi,Huxing
> Your suggestion is right, I mean we should pay attention to the previously
> submitted issue.
> Close? Merge? or Add comment .
> We should resolve the issue that was created for a long time as soon as
> possible.
+1 but this i
Great! With this we would be able to support Rx programming model and Stream
communication.
I’d like to give a review on it.
Jun
> On Mar 7, 2019, at 3:05 PM, yuneng xie wrote:
>
> Hi folks,
>
> the first stage of the reative-stream support has been finished. we now can
> using Mono/Flux as
Hello Dubbo Community,
I'd like to add metrics support in dubbo admin based on this[1], when
it's done, we can check dubbo service metrics information on a single
server.
[1]
https://lists.apache.org/thread.html/d86bfc428a04451e01de5b9f9844822f65ab1944e102474caf6e0a3a@%3Cdev.dubbo.apache.org%
> IMO, we should consider announce the end of life in the near future,
> say 1 year, and only support critical bug fix or security fix,
In fact, 2.5.x has been out of the community’s daily maintenance for a while.
And I think few users are still staying on this branch, this can be told from
the
Hi,
The goal of the test-dubbo project is to bring together more tools for
verifying Dubbo, such as integration testing, performance testing, high
availability testing, etc., making Dubbo's testing easier and more efficient.
PelicanDT is an integrated test solution for distributed applications.
Looking forward to metrics.
Some long-mentioning proposals such as embedded short-circuiter (both
instance-level and cluster-level) depend on metrics as source and basis.
Jun
> On Mar 7, 2019, at 6:01 PM, Minxuan Zhuang wrote:
>
> Hello Dubbo Community,
> I'd like to add metrics support in
Congratulations!
Jun
> On Mar 6, 2019, at 6:19 PM, Yuhao Bi wrote:
>
> Welcome and Congratulations!
>
> kezhenx...@163.com 于2019年3月6日周三 下午5:45写道:
>
>>
Congratulations!
Jun
> On Mar 5, 2019, at 9:37 PM, Huxing Zhang wrote:
>
> Hi Zhenxu,
>
> Congratulations and welcome! Would you please also update your
> information (including your affiliation) to the official website?
>
>
> On Tue, Mar 5, 2019 at 6:24 PM kezhenxu94 wrote:
>>
>> Hi The
Congratulations!
jun liu 于2019年3月7日周四 下午8:43写道:
> Congratulations!
>
> Jun
>
> > On Mar 5, 2019, at 9:37 PM, Huxing Zhang wrote:
> >
> > Hi Zhenxu,
> >
> > Congratulations and welcome! Would you please also update your
> > information (including your affiliation) to the official website?
> >
Congratulations!
jun liu 于2019年3月7日周四 下午8:43写道:
> Congratulations!
>
> Jun
>
> > On Mar 6, 2019, at 6:19 PM, Yuhao Bi wrote:
> >
> > Welcome and Congratulations!
> >
> > kezhenx...@163.com 于2019年3月6日周三 下午5:45写道:
> >
> >>
>
>
Hi, junyang
> The goal of the test-dubbo project is to bring together more tools for
> verifying Dubbo, such as integration testing, performance testing, high
> availability testing, etc., making Dubbo's testing easier and more efficient.
We have been thinking of implementing "automatic integra
Since the majority of the users are still in china I think it's not urgent to
start a deliberated Dubbo channel on stackoverflow.
I think what Ian suggests is more practicable, start from checking dubbo
related questions on stackoverflow, then we decide the necessity of opening
one. Stackoverfl
+0 to rename.
Agree to rename on 3.0, if we finally decide to do that.
Jun
> On Mar 5, 2019, at 10:07 AM, Ian Luo wrote:
>
> It is a good idea to rename it in our major release, say 3.0
>
> -Ian.
>
> On Tue, Mar 5, 2019 at 9:54 AM zhi_guang_...@163.com
> wrote:
>
>> I think it is not a goo
For legacy filter implementations with all logic inside “invoke()”,
compatibility would be a problem. I am not thinking of it yet.
Jun
> On Mar 4, 2019, at 6:49 PM, Ian Luo wrote:
>
> Jun,
>
> The method signature is totally different. Are you indicating a default
> bridge method to address t
> PelicanDT is an integrated test solution for distributed applications.
It helps developers to test distributed applications easily and
efficiently. It can easily implement automatic integration testing of Dubbo.
hi,junyang
There is an issue [1] that plans for integration testing and performance
Hi community,
The Apache Dubbo(incubating) team is pleased to announce that the
2.6.6 has just been released.
Both the source release[1] and the maven binary release[2] are available
now, you can also find the detailed release notes in here[3].
If you have any usage questions, or have problems
On Thu, 7 Mar 2019 at 15:54, Minxuan Zhuang wrote:
>
> Hello Incubator Community,
>
> The Apache Dubbo(incubating) team is pleased to announce that the
> 2.6.6 has just been released.
>
What is the project about? Why should I be interested in it?
[rhetorical questions]
Announce emails are sent t
Hi,
Mark I noticed you added a comment to the Dubbo report but didn’t sign it off.
Any reason for that?
Thanks,
Justin
Further to Sebb's comments, announce emails should reference your download page
http://dubbo.apache.org/en-us/blog/download.html instead of the dyn/closer
link.
The download page should also contain a link for instructions how to verify the
release, along with a link to the KEYS file with the
Hi, all
I noticed that @cvictory made a very good issue[1], I think we can have
more discussion, so I brought it here:
There are so much threadpool that manage only one thread , and this thread
is idle. The threadpool as follow:
*
org.apache.dubbo.metadata.support.AbstractMetadataReport#reportCa
It does sound like a bug, we should merge consumer's configuration instead
of creating two consumer beans. Would you mind to remove 'id' from
and give it a try?
I also filed an issue[1] to track it.
Thanks,
-Ian.
1. https://github.com/apache/incubator-dubbo/issues/3618
On Thu, Mar 7, 2019 at
I think we don't need such a complex rule at all. More reviewers on it,
more confidence it will give the author. I think there's a chance for
reviewers more than one looking into one pull request because this pull
request may look interesting
On Thu, Mar 7, 2019 at 5:04 PM Huxing Zhang wrote:
>
I think we don't need such a complex rule at all. More reviewers on it,
more confidence it will give the author. I think there's a chance for
reviewers more than one looking into one pull request because this pull
request may look interesting to them. I don't worry too much since
eventually they wi
+1 to announce EOL of 2.5.x as soon as possible.
On Thu, Mar 7, 2019 at 6:04 PM jun liu wrote:
> > IMO, we should consider announce the end of life in the near future,
> > say 1 year, and only support critical bug fix or security fix,
>
> In fact, 2.5.x has been out of the community’s daily main
Looks good to me. Let's target it to 2.7.1 release if you can make your
change ready for review soon.
-Ian.
On Thu, Mar 7, 2019 at 6:01 PM Minxuan Zhuang wrote:
> Hello Dubbo Community,
>I'd like to add metrics support in dubbo admin based on this[1], when
> it's done, we can check dubbo s
Mercy, would you mind to file an issue against this and target it to 3.0
release?
Thanks,
-Ian.
On Thu, Mar 7, 2019 at 8:58 PM jun liu wrote:
> +0 to rename.
>
> Agree to rename on 3.0, if we finally decide to do that.
>
> Jun
>
> > On Mar 5, 2019, at 10:07 AM, Ian Luo wrote:
> >
> > It is a g
Hi, all
In my opinion, both suggestions are good.
But what I need to remind is that we should have at least one deadline to
prevent a pr from being suspended for a long time.
Thx.
Ian Luo 于2019年3月8日周五 上午10:41写道:
> I think we don't need such a complex rule at all. More reviewers on it,
> more c
Agree, a deadline is a good suggestion. It requires all committers look
into pull request more actively.
-Ian.
On Fri, Mar 8, 2019 at 10:47 AM yuhang xiu wrote:
> Hi, all
>
> In my opinion, both suggestions are good.
> But what I need to remind is that we should have at least one deadline to
>
+1
Ian Luo 于2019年3月8日周五 上午10:42写道:
> +1 to announce EOL of 2.5.x as soon as possible.
>
> On Thu, Mar 7, 2019 at 6:04 PM jun liu wrote:
>
> > > IMO, we should consider announce the end of life in the near future,
> > > say 1 year, and only support critical bug fix or security fix,
> >
> > In fa
43 matches
Mail list logo