Hi,
I vote with: +1 release the software
I also checked LICENSE and NOTICE file in the binary distribution with
bin-distribution-check.sh and all look good.
Are release files in correct location? Yes
Do release files have the word incubating in their name? Yes
Are the digital signature and
I recommend that you enforce this socially rather than technically.
There are times when a committer needs to get something committed (CI is
broken, security fix, correct an obvious bug that is blocking something
else, etc.) and having the flexibility to just commit it can be very
helpful.
Mark
[x ] 2019-9-15 (half year later)
I also suggest there should have a rule for end of life time amd include
them in roadmap.
End of life message should earlier share via blog, twitter and email to
user to let them have time to update version.
在 2019年3月19日星期二，victory 写道：
> [x ] 2019-9-15 (half yea
Hi,
On Wed, Mar 20, 2019 at 6:08 PM Mark Thomas wrote:
>
> I recommend that you enforce this socially rather than technically.
>
> There are times when a committer needs to get something committed (CI is
> broken, security fix, correct an obvious bug that is blocking something
> else, etc.) and h
+1 to release
I checked:
* both source and binary signatures are good
* both have incubating in name
* DISCLAIMER, LICENSE and NOTICE exists
* all source files no binary
* ASF file header check passed with: mvn clean compile -Drat.skip=false
-Dcheckstyle.skip=false
* All UTs can pass on my Mac OS
Hi,
I am thinking of applying a label called "first-time-contributor" to
those who send pull request first time. The purpose is to better
identify those people and hope the community would act more quickly to
those pull request in order to help them getting merged.
Currently only those who had wr
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exits
- LICENSE and NOTICE file
- Source file have ASF headers. There are a few xml files and shell scripts
that are missing ASF headers.
- No unexpected final files in the source release
- Can compile
Hi,
-1 (binding) as this release seems to includes a GPL (a category X) dependancy.
[3]
After compiling I also noticed it pulls down material that is under copyright
and I don’t believe we have permission to distribute [1][2]
Re copyright of that text:
"In Praise of Idleness and Other Essays (
+1 to release
I checked:
* both source and binary signatures are good
* both have incubating in name
* DISCLAIMER, LICENSE and NOTICE exists
* All UTs can pass on my Mac OSX with JDK 1.8
* I deployed the Admin locally and checked some pages opening them in browser,
work fine.
Jun
> On Mar 19, 2
It seems unnecessary since GitHub does this for this. You can open any pull
request and will notice GitHub has nicely done this for us.
Thanks,
-Ian.
On Thu, Mar 21, 2019 at 10:03 AM Huxing Zhang wrote:
> Hi,
>
> I am thinking of applying a label called "first-time-contributor" to
> those who s
Hi,
Also this in [1] is not a good idea. The date needs to the the date of release
not the current date.
" Copyright ©{{ new
Date().getFullYear() }} The Apache Software Foundation.”
I believe this has come up before on this list?
Thanks,
Justin
1. ./dubbo-admin-ui/src/components/public/Footer
Hi Justin,
On Thu, Mar 21, 2019 at 11:02 AM Justin Mclean wrote:
>
> Hi,
>
> -1 (binding) as this release seems to includes a GPL (a category X)
> dependancy. [3]
>
> After compiling I also noticed it pulls down material that is under copyright
> and I don’t believe we have permission to distri
Hi,
On Thu, Mar 21, 2019 at 11:29 AM Justin Mclean wrote:
>
> Hi,
>
> Also this in [1] is not a good idea. The date needs to the the date of
> release not the current date.
> " Copyright ©{{ new
> Date().getFullYear() }} The Apache Software
> Foundation.”
Agree, it should be static number Co
Hi,
> These dependencies are all development time dependencies, which can be
> found in "devDependencies" section of package.json file.
Anyone who compiles the source will get these and be unaware of them, that
seems a little problamatic to me.
> For node-notifier, which is also a dev dependenc
Hi,
On Thu, Mar 21, 2019 at 11:20 AM Ian Luo wrote:
>
> It seems unnecessary since GitHub does this for this. You can open any pull
> request and will notice GitHub has nicely done this for us.
As I stated before:
- Not everyone can see it, only committers can see it. You can try it
by opening
Hi,
Having a closer look I see that “npm ls” shows a dependancy on
echarts@4.2.1-rc1. This is unreleased code [1]. Is this correct?
Thanks,
Justin
1. https://github.com/apache/incubator-echarts/releases/tag/4.2.1-rc1
Hi,
On Thu, Mar 21, 2019 at 1:45 PM Justin Mclean wrote:
>
> Hi,
>
> > These dependencies are all development time dependencies, which can be
> > found in "devDependencies" section of package.json file.
>
> Anyone who compiles the source will get these and be unaware of them, that
> seems a litt
Hi Justin
I run "npm ls | grep echarts" on tag 0.2.0, but gets no result. dubbo
admin use echarts 4.0.4 to support metrics on develop branch, but the
feature is not in the release
On Thu, Mar 21, 2019 at 2:11 PM Huxing Zhang wrote:
> Hi,
>
> On Thu, Mar 21, 2019 at 1:45 PM Justin Mclean wro
It??s a good idea. Can we let the dubbo bot do this work to add the label to
prs automatically?
-- Original --
From: Huxing Zhang
Date: Thu,Mar 21,2019 1:47 PM
To: dev
Subject: Re: Applying a label "first-time-contributor" to pull request
Hi,
On Thu, Mar
19 matches
Mail list logo
