+1 to release I checked: * both source and binary signatures are good * both have incubating in name * DISCLAIMER, LICENSE and NOTICE exists * all source files no binary * ASF file header check passed with: mvn clean compile -Drat.skip=false -Dcheckstyle.skip=false * All UTs can pass on my Mac OSX with JDK 1.8
I also found the lack of some sub-modules in the binary package. But It’s not a blocking issue because the current binary release has little meaning for users, I believe few users will use the binary directly. Agree the next time we replace it with a more meaningful quick-start like demo along with some bootstrap scripts, this topic was discussed in here: https://github.com/apache/incubator-dubbo/issues/2491 Jun > On Mar 19, 2019, at 3:29 PM, Huxing Zhang <hux...@apache.org> wrote: > > Hi, > > I vote with: > +1 release the software > > Minor issues: > > In the binary distributions, some jar files are missing. For example, > the recently added etcd and consul support as registry and config > center. > I think the current binary distribution is meaningless. It is only a > list of jar files, which can be found in the maven repository. > I suggest to add some more examples to let user quickly bootstrap and > test Dubbo in the future. > > Is the issue minor? Yes > Yes No Unsure > Could it possibly be fixed in the next release? Yes > Yes No Unsure > > Details: > > Are release files in correct location? Yes > Do release files have the word incubating in their name? Yes. > Are the digital signature and hashes correct? Yes > Does DISCLAIMER file exist? Yes > Do LICENSE and NOTICE files exists? Yes > Is the LICENSE and NOTICE text correct? Yes > Is the NOTICE year correct? Yes > Un-included software dependencies are not mentioned in LICENSE or NOTICE? > Yes > License information is not mentioned in NOTICE? Yes > Is there any 3rd party code contained inside the release? If so: > > Does the software have a compatible license? Yes > Are all software licenses mentioned in LICENSE? Yes > Is the full text of the licenses (or pointers to it) in LICENSE? Yes > Is any of this code Apache licensed? Do they have NOTICE files? If so: > Have relevant parts of those NOTICE files been added to this NOTICE file? > Yes > > Do all source files have ASF headers? Yes > Do the contents of the release match with what's tagged in version > control? Yes > Are there any unexpected binary files in the release? No > Can you compile from source? Are the instruction clear? Yes > > On Tue, Mar 19, 2019 at 11:19 AM Ian Luo <ian....@gmail.com> wrote: >> >> Hello Dubbo Community, >> >> This is a call for vote to release Apache Dubbo (Incubating) version 2.7.1. >> >> The release candidates (RC1): >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.7.1 >> >> Git tag for the release (RC1): >> https://github.com/apache/incubator-dubbo/tree/dubbo-2.7.1 >> >> Hash for the release tag: >> a36cc7520e0150d07d30e8baa0c61d5f9f11e6ed >> >> Release Notes: >> https://github.com/apache/incubator-dubbo/blob/dubbo-2.7.1/CHANGES.md >> >> The artifacts have been signed with Key: 9C44B5A6884984DB, which can be >> found in the keys file: >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS >> >> The vote will be open for at least 72 hours or until necessary number of >> votes are reached. >> >> Please vote accordingly: >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> >> Thanks, >> The Apache Dubbo (Incubating) Team > > > > -- > Best Regards！ > Huxing
