Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread Jun Liu
Hi, Xinming As Justin has pointed. It’s fine to use some binary files during developing and include them in the source repo. What volatiles the Apache rule is that we cannot package any binary files into the Apache source release package[1], that should be excluded when packaging if there’s any

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread xinming he
Thanks for your suggestion, Justin. And how about if I change to the jar where come from [1] clearly provided by [2] and mentioned in README as following: 'As of version 3.5.5, the parent, zookeeper and zookeeper-jute artifacts are deployed to the central repository after the release is voted on

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread Justin Mclean
Hi, > The jar file is used to start the zookeeper process for code unit testing > temporarily which I download it from [1]. Is there any problem? That depends on if if jar is made from released code or not. I’m a little uncomfortable on having a source release depend on a jar whose origins are

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread xinming he
Hi, The jar file is used to start the zookeeper process for code unit testing temporarily which I download it from [1]. Is there any problem? Thanks, Xinming He. 1. http://central.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.9/zookeeper-3.4.9.jar Justin Mclean 于2019年11月4日周一 下午4:06写道:

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread Justin Mclean
Hi, I noticed that before_ut.sh is missing an execute bit. I also noticed that the install script grabs a jar from here [1]. How is that jar produced? Thanks, Justin 1. https://github.com/dubbogo/resources/tree/master/zookeeper-4unitest/contrib/fatjar