Re: Suggestions on the organizational form of the code repository after confirming the submission of the dubbo code to apache

2018-03-13 Thread shang zonghai
We expect to agree on the following points: 1. Can we put the project at https://github.com/apache/ ? for example: a. alibaba/dubbo move to https://github.com/apache/incubator-dubbo b. dubbo/dubbo.github.io move to https://github.com/apache/inc

Re: About the parent pom, groupId and package name of Dubbo project

2018-03-19 Thread shang zonghai
2. Shall we need to change all the java package name to org.apache.* ? If do this, users will encounter the upgrading problem. The current package is com.alibaba.dubbo right? Unfortunately this puts us into a "you have to rename it" situation. Including the company name in the package is a p

Re: About the parent pom, groupId and package name of Dubbo project

2018-03-19 Thread shang zonghai
case 2: The user is convenient to upgrade dubbo to apache version( change com.alibaba.xxx to com.apache.xx), consumer and server upgrades at the same time. We can provide tools to automatically convert the package name, the name of the extension interceptor, the package name of the xml con

Re: About the parent pom, groupId and package name of Dubbo project

2018-03-19 Thread shang zonghai
Thank you very much for your valuable advice. What we are worried about is whether or not it will affect the graduation from apache incubation. 在 2018年3月20日,10:41,John D. Ament mailto:johndam...@apache.org>> 写道: On Mon, Mar 19, 2018 at 10:32 PM Yong Zhu mailto:diecui1...@gmail.com>> wrote:

Re: About the parent pom, groupId and package name of Dubbo project

2018-03-20 Thread shang zonghai
>> 3. In quick start section, the com.alibaba.* group id in still in use, >> is it possible to keep it until next release? > > I would be OK with that as long as the long term plan is removed prior to > graduation. I expect to be able to take this part of the job, hope to contribute to the ap

Re: [apache/incubator-dubbo] [Suggestion] What about migrating from Javassist to Byte Buddy (#1504)

2018-03-25 Thread shang zonghai
+1, The Runtime code generation should be reconstructed into “SPI”, the dubbo framework itself is designed to be highly scalable. > 在 2018年3月26日,11:37,jun liu 写道: > >> But I am not sure whether the runtime code generation is a SPI >> or not. That is to say, should we regard the bytecode genera

Re: List volume and issue tracking

2018-04-07 Thread shang zonghai
I was also confused by a lot of mixed emails. For this topic, I have the following suggestions: 1. All pull requests are sent to the current dev@dubbo.apache.org. Pr contains final solution to problem solution or feature enhancement capabilities, all users and deve

Re: List volume and issue tracking

2018-04-08 Thread shang zonghai
+1 Kind regards, yiji

Re: Is Spring Optional?

2018-04-08 Thread shang zonghai
SPI: com.alibaba.dubbo.container.Container Default SpringContainer extends this API,The dubbo-config-spring module supports spring-related functions. Dubbo design goals are highly scalable, allowing custom extensions to support more DI containers. Kind regards, yiji > 在 2018年4月8日,22:27,John

Re: Is Spring Optional?

2018-04-08 Thread shang zonghai
bo/container/Container.java#L24 > > But it's a step, let me play around with it a bit. > > John > > On Sun, Apr 8, 2018 at 10:36 AM shang zonghai > wrote: > >> >> SPI: com.alibaba.dubbo.container.Container >> >> Default SpringContainer e

Re: Is Spring Optional?

2018-04-08 Thread shang zonghai
Many other frameworks leverage a > META-INF/services ServiceLoader pattern. > > John > > On Sun, Apr 8, 2018 at 11:22 AM shang zonghai > wrote: > >> The meaning of the SPI default use springContainer, allow custom >> extensions. >> >> yiji >> &

Re: [Suggestion] PR failing if test coverage went down

2018-04-15 Thread shang zonghai
+1 for considering small changes. We need resources to improve existing unit tests and increase unit coverage. Best Regards! yiji

Re: Moving hessian-lite from Dubbo codebase to eco-system

2018-05-13 Thread shang zonghai
1. Can you just use their released version? Internal version has fixed a lot of bugs, there is an incompatibility risk when using the release version in the short term. Before using the release version, we need to submit the repaired feature to owner / maintainers of hessian-lit. yiji > 在 201

Re: [ANN] New committer: zonghaishang(yiji)

2018-06-06 Thread shang zonghai
Hi all, Thank you for your congratulation,It is a great honor to be a member of the committer, my name is zonghaishang(yiji), I come from Youzan Technology Co., Ltd. In the future, I will work with the dubbo team to create a better dubbo ecosystem, will also better serve the community. Best R