[VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0

2019-01-30 Thread Mercy Ma
Hello Dubbo Community, This is a call for the vote to release Apache Dubbo Spring Boot Project (Incubating) version 2.7.0 The release candidates: 2.7.0: https://dist.apache.org/repos/dist/release/incubator/dubbo/spring-boot-project/2.7.0/ Git tag for the release: 2.7.0: *https://github.com/apac

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0

2019-01-30 Thread Huxing Zhang
Hi, Just a quick check. Since the package is renamed to org.apache, we need to deploy the artifacts to ASF staging repository and include the url in the vote email. I also found that we should remove netty in the NOTICE file. On Wed, Jan 30, 2019 at 11:48 PM Mercy Ma wrote: > > Hello Dubbo Comm

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0

2019-01-30 Thread Huxing Zhang
Hi, I see the version has been update to 2.7.0. Personally I think this is better because it aligns with the Dubbo version, which make user easier to figure out. My question is how should we deal with Spring boot 2.x. and 1.x, does this release contains support for both versions? In the previous

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0

2019-01-30 Thread Huxing Zhang
Hi, On Wed, Jan 30, 2019 at 11:48 PM Mercy Ma wrote: > > Hello Dubbo Community, > > This is a call for the vote to release Apache Dubbo Spring Boot Project > (Incubating) version 2.7.0 > > The release candidates: > 2.7.0: > https://dist.apache.org/repos/dist/release/incubator/dubbo/spring-boot-pr

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0

2019-01-31 Thread Mercy
Thanks, I will issue a new vote for RC2. Kind regards, Mercy Ma 在 2019/1/31 上午10:21, Huxing Zhang 写道: Hi, On Wed, Jan 30, 2019 at 11:48 PM Mercy Ma wrote: Hello Dubbo Community, This is a call for the vote to release Apache Dubbo Spring Boot Project (Incubating) version 2.7.0 The release

[VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC2]

2019-01-31 Thread Mercy Ma
Hello Dubbo Community, This is a call for the vote to release Apache Dubbo Spring Boot Project (Incubating) version 2.7.0 The release candidates (RC2): 2.7.0: https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/2.7.0 The staging repo: https://repository.apache.org/content/

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0

2019-01-31 Thread Mercy
Dubbo Spring Boot 2.7.0 provides some compatiable modules that are compatible between Spring Boot 1.x and 2.x. For example, dubbo-spring-boot-autoconfigure that is based on Spring Boot Starter API and depends dubbo-spring-boot-autoconfigure-compatible, thus *-compatible modules work well in S

[VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC3]

2019-02-01 Thread Mercy Ma
Hello Dubbo Community, This is a call for the vote to release Apache Dubbo Spring Boot Project (Incubating) version 2.7.0 The release candidates (RC3): 2.7.0: https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/2.7.0 The staging repo: https://repository.apache.org/content/

[VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-01 Thread Mercy Ma
Hello Dubbo Community, This is a call for the vote to release Apache Dubbo Spring Boot Project (Incubating) version 2.7.0 The release candidates (RC4): 2.7.0: https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/2.7.0 The staging repo: https://repository.apache.org/content/

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC2]

2019-01-31 Thread Ian Luo
-1 I noticed that there are only three files existing in apache-dubbo-spring-boot-project-incubating-2.7.0-bin-release.zip, which are: $ zipinfo apache-dubbo-spring-boot-project-incubating-2.7.0-bin-release.zip Archive: apache-dubbo-spring-boot-project-incubating-2.7.0-bin-release.zip Zip file

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC3]

2019-02-01 Thread Ian Luo
-1 I found the code snippet in README and comment in configuration files still use old package name starting with com.alibaba, which should be changed to apache package. Otherwise, it will confuse peoples. Thanks, -Ian. On Fri, Feb 1, 2019 at 4:34 PM Mercy Ma wrote: > Hello Dubbo Community, >

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC3]

2019-02-01 Thread Mercy Ma
Ok, I will fix this issue and re-issue a new vote. Kind regards Mercy Ma On Fri, Feb 1, 2019 at 5:01 PM Ian Luo wrote: > -1 > > I found the code snippet in README and comment in configuration files still > use old package name starting with com.alibaba, which should be changed to > apache packa

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-01 Thread Ian Luo
+1 to approve, this release looks good to me. I checked the following items: 1. Are release files in correct location? pass 2. Do release files have the word incubating in their name? pass 3. Are the digital signature and hashes correct? pass 4. Does DISCLAIMER file exist? pass 5.

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-01 Thread Mercy Ma
+1 I have checked the following list: 1. Are release files in correct location? pass 2. Do release files have the word incubating in their name? pass 3. Are the digital signature and hashes correct? pass 4. Does DISCLAIMER file exist? pass 5. Do LICENSE and NOTICE files exists? pas

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-01 Thread Huxing Zhang
Hi, +1 to release. I checked: - incubating in name - signatures and hashes are good - DISCLAIMER exists - LICENSE and NOTICE are good - all source files have ASF headers - can compile from source - Unit test passed on Java 11 - the contents of the release match with 2.7.0 tag - no unexpected bin

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-02 Thread jun liu
+1 binding I checked: * signatures are good * incubating in name * DISCLAIMER, LICENSE and NOTICE exists * all files no binary * ASF file header check passed with: mvn clean compile -Drat.skip=false -Dcheckstyle.skip=false * All UTs can pass on my Mac OSX JDK 1.8 Jun > On Feb 1, 2019, at 5:51 P

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-06 Thread Mark Thomas
On 01/02/2019 09:51, Mercy Ma wrote: > [X] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason Mark Notes (no action required): Signatures and hashes match .gitignore file not included in source release Maven wrapper not present in source release mvn verify completed successful

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-10 Thread Mercy
We’ve received 4 +1 binding and 1 +1 non-binding votes: +1 binding, Ian Luo +1 binding, Mercy Ma +1 binding, Huxing Zhang +1 binding, Jun Liu +1 non-binding, Mark Tomas The issue about the working directory will be solved in next release. I will create a new vote thread in the Apache community

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-11 Thread Willem Ning Jiang
Mark is the mentor of Dubbo, he is part of PPMC, so his vote is binding one. The RC4 is misleading. we just count the same project and version for the RC number to avoid the confusion of version number, not count all the release candidate since the incubation. In your vote, it's only RC1. On

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-11 Thread Mercy
Ok, I got it, thanks, mentor. :-) Kind regards, Mercy Ma 在 2019/2/12 上午11:42, Willem Ning Jiang 写道: Mark is the mentor of Dubbo, he is part of PPMC, so his vote is binding one. The RC4 is misleading. we just count the same project and version for the RC number to avoid the confusion of versi

Re: [VOTE]: Release Apache Dubbo Spring Boot Project (Incubating) 2.7.0 [RC4]

2019-02-13 Thread Huxing Zhang
Hi, On Tue, Feb 12, 2019 at 11:42 AM Willem Ning Jiang wrote: > > > Mark is the mentor of Dubbo, he is part of PPMC, so his vote is binding one. > The RC4 is misleading. we just count the same project and version for the RC > number to avoid the confusion of version number, not count all the rel