[RESULT] [VOTE]: Release Apache Dubbo-go v1.1.0 [RC2]

2019-10-10 Thread stocks alex
Hello Dubbo/Dubbogo Community, The release V1.1.0 RC2 vote finished, We’ve received +1 binding, victory [shenglic...@gmail.com] +1 binding, Ian Luo [ian@gmail.com] +1 binding, YunKun Huang [hty...@gmail.com] The vote and result thread: https://lists.apache.org/list.html?dev@dubbo.apach

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-26 Thread victory
+1 I checked the following items: [√] Do LICENSE and NOTICE files exists? [√] Is the LICENSE and NOTICE text correct? [√] Is the NOTICE year correct? [√] Do all source files have ASF headers? [√] Do the contents of the release match with what's tagged in version control? [√] Can you compile from

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-18 Thread Ian Luo
+1 I checked the following items: [v] Are release files in correct location? [v] Do release files have the word incubating in their name? [v] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [v] Is the LICENSE and NOTICE text correct? [v] Is the NOTICE year c

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-17 Thread YunKun Huang
sorry typo mirror should be minor On Tuesday, September 17, 2019, YunKun Huang wrote: > +1 approve > > I have checked: > 1.source code can build > 2.tests can pass in my local > 3. NOTICE LICENSE file exist > 4.git tag is correct > > there is one mirror thing that in change logs file, there is n

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-17 Thread YunKun Huang
+1 approve I have checked: 1.source code can build 2.tests can pass in my local 3. NOTICE LICENSE file exist 4.git tag is correct there is one mirror thing that in change logs file, there is no space between text And link. I suggest add one to make it looks better. On Monday, September 16, 2019,

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-16 Thread stocks alex
Dr PPMCs/PMCs, Do u think is there any other problems of 1.1.0 RC2 release ( https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/)? If not, pls vote for it. Thx very much. Alex stocks alex 于2019年9月7日周六 下午6:54写道: > Hello Dubbo/Dubbogo Community, > > This is a call for vote to release A

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-16 Thread stocks alex
Yeah. Can not agree with you more. I think we need not to modify it just for a license declaration. Justin Mclean 于2019年9月9日周一 下午10:41写道: > Hi, > > > Since Justin suggests you to put all artifacts in RC2 directory, you may > > not consider this email as an official vote, but I did spend a little

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-16 Thread stocks alex
To Mr Ian and Mr Justin, The source file protocol/mock/mock_invoker.go is generated by a mock tool gomock(github.com/golang/mock/gomock). The file has a header declaration as follows, ''' // Code generated by MockGen. DO NOT EDIT. // Source: invoker.go // Package mock is a generated GoMock pack

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-09 Thread Justin Mclean
Hi, > Since Justin suggests you to put all artifacts in RC2 directory, you may > not consider this email as an official vote, but I did spend a little time > on sanity check against your second release. While potentially confusing, I would leave this vote open and treat it as “official”. Take my

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-09 Thread Ian Luo
Alex, Since Justin suggests you to put all artifacts in RC2 directory, you may not consider this email as an official vote, but I did spend a little time on sanity check against your second release. For the source code, it looks fine except for one file: protocol/mock/mock_invoker.go doesn't have

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-07 Thread stocks alex
To Mr Justin Mclean, Thx for your good advice. I will do it as your suggestion. Justin Mclean 于2019年9月7日周六 下午10:31写道: > Hi, > > > This is a call for vote to release Apache Dubbo-go version v1.1.0 RC2. > > The release candidates: > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ >

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-07 Thread Justin Mclean
Hi, > This is a call for vote to release Apache Dubbo-go version v1.1.0 RC2. > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ Please don’t overwrite the exacting artefact being voted on as we then have no way of knowing which they voted on. They could also

[VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-07 Thread stocks alex
Hello Dubbo/Dubbogo Community, This is a call for vote to release Apache Dubbo-go version v1.1.0 RC2. The release candidates: https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ Git tag for the release: https://github.com/apache/dubbo-go/tree/1.1 Hash for the release tag: 1747ef485b