Github user senthilec566 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/84#issuecomment-182518082
I applied the patch and run and found many issues with code structure,
error handling, existing code compatibility etc, let us hold off this patch and
let me
GitHub user senthilec566 opened a pull request:
https://github.com/apache/incubator-eagle/pull/84
EAGLE-81 Notification Plugin Framework
#77
For more details:
https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework
You can merge this pull
Github user senthilec566 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-180541169
@senthilec566 can you make sure all checks are passed, I could not apply
this patch to test in my local.
LM-SJN-00876985:incubator-eagle yonzhang$ git
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-178293138
Multiple issues:
1. Config object should be injected when topology is started from driver
program. In AlertNotificationExecutor prepareConfig, we should
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-178337894
1# Will refactor config object injection code.
2 # notificationType - this field was not used anymore.. I missed to remove
it from Tags..
I
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-177281570
Looks like Hadoop Metric Test Case failing :(
Failed tests:
testNameNodeLag(org.apache.eagle.hadoop.metric.TestHadoopMetricSiddhiQL)
---
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-177428363
@yonzhang , Can you have a look into code now? ..
" Policy evaluation and notification are possibly in different physical
machines "
In this
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-177055012
@yonzhang , In Notification isPluginLoaded is unused ( i was using
different approach previously ), i'll remove it . As you mentioned onAlert &
Github user senthilec566 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user senthilec566 opened a pull request:
https://github.com/apache/incubator-eagle/pull/77
EAGLE-81 Notification Plugin Framework
Captured design here in Confluence :
https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework
We may need
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176211320
@yonzhang , can you clarify this statement
"This policy is deleted by still there are some alerts associated with this
policy id"
---
If your
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176191482
Thanks for redoing pull request. I don't understand why we need bind
notificationType with AlertDefinitionAPIEntity. Doesn't
AlertDefinitionAPIEntity has a
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176209450
NotificationManager and NotificationPluginLoader should be singleton
object, and also we need think of that multiple thread may invoke the
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176529321
@senthilec566 yes, when the policy is deleted, it is still possible that
notification executor receive an alert for this policy because policy
evaluation and
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176529447
In NotificationPluginLoader, what is the purpose of isPluginLoaded? Also I
saw that exceptions are not correctly handled.
---
If your project is set up for
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176220337
@yonzhang is it something , that if the policy deleted still alerts can be
there .. Pls help me to understand so that i can change code ..
---
If your
Github user RalphSu commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175927655
Eagle already have a class scanning lib. You might want to check the
EntityRepositoryScanner for the current usage. We might keep stick to one
scanning library
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175976351
@RalphSu , Yes , Eagle has Entity Repository Scanner. If i want to use
EntityScanner, the entity should be registered with Entity Repository..
My
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-176018966
@yonzhang , thanks Edward , Let me rebase it ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-176016132
@senthilec566 I have difficulty to apply the patch into current master (in
my local), probably you need do rebase.
git apply 76.patch
error:
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175541837
Missed to add table creation scritps :( .. Will add it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175636078
Now code is ready for Review , the only pending thing is which API is good
for Scanning Classes , Java SPI or Reflection ??
Right now
24 matches
Mail list logo
