GitHub user yonzhang opened a pull request:
https://github.com/apache/incubator-eagle/pull/89
EAGLE-81 Notification plugin
1. plugin configured in eagle service
2. plugin base interfaces
3. plugin-example in eagle-examples/eagle-topology-example
4. email is default plugin
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/89#issuecomment-185033900
unit test failure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yonzhang closed the pull request at:
https://github.com/apache/incubator-eagle/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
GitHub user yonzhang opened a pull request:
https://github.com/apache/incubator-eagle/pull/90
EAGLE-81 Notification plugin
Features:
1. plugin configured in eagle service
2. plugin base interfaces
3. plugin-example in eagle-examples/eagle-topology-example
4. email is
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/90#issuecomment-185321759
solved and closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yonzhang closed the pull request at:
https://github.com/apache/incubator-eagle/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/90#issuecomment-185118602
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user RalphSu commented on the pull request:
https://github.com/apache/incubator-eagle/pull/90#issuecomment-185096013
Looks good to me
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user senthilec566 opened a pull request:
https://github.com/apache/incubator-eagle/pull/76
EAGLE-81 Notification Plugin Framework
Captured design here in Confluence :
https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework
We may need t
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175541837
Missed to add table creation scritps :( .. Will add it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175636078
Now code is ready for Review , the only pending thing is which API is good
for Scanning Classes , Java SPI or Reflection ??
Right now Notification
Github user RalphSu commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175927655
Eagle already have a class scanning lib. You might want to check the
EntityRepositoryScanner for the current usage. We might keep stick to one
scanning library
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-175976351
@RalphSu , Yes , Eagle has Entity Repository Scanner. If i want to use
EntityScanner, the entity should be registered with Entity Repository..
My
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-176016132
@senthilec566 I have difficulty to apply the patch into current master (in
my local), probably you need do rebase.
git apply 76.patch
error:
eagle-
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/76#issuecomment-176018966
@yonzhang , thanks Edward , Let me rebase it ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user senthilec566 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
GitHub user senthilec566 opened a pull request:
https://github.com/apache/incubator-eagle/pull/77
EAGLE-81 Notification Plugin Framework
Captured design here in Confluence :
https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework
We may need t
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176191482
Thanks for redoing pull request. I don't understand why we need bind
notificationType with AlertDefinitionAPIEntity. Doesn't
AlertDefinitionAPIEntity has a fiel
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176195726
@yonzhang thanks Edward.. yes you are correct..
"one alert definition should possibly have multiple notification types
associated " , I missed i
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176203753
I think we need to change the way of parsing Notification Definition ..
Will modify this tomorrow to create policy with Multiple Notifications etc..
---
If
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176209450
NotificationManager and NotificationPluginLoader should be singleton
object, and also we need think of that multiple thread may invoke the
updateNotificationPlu
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176211320
@yonzhang , can you clarify this statement
"This policy is deleted by still there are some alerts associated with this
policy id"
---
If your
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176220337
@yonzhang is it something , that if the policy deleted still alerts can be
there .. Pls help me to understand so that i can change code ..
---
If your pro
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176529321
@senthilec566 yes, when the policy is deleted, it is still possible that
notification executor receive an alert for this policy because policy
evaluation and no
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176529447
In NotificationPluginLoader, what is the purpose of isPluginLoaded? Also I
saw that exceptions are not correctly handled.
---
If your project is set up for it,
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-177055012
@yonzhang , In Notification isPluginLoaded is unused ( i was using
different approach previously ), i'll remove it . As you mentioned onAlert &
updataPlugi
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-177278220
@yonzhang Modified code to support more than one Notification in Policy,,
I have removed old way of deserializing notification conf and added to
deseriali
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-177281570
Looks like Hadoop Metric Test Case failing :(
Failed tests:
testNameNodeLag(org.apache.eagle.hadoop.metric.TestHadoopMetricSiddhiQL)
---
If
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-177428363
@yonzhang , Can you have a look into code now? ..
" Policy evaluation and notification are possibly in different physical
machines "
In this c
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-178293138
Multiple issues:
1. Config object should be injected when topology is started from driver
program. In AlertNotificationExecutor prepareConfig, we should save
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-178337894
1# Will refactor config object injection code.
2 # notificationType - this field was not used anymore.. I missed to remove
it from Tags..
I can
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-180541169
@senthilec566 can you make sure all checks are passed, I could not apply
this patch to test in my local.
LM-SJN-00876985:incubator-eagle yonzhang$ git a
Github user senthilec566 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
GitHub user senthilec566 opened a pull request:
https://github.com/apache/incubator-eagle/pull/83
EAGLE-81 Notification Plugin Framework
#77
For more details:
https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework
You can merge this pull request
GitHub user senthilec566 opened a pull request:
https://github.com/apache/incubator-eagle/pull/84
EAGLE-81 Notification Plugin Framework
#77
For more details:
https://cwiki.apache.org/confluence/display/EAG/Notification+Plugin+Framework
You can merge this pull request
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/84#issuecomment-182518082
I applied the patch and run and found many issues with code structure,
error handling, existing code compatibility etc, let us hold off this patch and
let me tr
GitHub user yonzhang opened a pull request:
https://github.com/apache/incubator-eagle/pull/88
EAGLE-81 Notification plugin architecture
1. plugin configured in eagle service
2. plugin base interfaces
3. plugin-example in eagle-examples/eagle-topology-example
Need to
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/88#issuecomment-185025673
to be fixed:
3. alert persist should be after entitydedupe or emaildedupe. Do we really
support alert eaglestore to be a plugin?
---
If your project is se
Github user yonzhang closed the pull request at:
https://github.com/apache/incubator-eagle/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user senthilec566 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user senthilec566 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
41 matches
Mail list logo
